Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 643876 - app-emulation/vagrant please add ruby target ruby24, remove ruby22
Summary: app-emulation/vagrant please add ruby target ruby24, remove ruby22
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tomáš Mózes
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-08 08:58 UTC by OzTiram
Modified: 2018-05-11 10:13 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description OzTiram 2018-01-08 08:58:37 UTC
Hi,

Ruby 2.4 is still not marked stable, but it's quite old now. Hence, I assume you
could use it with Vagrant without any trouble.

As for Ruby 2.2, I am preparing to remove ruby22 from all my systems. Support will be ended in March 2018[1].

As such

[1]: https://www.ruby-lang.org/en/news/2017/12/14/ruby-2-2-9-released/
Comment 1 Tomáš Mózes 2018-01-09 04:35:41 UTC
Last time checked,we didn't have the ruby24 deps,will recheck again. But ruby23 should be gone,yes. Thanks for the reminder.
Comment 2 Tomáš Mózes 2018-01-09 04:36:38 UTC
(In reply to Tomáš Mózes from comment #1)
> Last time checked,we didn't have the ruby24 deps,will recheck again. But
> ruby23 should be gone,yes. Thanks for the reminder.

Sorry,I meant ruby22 :)
Comment 3 OzTiram 2018-01-09 07:47:01 UTC
Yes(In reply to Tomáš Mózes from comment #1)
> Last time checked,we didn't have the ruby24 deps,will recheck again. But
> ruby23 should be gone,yes. Thanks for the reminder.

Yes, some of the dependencies are stuck with old ruby versions.
I initiated the process of bumping them here:

https://github.com/gentoo/gentoo/pull/6798

and here

https://github.com/gentoo/gentoo/pull/6796

So far, I have not received a response from the Ruby team.
But let's see, it might take a couple of more days...
Comment 4 Tomáš Mózes 2018-01-09 07:55:11 UTC
(In reply to OzTiram from comment #3)
> Yes(In reply to Tomáš Mózes from comment #1)
> > Last time checked,we didn't have the ruby24 deps,will recheck again. But
> > ruby23 should be gone,yes. Thanks for the reminder.
> 
> Yes, some of the dependencies are stuck with old ruby versions.
> I initiated the process of bumping them here:
> 
> https://github.com/gentoo/gentoo/pull/6798
> 
> and here
> 
> https://github.com/gentoo/gentoo/pull/6796
> 
> So far, I have not received a response from the Ruby team.
> But let's see, it might take a couple of more days...

Thanks!

Without those deps, we'll have to drop to ruby23 only.
Comment 5 Tomáš Mózes 2018-02-09 06:34:45 UTC
Ruby team, please add ruby24 support for dev-ruby/{netrc,net-scp,net-sftp,rest-client}. Just tested vagrant 2.0.2 with ruby24 and it worked fine. According to the gemspec, they support event ruby25 with the same deps (https://github.com/hashicorp/vagrant/blob/master/vagrant.gemspec). Thank you!
Comment 6 Hans de Graaff gentoo-dev Security 2018-02-09 06:37:58 UTC
(In reply to Tomáš Mózes from comment #2)

> Sorry,I meant ruby22 :)

I see no reason to drop this as long as it is still supported in the tree. Once ruby 2.2 is masked for removal it will become a noop.
Comment 7 Hans de Graaff gentoo-dev Security 2018-02-09 06:39:22 UTC
(In reply to Tomáš Mózes from comment #5)
> Ruby team, please add ruby24 support for
> dev-ruby/{netrc,net-scp,net-sftp,rest-client}. Just tested vagrant 2.0.2
> with ruby24 and it worked fine. According to the gemspec, they support event
> ruby25 with the same deps
> (https://github.com/hashicorp/vagrant/blob/master/vagrant.gemspec). Thank
> you!

For this to happen tests need to pass for these dependencies and as far as I'm aware that is currently not the case, but I haven't looked at any recent work that OzTiram has done on github PRs. Sorry, I've been focused on some other tasks. I'll try to have a look at it this weekend.
Comment 8 Tomáš Mózes 2018-02-09 07:53:22 UTC
(In reply to Hans de Graaff from comment #7)
> (In reply to Tomáš Mózes from comment #5)
> For this to happen tests need to pass for these dependencies and as far as
> I'm aware that is currently not the case, but I haven't looked at any recent
> work that OzTiram has done on github PRs. Sorry, I've been focused on some
> other tasks. I'll try to have a look at it this weekend.

Thank you :)

Given that vagrant users actively use it with >ruby2.3 I suppose the libs should work (they use the same latest version we have). I saw that they haven't received any updates for ages now, but I hope we can use them with newer ruby.
Comment 9 Tomáš Mózes 2018-02-09 07:54:07 UTC
(In reply to Hans de Graaff from comment #6)
> (In reply to Tomáš Mózes from comment #2)
> 
> > Sorry,I meant ruby22 :)
> 
> I see no reason to drop this as long as it is still supported in the tree.
> Once ruby 2.2 is masked for removal it will become a noop.

Ok, no problem to remove it later on. Dropping is of lower priority than introducing the new one :)
Comment 10 Hans de Graaff gentoo-dev Security 2018-05-03 04:23:36 UTC
All dependencies of vagrant now have the ruby24 target.
Comment 11 Tomáš Mózes 2018-05-03 04:28:20 UTC
(In reply to Hans de Graaff from comment #10)
> All dependencies of vagrant now have the ruby24 target.

Yes, Georgy Yakovlev already opened a PR with ruby24 support, thanks :)
Comment 12 Georgy Yakovlev archtester gentoo-dev 2018-05-03 16:44:23 UTC
yup, thanks for work on ruby deps.
I just hit a small issue with 2.0.3 and decided to bump and randomly discovered that ruby24 target is now possible. good timing.

Also I see some of the deps got ruby25 support today, which is nice.
maybe one of the next versions of vagrant can be truly multi-rubied.
Comment 13 Alex Turbov 2018-05-06 12:30:51 UTC
Meanwhile, vargant 2.1.0 is out and officially supported ruby versions are 
"~> 2.2", "< 2.6"...
Comment 14 Georgy Yakovlev archtester gentoo-dev 2018-05-09 23:30:40 UTC
(In reply to Alex Turbov from comment #13)
> Meanwhile, vargant 2.1.0 is out and officially supported ruby versions are 
> "~> 2.2", "< 2.6"...

some deps are still ruby24 only, but it's changing.

bumped the above PR to 2.1.1 and removed ruby22
pr bot should close this bug as soon as it's merged.
Comment 15 Larry the Git Cow gentoo-dev 2018-05-11 10:13:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c09d7926b2815238a41db29739299c48970a2193

commit c09d7926b2815238a41db29739299c48970a2193
Author:     Georgy Yakovlev <ya@sysdump.net>
AuthorDate: 2018-05-09 23:11:56 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-05-11 10:11:18 +0000

    app-emulation/vagrant: add version 2.1.1
    
    Closes: https://bugs.gentoo.org/643876
    Closes: https://bugs.gentoo.org/655344
    Closes: https://github.com/gentoo/gentoo/pull/8239
    Package-Manager: Portage-2.3.36, Repoman-2.3.9

 app-emulation/vagrant/Manifest             |  1 +
 app-emulation/vagrant/vagrant-2.1.1.ebuild | 79 ++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+)