Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 643746 - sci-geosciences/qmapshack-1.9.0: should depend on sci-libs/alglib
Summary: sci-geosciences/qmapshack-1.9.0: should depend on sci-libs/alglib
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrey Grozin
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-06 23:55 UTC by Fabio Rossi
Modified: 2018-01-08 03:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Rossi 2018-01-06 23:55:21 UTC 
qmapshack uses the lib installed by sci-libs/alglib, if not installed then cmake uses the embedded internal version shipped with the sources. To avoid duplicates and security risks, qmapshack should depend unconditionally on sci-libs/alglib.

Here is a portion of CMakeLists.txt:

...

find_package(ALGLIB)

if(NOT ALGLIB_FOUND)
    set(ALGLIB_INCLUDE_DIRS ${CMAKE_CURRENT_SOURCE_DIR}/3rdparty/alglib/src)
    set(ALGLIB_LIBRARIES alg)
    add_subdirectory(3rdparty/alglib)
endif(NOT ALGLIB_FOUND)

...
Comment 1 Larry the Git Cow gentoo-dev 2018-01-08 03:41:54 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0fa99b6331be6612ada5233a50ea9a37ca04f33

commit a0fa99b6331be6612ada5233a50ea9a37ca04f33
Author:     Andrey Grozin <grozin@gentoo.org>
AuthorDate: 2018-01-08 03:41:21 +0000
Commit:     Andrey Grozin <grozin@gentoo.org>
CommitDate: 2018-01-08 03:41:21 +0000

    sci-geosciences/qmapshack: depend on sci-libs/alglib
    
    Closes: https://bugs.gentoo.org/643746
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 .../qmapshack/qmapshack-1.10.0-r1.ebuild           | 40 ++++++++++++++++++++++
 1 file changed, 40 insertions(+)