Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 643684 - dev-python/elasticsearch-py: depends on old version of dev-python/urllib3
Summary: dev-python/elasticsearch-py: depends on old version of dev-python/urllib3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tomáš Mózes
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-06 12:53 UTC by Michał Górny
Modified: 2018-05-11 21:56 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-01-06 12:53:32 UTC
elasticsearch-py-5.4.0.ebuild:RDEPEND=">=dev-python/urllib3-1.8[${PYTHON_USEDEP}]
elasticsearch-py-5.4.0.ebuild:	<dev-python/urllib3-2.0[${PYTHON_USEDEP}]"
elasticsearch-py-5.5.1.ebuild:RDEPEND=">=dev-python/urllib3-1.21.1[${PYTHON_USEDEP}]
elasticsearch-py-5.5.1.ebuild:	<dev-python/urllib3-1.22[${PYTHON_USEDEP}]"
elasticsearch-py-6.0.0.ebuild:RDEPEND=">=dev-python/urllib3-1.21.1[${PYTHON_USEDEP}]
elasticsearch-py-6.0.0.ebuild:	<dev-python/urllib3-1.23[${PYTHON_USEDEP}]"


Please look into making the package work with *any* version of dev-python/urllib3. This really looks like upstream being overcautious.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-01-06 12:53:47 UTC
(this is the only package blocking removal of old)
Comment 2 Tomáš Mózes 2018-01-09 06:53:31 UTC
As I understand, your goal is to remove urllib3 1.21.1?

We just mimic setup.py from upstream: https://github.com/elastic/elasticsearch-py/blob/master/setup.py

The latest has:
install_requires = [
    'urllib3<1.23,>=1.21.1',
]

The older we keep for for ES 5.x support has (in the release tarball):
install_requires = [
    'urllib3<1.22,>=1.21.1',
]

However I see that they added a commit after the release to the 5.5 branch: https://github.com/elastic/elasticsearch-py/commit/ea5d5fdebfae9b8a7a04d5951d87b3cb9c86246c

Which bumps the urllib3 to at least 1.22. So we'll bump urllib3 to 1.22 in 5.5.1, stabilize it and drop 5.4.0, is that ok?
Comment 3 Larry the Git Cow gentoo-dev 2018-02-14 21:55:05 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7fb1874fe2cd8ee139132a5a883be5b9042dea8b

commit 7fb1874fe2cd8ee139132a5a883be5b9042dea8b
Author:     Tomas Mozes <hydrapolic@gmail.com>
AuthorDate: 2018-02-14 13:27:47 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-02-14 21:54:58 +0000

    dev-python/elasticsearch-py: improve ebuild
    
    Bug: https://bugs.gentoo.org/643684
    Package-Manager: Portage-2.3.24, Repoman-2.3.6

 dev-python/elasticsearch-py/Manifest               |  2 +-
 .../elasticsearch-py/elasticsearch-py-6.0.0.ebuild | 27 +++++++++++++---------
 2 files changed, 17 insertions(+), 12 deletions(-)}
Comment 4 Tomáš Mózes 2018-02-22 11:23:35 UTC
@mgorny, you can drop 5.4.0 as 5.5.2 with newer dep is stabilized.
Comment 5 Larry the Git Cow gentoo-dev 2018-05-11 21:56:16 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c1fd264bd45c76e2dd96fe5fe20dd47cd7a47283

commit c1fd264bd45c76e2dd96fe5fe20dd47cd7a47283
Author:     Tomas Mozes <hydrapolic@gmail.com>
AuthorDate: 2018-05-02 13:01:36 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2018-05-11 21:56:11 +0000

    dev-python/elasticsearch-py: drop old.
    
    Package-Manager: Portage-2.3.31, Repoman-2.3.9
    Closes: https://bugs.gentoo.org/643684
    Closes: https://github.com/gentoo/gentoo/pull/8242

 dev-python/elasticsearch-py/Manifest               |  2 -
 .../elasticsearch-py/elasticsearch-py-5.4.0.ebuild | 98 ----------------------
 2 files changed, 100 deletions(-)