flacon-4.0.0 depends on dev-qt/qtconcurrent. Add to RDEPEND list. Reproducible: Always
See https://github.com/gentoo/gentoo/pull/6727
Why do you think flacon requires qtconcurrent? $ equery l qtconcurrent * Searching for qtconcurrent ... [IP-] [ ] dev-qt/qtconcurrent-5.7.1:5/5.7 and $ readelf -d /usr/bin/flacon | grep NEEDED 0x0000000000000001 (NEEDED) Shared library: [libuchardet.so.0] 0x0000000000000001 (NEEDED) Shared library: [libQt5Widgets.so.5] 0x0000000000000001 (NEEDED) Shared library: [libQt5Network.so.5] 0x0000000000000001 (NEEDED) Shared library: [libQt5Gui.so.5] 0x0000000000000001 (NEEDED) Shared library: [libQt5Core.so.5] 0x0000000000000001 (NEEDED) Shared library: [libstdc++.so.6] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgcc_s.so.1] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] Also I can't find signs in the build system that qtconcurrent is needed.
before to blame me, please check the sources. You will never have a dynamic link if you are static linking or if you are using templates or inline code. Then, checking with readelf or ldd is not sufficient. BTW, This is the build log: ... /var/tmp/portage/media-sound/flacon-4.0.0/work/flacon-4.0.0/gui/coverdialog/asynclistwidgetitem.h:31:10: fatal error: QtConcurrent/QtConcurrent: No such file or directory #include <QtConcurrent/QtConcurrent> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [CMakeFiles/flacon.dir/build.make:552: CMakeFiles/flacon.dir/gui/coverdialog/coverdialog.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[2]: Leaving directory '/var/tmp/portage/media-sound/flacon-4.0.0/work/flacon-4.0.0_build' make[1]: *** [CMakeFiles/Makefile2:100: CMakeFiles/flacon.dir/all] Error 2 make[1]: Leaving directory '/var/tmp/portage/media-sound/flacon-4.0.0/work/flacon-4.0.0_build' make: *** [Makefile:152: all] Error 2 * ERROR: media-sound/flacon-4.0.0::gentoo failed (compile phase): * emake failed ...
FWIW, it's very common for qtconcurrent to be used at build time only.
(In reply to Luigi 'Comio' Mantellini from comment #3) > before to blame me, please check the sources. > > You will never have a dynamic link if you are static linking or if you are > using templates or inline code. Then, checking with readelf or ldd is not > sufficient. Hey, I'm not blaming anyone here, just trying to understand. Indeed qtconcurrent is used in sources, but not mentioned in build system. Since qtconcurrent is used at build-time only, you should add it not to RDEPEND, but to DEPEND only.
(In reply to Coacher from comment #5) > (In reply to Luigi 'Comio' Mantellini from comment #3) > > before to blame me, please check the sources. > > > > You will never have a dynamic link if you are static linking or if you are > > using templates or inline code. Then, checking with readelf or ldd is not > > sufficient. > > Hey, I'm not blaming anyone here, just trying to understand. > > Indeed qtconcurrent is used in sources, but not mentioned in build system. > Since qtconcurrent is used at build-time only, you should add it not to > RDEPEND, but to DEPEND only. Revbump is not needed when you change only DEPEND.
(In reply to Coacher from comment #5) > > Hey, I'm not blaming anyone here, just trying to understand. > > Indeed qtconcurrent is used in sources, but not mentioned in build system. > Since qtconcurrent is used at build-time only, you should add it not to > RDEPEND, but to DEPEND only. I'm sorry, English is not my mother language and I lost some nuances and I misinterpreted. Regarding the DEPEND-only usage, I agree with you. I will just check if is there any runtime stuff from qtconcurrent and I will update the PR. Sorry again. ciao luigi
(In reply to Luigi 'Comio' Mantellini from comment #7) > (In reply to Coacher from comment #5) > > > > Hey, I'm not blaming anyone here, just trying to understand. > > > > Indeed qtconcurrent is used in sources, but not mentioned in build system. > > Since qtconcurrent is used at build-time only, you should add it not to > > RDEPEND, but to DEPEND only. > > I'm sorry, English is not my mother language and I lost some nuances and I > misinterpreted. > > Regarding the DEPEND-only usage, I agree with you. I will just check if is > there any runtime stuff from qtconcurrent and I will update the PR. > > Sorry again. > > > ciao > > luigi No problems. I left another comment in your PR:) Thanks!
*** Bug 644812 has been marked as a duplicate of this bug. ***
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f619079436e1d6f667e092a5fd60de08600365c2 commit f619079436e1d6f667e092a5fd60de08600365c2 Author: Luigi 'Comio' Mantellini <luigi.mantellini@gmail.com> AuthorDate: 2018-01-24 13:30:07 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-02-01 01:45:07 +0000 media-sound/flacon: Add dev-qt/qtconcurrent:5 to DEPEND Bug: https://bugs.gentoo.org/643212 Closes: https://bugs.gentoo.org/643212 Closes: https://github.com/gentoo/gentoo/pull/6946 media-sound/flacon/flacon-4.0.0.ebuild | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f619079436e1d6f667e092a5fd60de08600365c2 commit f619079436e1d6f667e092a5fd60de08600365c2 Author: Luigi 'Comio' Mantellini <luigi.mantellini@gmail.com> AuthorDate: 2018-01-24 13:30:07 +0000 Commit: Andreas Sturmlechner <asturm@gentoo.org> CommitDate: 2018-02-01 01:45:07 +0000 media-sound/flacon: Add dev-qt/qtconcurrent:5 to DEPEND Bug: https://bugs.gentoo.org/643212 Closes: https://bugs.gentoo.org/643212 Closes: https://github.com/gentoo/gentoo/pull/6946 media-sound/flacon/flacon-4.0.0.ebuild | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)}
