Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 643022 - versionator.eclass unnecessarily inherits eutils
Summary: versionator.eclass unnecessarily inherits eutils
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jonathan Callen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-01 19:31 UTC by Ulrich Müller
Modified: 2018-01-09 10:21 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for versionator.eclass (versionator.eclass.diff,551 bytes, patch)
2018-01-01 19:32 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2018-01-01 19:31:06 UTC
As far as I can see, the only functions needed from eutils.eclass are eshopts_push and eshopts_pop. These have been split off to estack.eclass some time ago.

See also the following commit which added the eutils inherit:
https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/versionator.eclass?r1=1.16&r2=1.17
Comment 1 Ulrich Müller gentoo-dev 2018-01-01 19:32:42 UTC
Created attachment 512648 [details, diff]
Patch for versionator.eclass

Attached trivial patch fixes it.
Comment 2 Jonathan Callen (RETIRED) gentoo-dev 2018-01-01 20:51:16 UTC
Looks good to me
Comment 3 Larry the Git Cow gentoo-dev 2018-01-09 10:21:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=35bab31cf7eddeb14cace10ee3e713c881cc0447

commit 35bab31cf7eddeb14cace10ee3e713c881cc0447
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2018-01-02 10:16:25 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2018-01-09 10:21:18 +0000

    versionator.eclass: inherit estack rather than eutils.
    
    The only functions needed from eutils.eclass are eshopts_push and
    eshopts_pop, which have been split off to estack.eclass.
    
    See also commit 401ef96525d8c21c33bdd6e88e475e09f3a42717
    (in historical.git) which added the eutils inherit.
    
    Closes: https://bugs.gentoo.org/643022

 eclass/versionator.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)