Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 642794 - app-office/openoffice-bin: Migrate from LINGUAS to L10N USE_EXPAND
Summary: app-office/openoffice-bin: Migrate from LINGUAS to L10N USE_EXPAND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Chí-Thanh Christopher Nguyễn
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: linguas-to-l10n
  Show dependency tree
 
Reported: 2017-12-31 03:21 UTC by Chí-Thanh Christopher Nguyễn
Modified: 2018-01-12 11:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chí-Thanh Christopher Nguyễn gentoo-dev 2017-12-31 03:21:24 UTC
app-office/openoffice-bin currently uses LINGUAS USE_EXPAND to determine SRC_URI. Conversion to L10N should be mostly straightforward, but with two difficulties:

The Catalan Valencian locale is "ca_XV" in OpenOffice, and needs to be translated to BCP 47 "ca-valencia".

Also, it calls strip-linguas from eutils.eclass for which there is no l10n equivalent.
Comment 1 Larry the Git Cow gentoo-dev 2018-01-06 12:56:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=871bc49b84d26598cbe3a3b8a792cea0cefc195d

commit 871bc49b84d26598cbe3a3b8a792cea0cefc195d
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2018-01-06 12:54:26 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2018-01-06 12:55:39 +0000

    app-office/openoffice-bin: Migrate from LINGUAS to L10N.
    
    Closes: https://bugs.gentoo.org/642794
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 .../openoffice-bin/openoffice-bin-4.1.4.ebuild     | 23 ++++++++++++----------
 .../openoffice-bin/openoffice-bin-4.1.5.ebuild     | 23 ++++++++++++----------
 2 files changed, 26 insertions(+), 20 deletions(-)
Comment 2 Chí-Thanh Christopher Nguyễn gentoo-dev 2018-01-11 14:38:50 UTC
Thanks!
Comment 3 Ulrich Müller gentoo-dev 2018-01-12 11:45:27 UTC
(In reply to Chí-Thanh Christopher Nguyễn from comment #2)
> Thanks!

No problem, after you had spotted the problems already. :)

Looking at the code again, I now see that although my solution should be correct, it could have been simpler. Instead of

    for l in ${LANGS}; do
        if use l10n_${l}; then
            ...
        fi
    done

a simple loop over ${L10N} was sufficient (because in EAPI 5 and later, the package manager will reduce L10N to the values that are in IUSE).

Unless you object, I would update the ebuild of the unstable version accordingly.