Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 642638 - app-text/coolreader - ebuild should use wxwidgets eclass
Summary: app-text/coolreader - ebuild should use wxwidgets eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrey Grozin
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-29 13:25 UTC by Alexander Tsoy
Modified: 2017-12-31 02:37 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Tsoy 2017-12-29 13:25:41 UTC
Current ebuild is doing this strange thing:

    if use wxwidgets; then
        . "${ROOT}/var/lib/wxwidgets/current"
        if [[ "${WXCONFIG}" -eq "none" ]]; then
            die "The wxGTK profile should be selected!"
        fi
        local mycmakeargs=(-D GUI=WX)
    else

Instead it should set WX_GTK_VER, inherit wxwidgets eclass and call setup-wxwidgets().
Comment 1 Mart Raudsepp gentoo-dev 2017-12-29 13:44:55 UTC
No package should ever depend on what is eselected by user for their system. This completely breaks package management predictability and tracking and lots of other problems. Please see about doing what Alexander has proposed.
Comment 2 Larry the Git Cow gentoo-dev 2017-12-31 02:37:19 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f8d88a85978c7a6546971c853c40da02cdcad2f8

commit f8d88a85978c7a6546971c853c40da02cdcad2f8
Author:     Andrey Grozin <grozin@gentoo.org>
AuthorDate: 2017-12-31 02:35:26 +0000
Commit:     Andrey Grozin <grozin@gentoo.org>
CommitDate: 2017-12-31 02:36:50 +0000

    app-text/coolreader: use wxwidgets.eclass
    
    See https://github.com/gentoo/gentoo/pull/6692
    Closes: https://bugs.gentoo.org/642638
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-text/coolreader/coolreader-3.1.2.71-r3.ebuild | 58 +++++++++++++++++++++++
 app-text/coolreader/metadata.xml                  |  3 ++
 2 files changed, 61 insertions(+)