Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 642632 - dev-python/pypy{,3}-5.10.0: doins: Unknown install options: -p, ['-p']
Summary: dev-python/pypy{,3}-5.10.0: doins: Unknown install options: -p, ['-p']
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core - Ebuild Support (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks: 645194
  Show dependency tree
 
Reported: 2017-12-29 12:45 UTC by Patrick Lauer
Modified: 2018-06-03 16:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick Lauer gentoo-dev 2017-12-29 12:45:21 UTC
>>> Install pypy3-5.10.0 into /var/tmp/portage/dev-python/pypy3-5.10.0/image/ category dev-python
 * Installing PyPy ...
 * PT_PAX marking -m /var/tmp/portage/dev-python/pypy3-5.10.0/image/usr/lib64/pypy3/pypy3-c with scanelf
 * PT_PAX marking -m /var/tmp/portage/dev-python/pypy3-5.10.0/image/usr/lib64/pypy3/libpypy3-c.so with scanelf
 * XATTR_PAX marking -me /var/tmp/portage/dev-python/pypy3-5.10.0/image/usr/lib64/pypy3/pypy3-c with setfattr
 * XATTR_PAX marking -me /var/tmp/portage/dev-python/pypy3-5.10.0/image/usr/lib64/pypy3/libpypy3-c.so with setfattr
!!! doins: Unknown install options: -p, ['-p']

!!! doins: Continue with falling back to `install` command execution, which can be slower.


Portage 2.3.19 (python 2.7.14-final-0, default/linux/amd64/13.0, gcc-7.2.0, glibc-2.26-r3, 4.13.4-gentoo x86_64)
=================================================================
System uname: Linux-4.13.4-gentoo-x86_64-AMD_FX-tm-8350_Eight-Core_Processor-with-gentoo-2.4.1
KiB Mem:    16402744 total,   5553536 free
KiB Swap:          0 total,         0 free
sh bash 4.4_p12
ld GNU ld (Gentoo 2.29.1 p3) 2.29.1
app-shells/bash:          4.4_p12::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.26.1-r1::gentoo
dev-lang/python:          2.7.14-r1::gentoo, 3.4.6-r1::gentoo, 3.5.4-r1::gentoo, 3.6.3-r1::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.12::gentoo
sys-devel/autoconf:       2.69-r4::gentoo
sys-devel/automake:       1.15.1-r1::gentoo
sys-devel/binutils:       2.29.1-r1::gentoo
sys-devel/gcc:            7.2.0::gentoo
sys-devel/gcc-config:     1.9.1::gentoo
sys-devel/libtool:        2.4.6-r4::gentoo
sys-devel/make:           4.2.1-r1::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.26-r3::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts:

adjust
    location: /overlay/gentoo-overlay
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs buildpkg config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news parallel-fetch preserve-libs protect-owned sandbox sfperms strict test unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl amd64 berkdb bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 modules multilib ncurses nls nptl openmp pam pcre readline seccomp session sqlite ssl tcpd unicode xattr zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_5" PYTHON_TARGETS="python2_7 python3_4 python3_5 python3_6 pypy pypy3" RUBY_TARGETS="ruby24" USERLAND="GNU" VIDEO_CARDS="dummy fbdev glint intel nouveau nv r128 radeon v4l vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 2 Larry the Git Cow gentoo-dev 2018-01-08 05:55:10 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=d459f05ff71f8ccb8deea2d43c2992a8ae0b0d52

commit d459f05ff71f8ccb8deea2d43c2992a8ae0b0d52
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2017-12-29 20:15:37 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-01-08 05:47:48 +0000

    bin/doins.py: implement install -p option (bug 642632)
    
    Bug: https://bugs.gentoo.org/642632
    Reviewed-by: Alec Warner <antarus@gentoo.org>
    Reviewed-by: Mike Gilbert <floppym@gentoo.org>

 bin/doins.py                        | 34 +++++++++++++++++++++++++++++-----
 pym/portage/tests/bin/test_doins.py |  6 ++++--
 2 files changed, 33 insertions(+), 7 deletions(-)}
Comment 3 Zac Medico gentoo-dev 2018-01-15 03:46:06 UTC
With python2.7, it's not possible to preserve nanoseconds with complete precision, since precision is lost in conversion to/from float. It's not a problem in python3.3 and later since nanosecond precision is fully supported.

So, I'm thinking that maybe we should just use 1 second precision under python2.7.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-01-15 04:09:55 UTC
Provided this wouldn't cause unequal values due to rounding, I suppose that would work. Otherwise, we should probably use C extension for it.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-01-15 04:11:42 UTC
(or just figure out that reinventing basic shell commands in Python is a stupid idea)
Comment 6 Zac Medico gentoo-dev 2018-01-15 05:10:15 UTC
I think it's acceptable to just fallback to the install command in order to avoid timestamp precision loss for python2, so I've sent this patch for review:

https://archives.gentoo.org/gentoo-portage-dev/message/fc27b9058658da7305b40a6b25860ece
https://github.com/gentoo/portage/pull/243
Comment 7 Larry the Git Cow gentoo-dev 2018-01-17 19:39:28 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=e81497dec819dbfc8e85e533db30d751fadaad81

commit e81497dec819dbfc8e85e533db30d751fadaad81
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-01-15 04:36:39 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-01-17 19:38:44 +0000

    bin/doins.py: avoid timestamp precision loss with python2 (bug 642632)
    
    Since conversion to/from float results in timestamp precision loss
    with less than Python 3.3, do not use the python implementation
    in this case.
    
    Bug: https://bugs.gentoo.org/642632
    Fixes: d459f05ff71f ("bin/doins.py: implement install -p option (bug 642632)")

 bin/doins.py | 4 ++++
 1 file changed, 4 insertions(+)}