Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 642294 - media-gfx/gpicview-0.2.5: GTK3 & Wayland support
Summary: media-gfx/gpicview-0.2.5: GTK3 & Wayland support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Piotr Karbowski (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD, PATCH
: 769437 (view as bug list)
Depends on:
Blocks: gtk2-removal
  Show dependency tree
 
Reported: 2017-12-26 11:28 UTC by Bruno
Modified: 2021-08-24 19:28 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch: #undef direct X11 calls if GTK3 with wayland (gpicview-0.2.5-gtk3_no_x.diff,773 bytes, patch)
2017-12-26 11:28 UTC, Bruno
Details | Diff
Ebuild: Add gtk3 use flag and apply patch (gpicview-0.2.5.ebuild,767 bytes, text/plain)
2017-12-26 11:29 UTC, Bruno
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bruno 2017-12-26 11:28:42 UTC
Created attachment 511632 [details, diff]
Patch: #undef direct X11 calls if GTK3 with wayland

Since 0.2.4 gpicview has gained support for building against GTK3 instead of GTK2.

Just building 0.2.5 against GTK3 and running natively under Wayland causes segfault in get_working_area().

Attached patch disabled the code poking directly at X when build against GTK3 with wayland support.
Comment 1 Bruno 2017-12-26 11:29:29 UTC
Created attachment 511634 [details]
Ebuild: Add gtk3 use flag and apply patch
Comment 2 Ionen Wolkens gentoo-dev 2021-02-08 09:33:32 UTC
*** Bug 769437 has been marked as a duplicate of this bug. ***
Comment 4 Larry the Git Cow gentoo-dev 2021-03-14 13:50:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f36df699d793c794ad7d6f51ef600cc94dda97f5

commit f36df699d793c794ad7d6f51ef600cc94dda97f5
Author:     Piotr Karbowski <slashbeast@gentoo.org>
AuthorDate: 2021-03-14 13:49:43 +0000
Commit:     Piotr Karbowski <slashbeast@gentoo.org>
CommitDate: 2021-03-14 13:50:34 +0000

    media-gfx/gpicview: 0.2.5-r2: switch to GTK3; eapi bump.
    
    Closes: https://bugs.gentoo.org/642294
    Signed-off-by: Piotr Karbowski <slashbeast@gentoo.org>

 .../files/Fix-displaying-images-with-GTK3.patch    | 172 +++++++++++++++++++++
 media-gfx/gpicview/gpicview-0.2.5-r2.ebuild        |  27 ++++
 2 files changed, 199 insertions(+)
Comment 5 Don O 2021-03-28 12:31:46 UTC
Still needs original patch for gpicview to run under wayland. 
It works fine under X, but will segfault every time under wayland.
Comment 6 Duncan 2021-08-24 19:28:46 UTC
(In reply to Don O from comment #5)
> Still needs original patch for gpicview to run under wayland.

Confirming here.

I think Bruno may be long gone, however (bug opened nearly four years ago...), and with the bug closed this might not be noticed.  So please clone the bug (assuming you can't just reopen it either, or you would have, cloning link at bottom of page) and attach the patch to the new bug as well.

(FWIW I'm just testing a new-to-me package ATM, and don't know if I'll keep it installed yet, but definitely needed the patch to avoid segfaults on wayland and do that testing!)