Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 641978 - dev-db/postgis-2.4.2 fails to build(?) with dev-libs/json-c-0.13
Summary: dev-db/postgis-2.4.2 fails to build(?) with dev-libs/json-c-0.13
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: PgSQL Bugs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-21 22:04 UTC by Wojciech Myrda
Modified: 2017-12-23 13:01 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
postgis-2.4.2-jsonc_0.13.patch (postgis-2.4.2-jsonc_0.13.patch,786 bytes, patch)
2017-12-21 22:04 UTC, Wojciech Myrda
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wojciech Myrda 2017-12-21 22:04:07 UTC
Created attachment 511422 [details, diff]
postgis-2.4.2-jsonc_0.13.patch

Patch is taken from https://github.com/postgis/postgis/commit/ccb7b1c48b26256a81a264baeb4ab9d06cf7221e and makes it possible to build against new json-c 0.13.
Comment 1 Andreas Sturmlechner gentoo-dev 2017-12-22 01:14:51 UTC
As always, please include a build.log.
Comment 2 Wojciech Myrda 2017-12-22 09:18:30 UTC
(In reply to Andreas Sturmlechner from comment #1)
> As always, please include a build.log.

I am not sure which one You need as I never provided any logs, just patches on occasions with the brief description where the problem is. Here is excerpt from the build log without the patch. Obviously it fails than as json-c/json_object_private.h is not present in the new json-c.

libtool: compile:  x86_64-pc-linux-gnu-gcc -I/usr/include -I/usr/include/libxml2 -march=native -O2 -pipe -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize -fPIC -DPIC -Wall -Wmissing-prototypes -I/us
r/include -c lwtin.c -o lwtin.o >/dev/null 2>&1
/bin/sh ../libtool --mode=compile x86_64-pc-linux-gnu-gcc -I/usr/include   -I/usr/include/libxml2     -march=native -O2 -pipe -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize  -fPIC -DPIC  -Wall -Wm
issing-prototypes -I/usr/include   -c -o lwout_wkb.lo lwout_wkb.c
libtool: compile:  x86_64-pc-linux-gnu-gcc -I/usr/include -I/usr/include/libxml2 -march=native -O2 -pipe -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize -fPIC -DPIC -Wall -Wmissing-prototypes -I/us
r/include -c lwout_wkb.c  -fPIC -DPIC -o .libs/lwout_wkb.o
libtool: compile:  x86_64-pc-linux-gnu-gcc -I/usr/include -I/usr/include/libxml2 -march=native -O2 -pipe -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize -fPIC -DPIC -Wall -Wmissing-prototypes -I/us
r/include -c lwout_wkb.c -o lwout_wkb.o >/dev/null 2>&1
/bin/sh ../libtool --mode=compile x86_64-pc-linux-gnu-gcc -I/usr/include   -I/usr/include/libxml2     -march=native -O2 -pipe -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize  -fPIC -DPIC  -Wall -Wm
issing-prototypes -I/usr/include   -c -o lwin_geojson.lo lwin_geojson.c
libtool: compile:  x86_64-pc-linux-gnu-gcc -I/usr/include -I/usr/include/libxml2 -march=native -O2 -pipe -fgcse-sm -fgcse-las -fgcse-after-reload -ftree-vectorize -fPIC -DPIC -Wall -Wmissing-prototypes -I/us
r/include -c lwin_geojson.c  -fPIC -DPIC -o .libs/lwin_geojson.o
lwin_geojson.c:36:10: fatal error: json-c/json_object_private.h: No such file or directory
 #include <json-c/json_object_private.h>
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[1]: *** [Makefile:211: lwin_geojson.lo] Błąd 1
make[1]: Opuszczenie katalogu '/tmp/portage/dev-db/postgis-2.4.2/work/postgis-2.4.2-9.6/liblwgeom'
make: *** [GNUmakefile:16: all] Błąd 1
 .[31;01m*.[0m ERROR: dev-db/postgis-2.4.2::gentoo-osm failed (compile phase):
 .[31;01m*.[0m   emake failed
 .[31;01m*.[0m
 .[31;01m*.[0m If you need support, post the output of `emerge --info '=dev-db/postgis-2.4.2::gentoo-osm'`,
 .[31;01m*.[0m the complete build log and the output of `emerge -pqv '=dev-db/postgis-2.4.2::gentoo-osm'`.
 .[31;01m*.[0m The complete build log is located at '/tmp/logs/dev-db:postgis-2.4.2:20171221-214701.log'.
 .[31;01m*.[0m For convenience, a symlink to the build log is located at '/tmp/portage/dev-db/postgis-2.4.2/temp/build.log'.
 .[31;01m*.[0m The ebuild environment file is located at '/tmp/portage/dev-db/postgis-2.4.2/temp/environment'.
 .[31;01m*.[0m Working directory: '/tmp/portage/dev-db/postgis-2.4.2/work/postgis-2.4.2-9.6'
 .[31;01m*.[0m S: '/tmp/portage/dev-db/postgis-2.4.2/work/postgis-2.4.2'
.[32;01m * .[39;49;00mPackage:    dev-db/postgis-2.4.2
.[32;01m * .[39;49;00mRepository: gentoo-osm
.[32;01m * .[39;49;00mMaintainer: pgsql-bugs@gentoo.org sci-geosciences@gentoo.org
.[32;01m * .[39;49;00mUSE:        abi_x86_64 amd64 elibc_glibc kernel_linux postgres_targets_postgres9_6 topology userland_GNU
.[32;01m * .[39;49;00mFEATURES:   preserve-libs sandbox userpriv usersandbox

PS Similar patch has just made it to the portage for sci-libs/gdal.
Comment 3 Ștefan Talpalaru 2017-12-22 22:06:04 UTC
A patched postgis-2.4.2-r1 is available in my overlay: https://github.com/stefantalpalaru/gentoo-overlay
Comment 4 Larry the Git Cow gentoo-dev 2017-12-23 13:01:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2537c6ed079eca7a23f02321c0ef7670fa5a1aa0

commit 2537c6ed079eca7a23f02321c0ef7670fa5a1aa0
Author:     Aaron W. Swenson <titanofold@gentoo.org>
AuthorDate: 2017-12-23 13:00:52 +0000
Commit:     Aaron W. Swenson <titanofold@gentoo.org>
CommitDate: 2017-12-23 13:00:52 +0000

    dev-db/postgis: Add json-c-0.13 patch
    
    Fix compilation failure when building against json-c-0.13.
    
    Thanks to Wojciech Myrda for submitting the patch to us, and Ștefan
    Talpalaru for confirming.
    
    Closes: https://bugs.gentoo.org/641978
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 .../postgis/files/postgis-2.4.2-jsonc_0.13.patch   | 23 ++++++++++++++++++++++
 dev-db/postgis/postgis-2.4.2.ebuild                |  3 ++-
 2 files changed, 25 insertions(+), 1 deletion(-)