Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 641684 - dev-libs/sway-0.15.0 fails to build when >json-c-0.12.1 is installed
Summary: dev-libs/sway-0.15.0 fails to build when >json-c-0.12.1 is installed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mykyta Holubakha
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-19 09:26 UTC by Nils Holland
Modified: 2017-12-27 15:57 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nils Holland 2017-12-19 09:26:56 UTC
The ebuild for sway-0.15.0 states:

RDEPEND="...
        >=dev-libs/json-c-0.12.1
        ..."

However, in the package's archive, the CMakeLists.txt says:

find_package(JsonC 0.12.1 REQUIRED)

As a consequence, now that json-c-0.13 has landed, the sway-0.15 configuration process fails complaining about being unable to find json-c-0.12.1.

I've tested whether sway-0.15 would actually work with json-c-0.13, despite of what its CMakeLists.txt says, by just modifying it to say

find_package(JsonC 0.13 REQUIRED)

and I can confirm that it configured, built and installed fine with that change. 

Of course, this is probably far from the proper thing to do (I'm not really that much into CMake), but I guess in order to prevent merge failures, it would be wise to either change the RDEPEND of the ebuild so that it asks for =dev-libs/json-c-0.12.1 explicitly (like the CMakeLists.txt does) or - even better - patch the sway build process so that it works with the current version of json-c that is in the tree, too.
Comment 1 Dennis Schridde 2017-12-21 19:48:58 UTC
A fix exists and will appear in the next release: https://github.com/swaywm/sway/pull/1517

> This has been merged into the 0.15 branch and will make the next bugfix release.
Comment 2 Larry the Git Cow gentoo-dev 2017-12-27 15:57:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=402056b57722e365689a733479e00e3d5ebd432a

commit 402056b57722e365689a733479e00e3d5ebd432a
Author:     Mykyta Holubakha <hilobakho@gmail.com>
AuthorDate: 2017-12-26 23:48:38 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2017-12-27 15:57:11 +0000

    dev-libs/sway: json-c-0.13.0 fixes
    
    Closes: https://bugs.gentoo.org/641684
    Closes: https://github.com/gentoo/gentoo/pull/6646

 dev-libs/sway/files/sway-0.15.0-json-c-fixes.patch | 370 +++++++++++++++++++++
 dev-libs/sway/sway-0.15.0.ebuild                   |   2 +
 dev-libs/sway/sway-9999.ebuild                     |   2 +
 3 files changed, 374 insertions(+)