Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 641464 - dev-python/polib-1.0.7: test_save_as_mofile fails
Summary: dev-python/polib-1.0.7: test_save_as_mofile fails
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Alexandre Rostovtsev (RETIRED)
URL: https://bitbucket.org/izi/polib/pull-...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 641308
  Show dependency tree
 
Reported: 2017-12-17 12:30 UTC by Rolf Eike Beer
Modified: 2018-04-15 14:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,174.88 KB, text/plain)
2017-12-17 12:31 UTC, Rolf Eike Beer
Details
polib-1.0.7-BE-test.patch (polib-1.0.7-BE-test.patch,422 bytes, patch)
2017-12-19 22:09 UTC, Sergei Trofimovich (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer archtester 2017-12-17 12:30:41 UTC
Portage 2.3.8 (python 3.5.4-final-0, default/linux/sparc/13.0, gcc-6.4.0, glibc-2.25-r9, 4.14.2 sparc64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.14.2-sparc64-sun4v-with-gentoo-2.3
KiB Mem:    33133616 total,   6518392 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Sun, 17 Dec 2017 01:15:01 +0000
Head commit of repository gentoo: 3750c54224596dc0e4c70a9e1e5c4a0889c55d1e
sh bash 4.3_p48-r1
ld GNU ld (Gentoo 2.28.1 p1.0) 2.28.1
app-shells/bash:          4.3_p48-r1::gentoo
dev-lang/perl:            5.24.3::gentoo
dev-lang/python:          2.7.14::gentoo, 3.4.5::gentoo, 3.5.4-r1::gentoo
dev-util/cmake:           3.8.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.3::gentoo
sys-apps/openrc:          0.34.11::gentoo
sys-apps/sandbox:         2.10-r4::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.15.1-r1::gentoo
sys-devel/binutils:       2.28.1::gentoo
sys-devel/gcc:            5.4.0-r3::gentoo, 6.4.0::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.4::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r9::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000

ACCEPT_KEYWORDS="sparc"
ACCEPT_LICENSE="* -@EULA"
CBUILD="sparc-unknown-linux-gnu"
CFLAGS="-O2 -mcpu=niagara2 -pipe"
CHOST="sparc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -mcpu=niagara2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS=""
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS=""
GENTOO_MIRRORS="ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j20"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl berkdb big-endian bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 modules ncurses nls nptl openmp pam pcre readline session sparc ssl tcpd unicode xattr zlib" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6 php7-0" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_5" PYTHON_TARGETS="python2_7 python3_5" RUBY_TARGETS="ruby22" USERLAND="GNU" VIDEO_CARDS="fbdev glint mga r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS


Reproducible: Always
Comment 1 Rolf Eike Beer archtester 2017-12-17 12:31:06 UTC
Created attachment 510470 [details]
build.log
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2017-12-19 11:04:36 UTC
Similar for ppc and ppc64. Suspect endianness.
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2017-12-19 11:27:52 UTC
MO files depend on endianness of machine it's ran on:
    https://www.gnu.org/software/gettext/manual/html_node/MO-Files.html

Test compares files written in different endianness:

AssertionError: '\x95\x04\x12\xde\x00\x00\x00\x00\x00\x00\x02\xdd\x00\x00\x00\x1c\x00\x00\x17\x04\x00\x00\x00\x00\x00\x00-\xec
             != '\xde\x12\x04\x95\x00\x00\x00\x00\xdd\x02\x00\x00\x1c\x00\x00\x00\x04\x17\x00\x00\x00\x00\x00\x00\xec-

AFAIU the serializer uses native endianness (should be ok):
    https://github.com/Khan/polib/blob/master/polib.py#L560
And golden result it checks against is on-host msgfmt:
    https://github.com/Khan/polib/blob/master/tests/tests.py#L481

Looks like msgfmt generates file in little-endian format.

Random file on x86_64:

$ hexdump -C -n 32 $(find /usr/share/ -name '*.mo' | head -n 1)
00000000  de 12 04 95 00 00 00 00  77 0e 00 00 1c 00 00 00  |........w.......|
00000010  d4 73 00 00 49 13 00 00  8c e7 00 00 00 00 00 00  |.s..I...........|
00000020

Random file on powerpc64:

$ hexdump -C -n 32 $(find /usr/share/ -name '*.mo' | head -n 1)
00000000  de 12 04 95 00 00 00 00  63 00 00 00 1c 00 00 00  |........c.......|
00000010  34 03 00 00 89 00 00 00  4c 06 00 00 00 00 00 00  |4.......L.......|
00000020

Both use the same endianness. It's interesting because 'man msgfmt'
hints it could use host's endianness but look slike runes are not that simple:

"""
       --endianness=BYTEORDER
              write out 32-bit numbers in the given byte order (big or little, default depends on platform)
"""
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2017-12-19 11:37:19 UTC
Same for hppa (big-endian):

$ hexdump -C -n 32 $(find /usr/share/ -name '*.mo' | head -n 1)
00000000  de 12 04 95 00 00 00 00  d3 02 00 00 1c 00 00 00  |................|
00000010  b4 16 00 00 c7 03 00 00  4c 2d 00 00 00 00 00 00  |........L-......|
Comment 5 Sergei Trofimovich (RETIRED) gentoo-dev 2017-12-19 11:46:46 UTC
Looking at:
    https://github.com/autotools-mirror/gettext/blob/master/gettext-tools/src/msgfmt.c#L255 (ENDIANNESS=1 - big-endian, do byteswap)
    https://github.com/autotools-mirror/gettext/blob/master/gettext-tools/src/write-mo.c#L484 (do byteswap)

manpage is incorrect. msgfmt always defaults to little-endian.
Comment 6 Sergei Trofimovich (RETIRED) gentoo-dev 2017-12-19 22:09:37 UTC
Created attachment 511038 [details, diff]
polib-1.0.7-BE-test.patch

The patch forces 'msgfmt' to match endianness of polib library. Makes tests mass.
Comment 7 Sergei Trofimovich (RETIRED) gentoo-dev 2017-12-19 22:52:26 UTC
Proposed the change upstream as:
    https://bitbucket.org/izi/polib/pull-requests/24/tests-force-msgfmt-into-machines-byte/diff
Comment 8 Rolf Eike Beer archtester 2017-12-20 17:56:34 UTC
So this is a test gone wrong and if everything else passes this should be stabilized?
Comment 9 Sergei Trofimovich (RETIRED) gentoo-dev 2017-12-24 11:41:22 UTC
(In reply to Rolf Eike Beer from comment #8)
> So this is a test gone wrong and if everything else passes this should be
> stabilized?

I think so. It's up to (upstream and gentoo) maintaner to decide how polib should heave on BE arches but I would say polib generates perfectly fine .mo files.
Comment 10 Larry the Git Cow gentoo-dev 2018-04-15 14:12:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0fdf2add0c89b09660568b2a2d1871f1a416c5bd

commit 0fdf2add0c89b09660568b2a2d1871f1a416c5bd
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-04-15 14:11:48 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-04-15 14:12:04 +0000

    dev-python/polib: fix test to assume LE, bug #641464
    
    Also proposed this change upstream as:
    https://bitbucket.org/izi/polib/pull-requests/24/tests-force-msgfmt-into-machines-byte/diff
    
    Reported-by: Rolf Eike Beer
    Closes: https://bugs.gentoo.org/641464
    Package-Manager: Portage-2.3.28, Repoman-2.3.9

 dev-python/polib/files/polib-1.0.7-BE-test.patch | 11 +++++++++++
 dev-python/polib/polib-1.0.7.ebuild              |  4 ++++
 dev-python/polib/polib-1.1.0.ebuild              |  4 ++++
 3 files changed, 19 insertions(+)