Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 641046 - media-libs/raspberrypi-userland-9999 - raspberrypi-userland-9999-gentoo.patch fails
Summary: media-libs/raspberrypi-userland-9999 - raspberrypi-userland-9999-gentoo.patch...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM Linux
: Normal normal (vote)
Assignee: Andriy Utkin (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
: 671490 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-12-14 20:00 UTC by Walter Hüttenmeyer
Modified: 2019-03-25 01:05 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build log of failed prepare (media-libs:raspberrypi-userland-9999:20180311-125655.log,2.60 KB, text/x-log)
2018-03-11 12:58 UTC, Walter Hüttenmeyer
Details
patch.out of failed patch (raspberrypi-userland-9999-gentoo.patch.out,4.07 KB, text/plain)
2018-03-11 13:03 UTC, Walter Hüttenmeyer
Details
CMakeLists.txt unpatched (original) (CMakeLists.txt,785 bytes, text/plain)
2018-03-11 13:09 UTC, Walter Hüttenmeyer
Details
edited ebuild that works well (raspberrypi-userland-9999.ebuild,830 bytes, text/plain)
2018-03-11 13:12 UTC, Walter Hüttenmeyer
Details
build log of successful merge (media-libs:raspberrypi-userland-9999:20180311-131303.log.xz,30.96 KB, application/x-xz)
2018-03-11 13:21 UTC, Walter Hüttenmeyer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Walter Hüttenmeyer 2017-12-14 20:00:54 UTC
Emerging media-libs/raspberrypi-userland-9999 will try to apply the patch "raspberrypi-userland-9999-gentoo.patch".

This fails and the build is aborted.

Comparing CMakeLists.txt which is to be patched by the file named above, it already is correct (as if the patch was applied already).

May this have been taken into upstream, so we could skip the patch in the ebuild?

Just commented out the patch from the ebuild, the whole merge process ran fine and my system works well.
Comment 1 Walter Hüttenmeyer 2018-03-11 12:58:31 UTC
Created attachment 523480 [details]
build log of failed prepare
Comment 2 Walter Hüttenmeyer 2018-03-11 13:03:50 UTC
Created attachment 523482 [details]
patch.out of failed patch
Comment 3 Walter Hüttenmeyer 2018-03-11 13:09:39 UTC
Created attachment 523484 [details]
CMakeLists.txt unpatched (original)

The changes which the patch would make, are already there.
Thus the patch fails.
Comment 4 Walter Hüttenmeyer 2018-03-11 13:12:15 UTC
Created attachment 523486 [details]
edited ebuild that works well

commenting out the patch results in a working build.
function confirmed with KODI mediacenter.
Comment 5 Walter Hüttenmeyer 2018-03-11 13:21:06 UTC
Created attachment 523488 [details]
build log of successful merge

using the patched ebuild (attachment #523486 [details]) it works and installs well.
Comment 6 tt_1 2018-11-07 19:50:25 UTC
The patch was upstreamed, hence its possible to drop it. 

Who is the maintainer to ask for pushing a fix to the tree?
Comment 7 tt_1 2018-11-07 19:57:07 UTC
Ok, so I poked a few people, hopefully it'll raise a bit of attention.
Comment 8 Jim Carter 2018-11-18 05:44:25 UTC
I also encountered this bug.  (But I doubt that I have the "canconfirm"
capability.)  The file to be patched did not exist -- given the reported
working directory it needed "work/" prepended to its pathname, and 
as reported by Walter Huttenmeyer #3, the 8 lines to be removed are already
gone.  

But unlike Walter's experience, I got an assembly error apparently due
to having the wrong architecture.  I'm on a Raspberry Pi 3B (aarch64/arm64)
whereas the assembler complains Error: unknown architecture `armv6'.  
I'll try his hacked ebuild file, and in the likely case that it doesn't
fix the architecture issue, I'll file a separate bug report.  

I didn't get far enough to be able to report if bugs 601126 or 620774
are gone.
Comment 9 Walter Hüttenmeyer 2018-11-23 21:13:15 UTC
(In reply to tt_1 from comment #7)
> Ok, so I poked a few people, hopefully it'll raise a bit of attention.

I guess you poked Chí-Thanh Christopher Nguyễn and Tupone Alfredo, who are listed as maintainers amongside others?
Who would have the authority to merge that changes?
Comment 10 Larry the Git Cow gentoo-dev 2019-03-24 23:55:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=69db8036643a3b20b5b98e89e2518a283258c7de

commit 69db8036643a3b20b5b98e89e2518a283258c7de
Author:     stefson <herrtimson@yahoo.de>
AuthorDate: 2018-11-07 19:52:38 +0000
Commit:     Andrey Utkin <andrey_utkin@gentoo.org>
CommitDate: 2019-03-24 23:52:13 +0000

    media-libs/raspberrypi-userland: 9999: remove upstreamed patch
    
    Closes: https://bugs.gentoo.org/641046
    Link: https://github.com/raspberrypi/userland/commit/2fe51001dbd421ac35a55af443ac080b50128266
    Signed-off-by: Steffen Kuhn <nielson2@yandex.com>
    Signed-off-by: Andrey Utkin <andrey_utkin@gentoo.org>

 .../files/raspberrypi-userland-9999-gentoo.patch          | 15 ---------------
 .../raspberrypi-userland/raspberrypi-userland-9999.ebuild |  2 --
 2 files changed, 17 deletions(-)
Comment 11 Andriy Utkin (RETIRED) gentoo-dev 2019-03-25 01:05:57 UTC
*** Bug 671490 has been marked as a duplicate of this bug. ***