Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 640360 - sys-libs/libblockdev - change IUSE=crypt to IUSE=cryptsetup to match sys-fs/udisks
Summary: sys-libs/libblockdev - change IUSE=crypt to IUSE=cryptsetup to match sys-fs/u...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-09 11:33 UTC by kavol
Modified: 2018-01-21 06:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
one picture for thousand words (udisks.png,27.63 KB, image/png)
2017-12-09 11:33 UTC, kavol
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kavol 2017-12-09 11:33:48 UTC
Created attachment 509012 [details]
one picture for thousand words

trying to update my system, I have found that udisks pulls things that are explicitly disabled via use flags

probably, it all boils down to libblockdev using 'crypt' instead of 'cryptsetup' (and defaulting to having it enabled), however I'd rather took a look at the start of the dependency chain -

why udisks need to pull in so much cruft? (if udisks itself can't be avoided ...)

- note that the new udisks dependencies is not just libblockdev but there is also bug 631822 for gtk-doc, and also it pulls gnome-common for no apparent reason (other than that Freedesktop guys think everyone has to use GNOME like it or not?)
Comment 1 Gino McCarty 2017-12-11 08:31:03 UTC
https://github.com/storaged-project/udisks/issues/288

Looks like you are right, upstream has done some terrible hardcoding into the new udisks of several things

 * Gnome-common + gtk-doc tools
 * Crypto libblockdev libraries must exist

Unfortunately I'm not sure what gentoo can do about this.. I also just saw this in my emerge and was very disappointed by all the mess. Maybe attempt a PR upstream to make these things optional?


I do 2nd that it would make sense for libblockdev crypt useflag to be changed to cryptsetup and the udisks ebuild to perhaps drop the flag entirely.

Also because cryptsetup requires lvm2 you might as well do the same with the new lvm use flag, which exists in both libblockdev and udisks.
Comment 2 kavol 2017-12-11 10:16:06 UTC
(In reply to Gino M from comment #1)
> Unfortunately I'm not sure what gentoo can do about this.. I also just saw
> this in my emerge and was very disappointed by all the mess. Maybe attempt a
> PR upstream to make these things optional?

I see that the link above leads to something under blahblah*d* ... in that case, I'm afraid there's no point trying to resolve it with upstream

Gentoo can probably fork, like with eudev ... but I doubt there is manpower to do that

I guess I could spare a few $$$ a month to support such activities, but ... 1) would there be enough other people so it sums up to an amount which can actually pay some work, 2) would there be someone willing to organise and supervise this?
Comment 3 Larry the Git Cow gentoo-dev 2017-12-13 13:34:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d8cdc53a15ef960bbfac7b948a856d9b9717b5b8

commit d8cdc53a15ef960bbfac7b948a856d9b9717b5b8
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2017-12-13 13:31:02 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2017-12-13 13:31:02 +0000

    sys-libs/libblockdev: Revbump to rename "crypt" USE flag to "cryptsetup"
    
    Closes: https://bugs.gentoo.org/640360
    Package-Manager: Portage-2.3.18, Repoman-2.3.6

 .../{libblockdev-2.14.ebuild => libblockdev-2.14-r1.ebuild}         | 6 +++---
 .../{libblockdev-2.15.ebuild => libblockdev-2.15-r1.ebuild}         | 6 +++---
 sys-libs/libblockdev/metadata.xml                                   | 1 +
 3 files changed, 7 insertions(+), 6 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3c04438183872b87296e33cbc173d2678ead86a8

commit 3c04438183872b87296e33cbc173d2678ead86a8
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2017-12-13 13:33:39 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2017-12-13 13:33:39 +0000

    sys-fs/udisks: Adjusted renamed USE flag for libblockdev.
    
    Bug: https://bugs.gentoo.org/640360
    Package-Manager: Portage-2.3.18, Repoman-2.3.6

 sys-fs/udisks/udisks-2.7.4.ebuild | 2 +-
 sys-fs/udisks/udisks-2.7.5.ebuild | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)}
Comment 4 Tomasz Golinski 2017-12-13 19:46:26 UTC
This change doesn't really fix anything. As said before the flag in udisks doesn't do anything as sys-libs/libblockdev still pulls in cryptsetup and lvm2.
Comment 5 Larry the Git Cow gentoo-dev 2018-01-21 06:28:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1108d3385549d925613effd692c5a775ee5c8383

commit 1108d3385549d925613effd692c5a775ee5c8383
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2018-01-21 06:22:42 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2018-01-21 06:23:46 +0000

    sys-fs/udisks: revbump for libblockdev IUSE=crypt cryptsetup rename (bug 645202)
    
    Since sys-apps/portage-2.3.20 defaults to --dynamic-deps=n, this revbump
    is needed in order to correct the dependencies of installed instances of
    udisks-2.7.4 and udisks-2.7.5.
    
    Fixes: 3c0443818387 ("sys-fs/udisks: Adjusted renamed USE flag for libblockdev.")
    Bug: https://bugs.gentoo.org/640360
    Bug: https://bugs.gentoo.org/645202
    Package-Manager: Portage-2.3.20, Repoman-2.3.6
    RepoMan-Options: --force

 sys-fs/udisks/{udisks-2.7.4.ebuild => udisks-2.7.4-r1.ebuild} | 0
 sys-fs/udisks/{udisks-2.7.5.ebuild => udisks-2.7.5-r1.ebuild} | 0
 2 files changed, 0 insertions(+), 0 deletions(-)}