Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 639916 - mail-filter/spamassassin: 3.4.1-spamd.init-r2 has misspelling in depend
Summary: mail-filter/spamassassin: 3.4.1-spamd.init-r2 has misspelling in depend
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Philippe Chaintreuil
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-05 12:18 UTC by Aaron W. Swenson
Modified: 2017-12-05 18:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron W. Swenson gentoo-dev 2017-12-05 12:18:44 UTC
dev-db/postgresql initscripts "provide postgresql".

diff --git a/mail-filter/spamassassin/files/3.4.1-spamd.init-r2 b/mail-filter/spamassassin/files/3.4.1-spamd.init-r2
old mode 100644
new mode 100755
index c704782f3a4..0133d793625
--- a/mail-filter/spamassassin/files/3.4.1-spamd.init-r2
+++ b/mail-filter/spamassassin/files/3.4.1-spamd.init-r2
@@ -26,7 +26,7 @@ extra_started_commands="reload"

 depend() {
     before mta
-    use logger mysql postgres
+    use logger mysql postgresql
 }

 reload() {
Comment 1 Philippe Chaintreuil 2017-12-05 12:22:02 UTC
Is there a movement to rename the use flag?

I see a global use flag named "postgres", but only one package that uses "postgresql".

============================================================
$ euse -i postgres
global use flags (searching: postgres)
************************************************************
[-      ] postgres - Add support for the postgresql database

local use flags (searching: postgres)
************************************************************
   [.. pages of entries ..]
============================================================

============================================================
$ euse -i postgresql
global use flags (searching: postgresql)
************************************************************
no matching entries found

local use flags (searching: postgresql)
************************************************************
[-      ] postgresql
    dev-ada/gnatcoll: Adds support for postgresql
        [-  ] 2016 [gentoo]
        [-  ] 2017 [gentoo]
============================================================
Comment 2 Marcin Mirosław 2017-12-05 12:24:08 UTC
Agree, in init scripts is "provide postgresql"
Comment 3 Philippe Chaintreuil 2017-12-05 12:25:30 UTC
Ignore me, my brain was in the ebuild, not the init script.
Comment 4 Aaron W. Swenson gentoo-dev 2017-12-05 13:04:00 UTC
(In reply to Philippe Chaintreuil from comment #1)
> local use flags (searching: postgresql)
> ************************************************************
> [-      ] postgresql
>     dev-ada/gnatcoll: Adds support for postgresql
>         [-  ] 2016 [gentoo]
>         [-  ] 2017 [gentoo]
> ============================================================

Good work anyway. This package shouldn't be using postgresql as the use flag name.
Comment 5 Larry the Git Cow gentoo-dev 2017-12-05 18:48:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c01a2a0ed33b456d068b436b5d9e185f936455f9

commit c01a2a0ed33b456d068b436b5d9e185f936455f9
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2017-12-05 18:25:11 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2017-12-05 18:46:02 +0000

    mail-filter/spamassassin: fix "postgres" -> "postgresql" in init script.
    
    In commit 5248063, I accidentally changed the name of the PostgreSQL
    dependency in the OpenRC service script from "postgresql" (correct) to
    "postgres" (not so much). This commit changes it back to the correct
    name in a new revision. Thanks to Aaron W. Swenson for noticing the
    mistake.
    
    Closes: https://bugs.gentoo.org/639916
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 mail-filter/spamassassin/Manifest                  |   2 +-
 mail-filter/spamassassin/files/3.4.1-spamd.init-r3 |  38 ++++
 .../spamassassin/spamassassin-3.4.1-r20.ebuild     | 251 +++++++++++++++++++++
 3 files changed, 290 insertions(+), 1 deletion(-)