Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 639758 - dev-util/pycharm-professional-2017.3 version bump
Summary: dev-util/pycharm-professional-2017.3 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Michael Weber (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-12-04 12:54 UTC by Stefan Cristian Brindusa
Modified: 2017-12-22 10:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Cristian Brindusa 2017-12-04 12:54:50 UTC
Self-described from summary
Comment 1 Stefan Cristian Brindusa 2017-12-04 13:19:24 UTC
Push request on https://github.com/gentoo/gentoo/pull/6434
Comment 2 Michael Weber (RETIRED) gentoo-dev 2017-12-08 18:34:36 UTC
Thanks

Author: Michael Weber <xmw@gentoo.org>
Date:   Fri Dec 8 19:33:36 2017 +0100

    dev-util/pycharm-professional: Version bump (bug 639758).
    
    Package-Manager: Portage-2.3.16, Repoman-2.3.6
Comment 3 Stefan Cristian Brindusa 2017-12-09 00:24:41 UTC
The new ebuild, which I observed you copied it from the PR you closed ( closed earlier one here: https://github.com/gentoo/gentoo/pull/6434/files ) contains no icon cache regeneration even though we add icons, and no desktop cache regeneration after adding make .desktop entry phase.
Also, it contains unneeded eutils eclass import.

I don't think this bug should be closed & fixed.
Comment 4 Michael Weber (RETIRED) gentoo-dev 2017-12-09 01:10:21 UTC
(In reply to Stefan Cristian Brindusa from comment #3)
> The new ebuild, which I observed you copied it from the PR you closed (
> closed earlier one here: https://github.com/gentoo/gentoo/pull/6434/files )
> contains no icon cache regeneration even though we add icons, and no desktop
> cache regeneration after adding make .desktop entry phase.
> Also, it contains unneeded eutils eclass import.
> 
> I don't think this bug should be closed & fixed.

You mentioned "version bump", no additional information concerning the icon caches. I look into it. Tbh, i copied the old ebuild on my local checkout.
Comment 5 Stefan Cristian Brindusa 2017-12-09 01:13:06 UTC
Apologies, I put the wrong link to closed PR.

Let's enhance this ebuild
Comment 6 Larry the Git Cow gentoo-dev 2017-12-22 10:17:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f851d4b1c487fc0fcb9e3a670a16ad5c7c96f75d

commit f851d4b1c487fc0fcb9e3a670a16ad5c7c96f75d
Author:     Michael Weber <xmw@gentoo.org>
AuthorDate: 2017-12-22 10:16:24 +0000
Commit:     Michael Weber <xmw@gentoo.org>
CommitDate: 2017-12-22 10:17:28 +0000

    dev-util/pycharm-professional: Version bump.
    
    Closes: https://bugs.gentoo.org/639758
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 dev-util/pycharm-professional/Manifest             |  1 +
 .../pycharm-professional-2017.3.1.ebuild           | 59 ++++++++++++++++++++++
 2 files changed, 60 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=11bf1aece18c539ecddeb41d320b1b446fe630a9

commit 11bf1aece18c539ecddeb41d320b1b446fe630a9
Author:     Michael Weber <xmw@gentoo.org>
AuthorDate: 2017-12-22 10:14:29 +0000
Commit:     Michael Weber <xmw@gentoo.org>
CommitDate: 2017-12-22 10:17:26 +0000

    dev-util/pycharm-community: Version bump.
    
    Closes: https://bugs.gentoo.org/639758
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 dev-util/pycharm-community/Manifest                |  1 +
 .../pycharm-community-2017.3.1.ebuild              | 55 ++++++++++++++++++++++
 2 files changed, 56 insertions(+)