Created attachment 507280 [details] build.log x86_64-pc-linux-gnu-gcc -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -Wall -march=native -g3 -gdwarf-4 -O2 -pipe -gz -Wl,-O1 -Wl,--as-needed -fuse-ld=bfd -Wl,-O1 -Wl,--as-needed -fuse-ld=bfd -o daimonin ../../src/anim.o ../../src/book.o ../../src/buddy.o ../../src/chatfilter.o ../../src/client.o ../../src/commands.o ../../src/dialog.o ../../src/event.o ../../src/filewrap.o ../../src/font.o ../../src/group.o ../../src/ignore.o ../../src/interface.o ../../src/inventory.o ../../src/item.o ../../src/kerbholz.o ../../src/main.o ../../src/map.o ../../src/menu.o ../../src/misc.o ../../src/physfsrwops.o ../../src/player.o ../../src/protocol.o ../../src/socket.o ../../src/sound.o ../../src/sprite.o ../../src/textwin.o ../../src/tile_stretcher.o ../../src/wrapper.o ../../src/widget.o -lSDL_mixer -lSDL_image -lSDL -lpthread -lphysfs -lz ../../src/dialog.o: In function `show_optwin': /var/tmp/portage/games-rpg/daimonin-client-0.10.8/work/daimonin-code-8183-trunk/client/make/linux/../../src/dialog.c:1133: undefined reference to `optwin_draw_options' collect2: error: ld returned 1 exit status make: *** [Makefile:544: daimonin] Error 1 * ERROR: games-rpg/daimonin-client-0.10.8::gentoo failed (compile phase): * emake failed
Created attachment 507448 [details, diff] daimonin-client-0.10.8-inline.patch Patch that replaces inline with static in optwin_draw_options definition
Created attachment 507450 [details, diff] daimonin-client-0.10.8.ebuild.patch
Comment on attachment 507448 [details, diff] daimonin-client-0.10.8-inline.patch Why don't you make it a static inline function?
Because the main difference between static and static inline is that the compiler will warn if the function is unused in the first case but not in the later. And given it is located in a .c file there just static suits it better.
I tried applying that patch as user patch but it didn't work cause it seems not to be possible to patch parent directories, therefore also how eapply_user is used in the ebuild should be changed to be applied in the parent directory: pushd ../.. >/dev/null || die eapply_user popd >/dev/null || die
(Btw I also fixed this upstream, so will be fixed with next release.)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7075cd03fb20c63fda4008b1cd7d50147a024663 commit 7075cd03fb20c63fda4008b1cd7d50147a024663 Author: David Seifert <soap@gentoo.org> AuthorDate: 2020-11-21 20:38:17 +0000 Commit: David Seifert <soap@gentoo.org> CommitDate: 2020-11-21 20:38:17 +0000 games-rpg/daimonin-client: Port to EAPI 7 Closes: https://bugs.gentoo.org/639304 Closes: https://bugs.gentoo.org/708788 Package-Manager: Portage-3.0.9, Repoman-3.0.2 Signed-off-by: David Seifert <soap@gentoo.org> .../daimonin-client/daimonin-client-0.10.8.ebuild | 17 +-- .../files/daimonin-client-0.10.8-fno-common.patch | 128 +++++++++++++++++++++ 2 files changed, 138 insertions(+), 7 deletions(-)
