Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 639188 - dev-python/pythondialog-3.4.0: SyntaxError: invalid syntax with python-3 versions
Summary: dev-python/pythondialog-3.4.0: SyntaxError: invalid syntax with python-3 vers...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Patrice Clement (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-29 18:03 UTC by Toralf Förster
Modified: 2018-01-29 10:11 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.02 KB, text/plain)
2017-11-29 18:03 UTC, Toralf Förster
Details
dev-python:pythondialog-3.4.0:20171128-232122.log (dev-python:pythondialog-3.4.0:20171128-232122.log,4.18 KB, text/plain)
2017-11-29 18:03 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,70.67 KB, text/plain)
2017-11-29 18:03 UTC, Toralf Förster
Details
environment (environment,137.67 KB, text/plain)
2017-11-29 18:03 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,16.74 KB, application/x-bzip)
2017-11-29 18:03 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,30.94 KB, application/x-bzip)
2017-11-29 18:03 UTC, Toralf Förster
Details
pythondialog-3.4.0-3.5.patch (pythondialog-3.4.0.patch,5.78 KB, patch)
2018-01-16 15:53 UTC, Joerg Neikes
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2017-11-29 18:03:30 UTC
    except OSError, e:
                  ^
SyntaxError: invalid syntax
 * ERROR: dev-python/pythondialog-3.4.0::gentoo failed (compile phase):
 *   (no error message)
 * 

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 13.0-systemd_20171126-125140

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-7.2.0 *

Available Python interpreters, in order of preference:
  [1]   python3.4
  [2]   python3.5 (fallback)
  [3]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby22 (with Rubygems) *



emerge -qpv dev-python/pythondialog
[ebuild  N    ] dev-python/pythondialog-3.4.0  USE="-doc -examples" PYTHON_TARGETS="python2_7 python3_5 -pypy -python3_6"
Comment 1 Toralf Förster gentoo-dev 2017-11-29 18:03:34 UTC
Created attachment 507066 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2017-11-29 18:03:37 UTC
Created attachment 507068 [details]
dev-python:pythondialog-3.4.0:20171128-232122.log
Comment 3 Toralf Förster gentoo-dev 2017-11-29 18:03:40 UTC
Created attachment 507070 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2017-11-29 18:03:43 UTC
Created attachment 507072 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2017-11-29 18:03:45 UTC
Created attachment 507074 [details]
etc.portage.tbz2
Comment 6 Toralf Förster gentoo-dev 2017-11-29 18:03:48 UTC
Created attachment 507076 [details]
temp.tbz2
Comment 7 Hector Martin 2017-12-06 20:35:57 UTC
I don't think this has anything to do with scons. Looks to me like old Python 2 exception syntax that isn't being converted.
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-01-06 09:10:00 UTC
@monsieurp, you've committed this monstrosity. Please fix it. Also FWICS the slots on this thing are off and it misses necessary cross-slot blockers.
Comment 9 Joerg Neikes 2018-01-16 15:53:17 UTC
Created attachment 515036 [details, diff]
pythondialog-3.4.0-3.5.patch

emerge =dev-python/pythondialog-3.4.0 --nodeps
patch -p0 < /tmp/pythondialog-3.4.0.patch 
ebuild /usr/portage/dev-python/pythondialog/pythondialog-3.4.0.ebuild compile
ebuild /usr/portage/dev-python/pythondialog/pythondialog-3.4.0.ebuild install
ebuild /usr/portage/dev-python/pythondialog/pythondialog-3.4.0.ebuild qmerge

merged with:
http://pythondialog.sourceforge.net/doc/_modules/dialog.html
Comment 10 tonemgub 2018-01-26 02:42:09 UTC
Affects PyBitMessage. Tried the patch but it gives a hunk failure.
Comment 11 Joerg Neikes 2018-01-26 08:32:57 UTC
(In reply to tonemgub from comment #10)
> Affects PyBitMessage. Tried the patch but it gives a hunk failure.

Patch is needed for python 3.x directory.

Things i have done:

emerge =dev-python/pythondialog-3.4.0 --nodeps

wget https://bugs.gentoo.org/attachment.cgi?id=515036 -O /tmp/pythondialog-3.4.0-3.5.patch

cd /var/tmp/portage/dev-python/pythondialog-3.4.0/work/python2-pythondialog-3.4.0-python3_4

patch -p0 < /root/pythondialog-3.4.0-3.5.patch 

cd /var/tmp/portage/dev-python/pythondialog-3.4.0/work/python2-pythondialog-3.4.0-python3_5

patch -p0 < /root/pythondialog-3.4.0-3.5.patch 

ebuild /usr/portage/dev-python/pythondialog/pythondialog-3.4.0.ebuild compile

ebuild /usr/portage/dev-python/pythondialog/pythondialog-3.4.0.ebuild install
ebuild /usr/portage/dev-python/pythondialog/pythondialog-3.4.0.ebuild qmerge

Not tested with python 3.6 but 3.4 and 3.5 works for me.
Comment 12 SpanKY gentoo-dev 2018-01-29 05:37:46 UTC
i don't think trying to patch the source makes sense

the upstream project provides two versions:
  https://pypi.python.org/pypi/pythondialog
  https://pypi.python.org/pypi/python2-pythondialog

the former is for python-3 while the latter is for python-2 and is what the build is (currently) installing.

the 3.3.0 ebuilds had two variants for each, but the 3.4.0 doesn't.  probably should be changed to unify the ebuild to fetch the relevant source based on the version.
Comment 13 Patrice Clement (RETIRED) gentoo-dev 2018-01-29 10:03:30 UTC
Thanks a lot Mike for the explanation! I finally understand how to fix this bug.
Comment 14 Larry the Git Cow gentoo-dev 2018-01-29 10:11:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fc8a2a8c318e38e2112dcc2df03cb75d28a4f1a7

commit fc8a2a8c318e38e2112dcc2df03cb75d28a4f1a7
Author:     Patrice Clement <monsieurp@gentoo.org>
AuthorDate: 2018-01-29 10:05:23 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2018-01-29 10:11:21 +0000

    dev-python/pythondialog: version bump to 3.4.0.
    
    This commit:
    * alters python-3.4.0.ebuild's slot to 0 for Python 3.x and pypy3 interpreters.
    * adds python-3.4.0-r200.ebuild using slot "python-2" for Python 2.7 and pypy interpreters.
    
    An EAPI 6 bump is crammed in whilst we're at it.
    
    Closes: https://bugs.gentoo.org/639188
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 dev-python/pythondialog/Manifest                   |  1 +
 .../pythondialog/pythondialog-3.4.0-r200.ebuild    | 38 ++++++++++++++++++++++
 dev-python/pythondialog/pythondialog-3.4.0.ebuild  | 22 ++++---------
 3 files changed, 46 insertions(+), 15 deletions(-)