Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 638750 - sys-cluster/ceph-12.2.1: usex tcmalloc / jemalloc usage is incorrect
Summary: sys-cluster/ceph-12.2.1: usex tcmalloc / jemalloc usage is incorrect
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Patrick McLean
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-25 01:29 UTC by Zac Medico
Modified: 2019-04-15 23:29 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2017-11-25 01:29:22 UTC
I'd suggest something like this:

  -DALLOCATOR=$(usex tcmalloc 'tcmalloc' "$(usex jemalloc 'jemalloc' 'libc')")

The current code gives incorrect results:

  -DALLOCATOR=$(usex tcmalloc 'tcmalloc' '' "$(usex jemalloc 'jemalloc' '' 'libc' '')" '')
Comment 1 Zac Medico gentoo-dev 2017-11-25 22:44:16 UTC
This issue has existed since ceph-12.2.0, the first cmake based ebuild:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36e2a6eb3dcb8f4d62830c2eeccae3c5c680291d

The issue was not reported earlier because the default tcmalloc configuration works correctly.
Comment 2 Larry the Git Cow gentoo-dev 2018-07-31 23:54:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7833f7fabee43f2fa1a53ae1a7cc54544c957d3c

commit 7833f7fabee43f2fa1a53ae1a7cc54544c957d3c
Author:     Patrick McLean <chutzpah@gentoo.org>
AuthorDate: 2018-07-31 23:05:20 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2018-07-31 23:43:41 +0000

    sys-cluster/ceph: Version bump to 13.2.1
    
    Bug: https://bugs.gentoo.org/638750
    
    Package-Manager: Portage-2.3.44, Repoman-2.3.10

 sys-cluster/ceph/Manifest           |   2 +
 sys-cluster/ceph/ceph-13.2.1.ebuild | 348 ++++++++++++++++++++++++++++++++++++
 sys-cluster/ceph/metadata.xml       |   2 +-
 3 files changed, 351 insertions(+), 1 deletion(-)
Comment 3 Larry the Git Cow gentoo-dev 2019-04-15 23:29:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9c1469bcc815ad185bba2b5300887a3a142e8603

commit 9c1469bcc815ad185bba2b5300887a3a142e8603
Author:     Patrick McLean <patrick.mclean@sony.com>
AuthorDate: 2019-04-15 23:26:37 +0000
Commit:     Patrick McLean <chutzpah@gentoo.org>
CommitDate: 2019-04-15 23:26:37 +0000

    sys-cluster/ceph: Revbumps, 681068, 651460, 671482, 682664, 638750
    
    Cleanups for a lot of old bugs that had fallen through the cracks/
    
    Closes: https://bugs.gentoo.org/681068
    Closes: https://bugs.gentoo.org/651460
    Closes: https://bugs.gentoo.org/671482
    Closes: https://bugs.gentoo.org/682664
    Closes: https://bugs.gentoo.org/638750
    Copyright: Sony Interactive Entertainment Inc.
    Package-Manager: Portage-2.3.62, Repoman-2.3.12
    Signed-off-by: Patrick McLean <chutzpah@gentoo.org>

 ...{ceph-12.2.12.ebuild => ceph-12.2.12-r1.ebuild} | 13 +++++-----
 ...ceph-13.2.5-r2.ebuild => ceph-13.2.5-r3.ebuild} | 23 +++++++++--------
 ...ceph-14.2.0-r4.ebuild => ceph-14.2.0-r5.ebuild} | 13 +++++-----
 .../ceph/files/ceph-12.2.12-ncurses-tinfo.patch    | 20 +++++++++++++++
 .../ceph/files/ceph-14.2.1-ncurses-tinfo.patch     | 30 ++++++++++++++++++++++
 5 files changed, 77 insertions(+), 22 deletions(-)