Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 638022 - dev-util/mdds-1.2.3: Does not depend on dev-util/valgrind if USE flag 'valgrind' is enabled
Summary: dev-util/mdds-1.2.3: Does not depend on dev-util/valgrind if USE flag 'valgri...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-18 14:54 UTC by Theron Fortier
Modified: 2017-12-28 19:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Theron Fortier 2017-11-18 14:54:25 UTC
dev-util/mdds (all current ebuilds) have a USE flag valgrind which enables memory tests. However, if enabled and valgrind is not installed, then the merge fails in the configure phase with

    checking for valgrind... no
    configure: error: valgrind not found

Suggestion: Add "valgrind? ( dev-util/valgrind )" to DEPEND.

While we are at it: I find the USE flag name quite nondescript as it only tells me that valgrind might be somehow involved. The upstream configure option '--enable-memory_tests' tells me more. I would suggest renaming the flag to 'memory-tests'.
Comment 1 Andreas Sturmlechner gentoo-dev 2017-12-28 19:29:03 UTC
Thanks for your report. The USE flag name is in line with other packages providing a similar build option.
Comment 2 Larry the Git Cow gentoo-dev 2017-12-28 19:34:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6ad162adedb5fc39f8fc93366b968dc417aceaf9

commit 6ad162adedb5fc39f8fc93366b968dc417aceaf9
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2017-12-28 19:29:12 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2017-12-28 19:34:41 +0000

    dev-util/mdds: Add missing USE=valgrind DEPEND
    
    Closes: https://bugs.gentoo.org/638022
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 dev-util/mdds/mdds-1.2.3.ebuild | 4 +++-
 dev-util/mdds/mdds-1.3.1.ebuild | 4 +++-
 dev-util/mdds/mdds-9999.ebuild  | 1 +
 3 files changed, 7 insertions(+), 2 deletions(-)