Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 637958 - net-misc/radvd-2.17-r1 fails tests on sparc (test/send.c:317:F:build:test_add_ra_option_lowpanco:0:, test/send.c:342:F:build:test_add_ra_option_abro:0:)
Summary: net-misc/radvd-2.17-r1 fails tests on sparc (test/send.c:317:F:build:test_add...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Matthew Thode ( prometheanfire )
URL: https://github.com/reubenhwk/radvd/is...
Whiteboard:
Keywords: TESTFAILURE
Depends on:
Blocks: 637520
  Show dependency tree
 
Reported: 2017-11-17 19:29 UTC by Rolf Eike Beer
Modified: 2018-11-25 11:14 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Rolf Eike Beer archtester 2017-11-17 19:29:42 UTC
testsuite.log:

==================================
   radvd 2.17: ./test-suite.log
==================================

# TOTAL: 1
# PASS:  0
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: check_all
===============

Running suite(s): util
 send
92%: Checks: 26, Failures: 2, Errors: 0
test/util.c:23:P:safe_buffer:test_safe_buffer:0: Passed
test/util.c:33:P:safe_buffer:test_safe_buffer_resize:0: Passed
test/util.c:45:P:safe_buffer:test_safe_buffer_append:0: Passed
test/util.c:58:P:safe_buffer:test_safe_buffer_append2:0: Passed
test/util.c:71:P:safe_buffer:test_safe_buffer_pad:0: Passed
test/util.c:83:P:safe_buffer:test_safe_buffer_list:0: Passed
test/util.c:102:P:safe_buffer:test_safe_buffer_list_to_safe_buffer:0: Passed
test/util.c:118:P:str:test_addrtostr:0: Passed
test/util.c:131:P:str:test_addrtostr_overflow:0: Passed
test/util.c:139:P:str:test_strdupf:0: Passed
test/util.c:160:P:ion:test_readn:0: Passed
test/util.c:177:P:ion:test_writen:0: Passed
test/util.c:206:P:presence:test_check_dnssl_presence:0: Passed
test/util.c:231:P:presence:test_check_rdnss_presence:0: Passed
test/util.c:257:P:misc:test_rand_between:0: Passed
test/send.c:17:P:update:test_decrement_lifetime:0: Passed
test/send.c:53:P:build:test_add_ra_header:0: Passed
test/send.c:87:P:build:test_add_ra_options_prefix:0: Passed
test/send.c:119:P:build:test_add_ra_options_route:0: Passed
test/send.c:149:P:build:test_add_ra_options_rdnss:0: Passed
test/send.c:182:P:build:test_add_ra_options_rdnss2:0: Passed
test/send.c:221:P:build:test_add_ra_options_dnssl:0: Passed
test/send.c:245:P:build:test_add_ra_option_mtu:0: Passed
test/send.c:292:P:build:test_add_ra_option_sllao:0: Passed
test/send.c:317:F:build:test_add_ra_option_lowpanco:0: Assertion '0 == memcmp(expected, sb.buffer, sizeof(expected))' failed: 0 == 0, memcmp(expected, sb.buffer, sizeof(expected)) == 1
test/send.c:342:F:build:test_add_ra_option_abro:0: Assertion '0 == memcmp(expected, sb.buffer, sizeof(expected))' failed: 0 == 0, memcmp(expected, sb.buffer, sizeof(expected)) == 1
FAIL check_all (exit status: 1)

Portage 2.3.13 (python 2.7.14-final-0, default/linux/sparc/13.0, gcc-5.4.0, glibc-2.25-r9, 4.13.8 sparc64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-4.13.8-sparc64-sun4v-with-gentoo-2.3
KiB Mem:    33133648 total,  25185088 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Fri, 17 Nov 2017 11:15:01 +0000
Head commit of repository gentoo: 56f24d9297c16a46d3f5854ac57df4e371930ad0
sh bash 4.3_p48-r1
ld GNU ld (Gentoo 2.28.1 p1.0) 2.28.1
app-shells/bash:          4.3_p48-r1::gentoo
dev-lang/perl:            5.24.3::gentoo
dev-lang/python:          2.7.14::gentoo, 3.4.5::gentoo, 3.5.4::gentoo
dev-util/cmake:           3.8.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.3::gentoo
sys-apps/openrc:          0.34.7::gentoo
sys-apps/sandbox:         2.10-r4::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.10.3-r2::gentoo, 1.11.6-r2::gentoo, 1.12.6-r1::gentoo, 1.13.4-r1::gentoo, 1.14.1-r1::gentoo, 1.15.1-r1::gentoo
sys-devel/binutils:       2.28.1::gentoo
sys-devel/gcc:            5.4.0-r3::gentoo
sys-devel/gcc-config:     1.8-r1::gentoo
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.4::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r9::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 

ACCEPT_KEYWORDS="sparc"
ACCEPT_LICENSE="* -@EULA"
CBUILD="sparc-unknown-linux-gnu"
CFLAGS="-O2 -mcpu=niagara2 -pipe"
CHOST="sparc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /etc/omega.conf /usr/share/gnupg/qualified.txt /var/qmail/alias /var/qmail/control /var/spool/torque"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php5.6/ext-active/ /etc/php/apache2-php7.0/ext-active/ /etc/php/cgi-php5.6/ext-active/ /etc/php/cgi-php7.0/ext-active/ /etc/php/cli-php5.6/ext-active/ /etc/php/cli-php7.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -mcpu=niagara2 -pipe"
DISTDIR="/usr/portage/distfiles"
FCFLAGS=""
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync news parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS=""
GENTOO_MIRRORS="ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j20"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl berkdb big-endian bzip2 cli cracklib crypt cxx dri fortran gdbm iconv ipv6 modules ncurses nls nptl openmp pam pcre readline session sparc ssl tcpd unicode xattr zlib" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_4" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby21 ruby22" USERLAND="GNU" VIDEO_CARDS="fbdev glint mach64 mga r128 radeon sunbw2 suncg14 suncg3 suncg6 sunffb sunleo tdfx dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

=================================================================
                        Package Settings
=================================================================

net-misc/radvd-2.17-r1::gentoo was built with the following:
USE="(-selinux) -test"


Reproducible: Always
Comment 1 Sergei Trofimovich (RETIRED) gentoo-dev 2017-11-17 20:53:59 UTC
same failure on ppc.
Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev 2017-11-17 20:57:16 UTC
it's due to add_ra_option_lowpanco() missing hton*() calls to convert into proper endianness. Most of other helpers have it.

https://github.com/reubenhwk/radvd/blob/master/send.c#L613
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2017-11-17 22:29:42 UTC
Filed upstream bug report as: https://github.com/reubenhwk/radvd/issues/77
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2017-11-17 23:51:36 UTC
Proposed fix upstream as: https://github.com/reubenhwk/radvd/pull/78
Comment 5 Larry the Git Cow gentoo-dev 2018-11-25 11:14:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b771c256f85e302da9fb833d9f162971d752c91

commit 6b771c256f85e302da9fb833d9f162971d752c91
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-11-25 11:13:28 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-11-25 11:14:13 +0000

    net-misc/radvd: backport nd_opt_6co serialization, bug #637958
    
    Reported-by: Rolf Eike Beer
    Bug: https://github.com/reubenhwk/radvd/issues/77
    Closes: https://bugs.gentoo.org/637958
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 net-misc/radvd/files/radvd-2.17-nd_opt_6co.patch | 48 ++++++++++++++++
 net-misc/radvd/radvd-2.17-r2.ebuild              | 70 ++++++++++++++++++++++++
 2 files changed, 118 insertions(+)