Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 637848 - prefix.eclass: breaks app-doc/eclass-manpages for everyone
Summary: prefix.eclass: breaks app-doc/eclass-manpages for everyone
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: Normal critical (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-16 21:45 UTC by Michał Górny
Modified: 2021-02-27 11:28 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-11-16 21:45:51 UTC
prefix.eclass:
   warning:21: EPREFIX: unable to extract default variable content: if [[ ! ${EPREFIX+set} ]]; then
   error:52: hprefixify: no @DESCRIPTION found
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-11-18 07:24:18 UTC
In case it wasn't obvious from the word 'error', this one makes it impossible to generate new eclass manpages for some time. I'd really appreciate if Prefix team cared more about testing their unreviewed changes and fixing whenever they broke stuff for everyone.
Comment 2 Fabian Groffen gentoo-dev 2017-11-18 09:59:14 UTC
@heroxbd: could you please document hprefixify in the eclass using the appropriate tags? Thanks!
Comment 3 Fabian Groffen gentoo-dev 2017-11-18 10:08:10 UTC
@heroxbd: sorry, it seems you DID document it.

@mgorny: do you have some syntax error of some sort?  The function appears to be documented properly, so it seems to me there is another problem here.

@mgorny: may I also suggest to put a commit hook in place to generate the man-page-docu upon every commit to the eclasses, so the problem can be addressed in a timely manner?  Thanks!
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-11-18 14:09:07 UTC
The error is in the first message. Line wrapping is not supported in those tags.
Comment 5 Benda Xu gentoo-dev 2017-11-19 01:36:05 UTC
Hi Michał,

(In reply to Michał Górny from comment #1)
> In case it wasn't obvious from the word 'error', this one makes it
> impossible to generate new eclass manpages for some time. I'd really
> appreciate if Prefix team cared more about testing their unreviewed changes
> and fixing whenever they broke stuff for everyone.

Thanks for bringing this up. Do you mean testing against app-doc/eclass-manpages?

I don't find the relavanent syntax specification to comply with eclass-manpages.  If you do, feel free to go ahead to fix it or point a link to me.

Cheers,
Benda
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-11-19 08:48:21 UTC
It's in the *.awk file, where vapier left it.
Comment 7 Larry the Git Cow gentoo-dev 2017-12-06 13:42:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8c734c537488647738d110a0e7a35848aa1dde7e

commit 8c734c537488647738d110a0e7a35848aa1dde7e
Author:     Benda Xu <heroxbd@gentoo.org>
AuthorDate: 2017-12-06 13:41:04 +0000
Commit:     Benda Xu <heroxbd@gentoo.org>
CommitDate: 2017-12-06 13:42:36 +0000

    eclass/prefix.eclass: use a long line for @USAGE
    
      This is only for making eclass-manpages happy.
    
    Closes: https://bugs.gentoo.org/637848

 eclass/prefix.eclass | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)