Various suggestions for improving the ebuild: - eutils.eclass not needed - one sed not two for gtk/makefile - consistent sed paths and error messages - Encoding now removed from desktop file - ensure variable declared in src_compile is local - dodir's in src_install not needed Patch: https://github.com/gentoo/gentoo/pull/6190
Created attachment 504274 [details] tidied ebuild scite-4.0.2.ebuild thanks for the hints, applied and worksforme. ervin
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0d0a3c4df07778110309e721003fb90de4398297 commit 0d0a3c4df07778110309e721003fb90de4398297 Author: Chris Mayo <aklhfex@gmail.com> AuthorDate: 2017-11-16 19:27:12 +0000 Commit: Jonas Stein <jstein@gentoo.org> CommitDate: 2017-11-16 22:10:20 +0000 app-editors/scite: Tidy ebuild - eutils.eclass not needed - one sed not two for gtk/makefile - consistent sed paths and error messages - Encoding now removed from desktop file - ensure variable declared in src_compile is local - dodir's in src_install not needed Closes: https://bugs.gentoo.org/637518 Package-Manager: Portage-2.3.13, Repoman-2.3.3 app-editors/scite/scite-4.0.2.ebuild | 43 +++++++++++++++--------------------- 1 file changed, 18 insertions(+), 25 deletions(-)
