Bug 637474 – net.lo race condition in _gen_module_list() with rc_parallel=yes.

• Status: RESOLVED FIXED
• Product: Gentoo Hosted Projects

[Description hagbardcelin 2017-11-14 11:13:42 UTC]

When starting multiple interfaces with rc_paralell=YES the interfaces randomly picks up half-generated /run/openrc/nettree and thus fail to come online. Simple fix that works here is making one nettree for each interface(This might not be the RIGHT fix, but it works here). Will attach patch.

Reproducible: Sometimes

Steps to Reproduce:
1. Set rc_paralell=yes
2. Have multiple configured network interfaces
3. Boot repeatedly. 
Actual Results:  
Some of the networks cards will eventually fail usually with 'line 616: _exists: command not found

Expected Results:  
All network card come online as configured.

[Comment 1 hagbardcelin 2017-11-14 11:14:32 UTC]

Created attachment 504154 [details, diff]
Simple fix for described problem.

[Comment 2 Larry the Git Cow 2017-11-14 20:48:25 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=dbfe9a7fefa70150528a66aae380b7de52d15832

commit dbfe9a7fefa70150528a66aae380b7de52d15832
Author:     Hagbard Celine <[e-mail]>
AuthorDate: 2017-11-14 19:11:32 +0000
Commit:     Robin H. Johnson <[e-mail]>
CommitDate: 2017-11-14 19:11:40 +0000

    init.d/net.lo: per-iface moduleslist
    
    Avoid race conditions in generation of modules list (nettree), and allow
    per-interface custom module work more easily.
    
    Closes: https://bugs.gentoo.org/637474
    Signed-off-by: Robin H. Johnson <[e-mail]>

 init.d/net.lo.in | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/netifrc.git/commit/?id=66dc589e7478dc380c038c29073d8e438d80ed93

commit 66dc589e7478dc380c038c29073d8e438d80ed93
Author:     Robin H. Johnson <[e-mail]>
AuthorDate: 2017-11-14 19:14:12 +0000
Commit:     Robin H. Johnson <[e-mail]>
CommitDate: 2017-11-14 19:14:12 +0000

    init.d/net.lo: atomically create moduleslist.
    
    Bug: https://bugs.gentoo.org/637474
    Signed-off-by: Robin H. Johnson <[e-mail]>

 init.d/net.lo.in | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)}

[Comment 3 Larry the Git Cow 2017-11-27 21:00:39 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=56c4748dce0925382fc68822034d76f1634348c7

commit 56c4748dce0925382fc68822034d76f1634348c7
Author:     Robin H. Johnson <[e-mail]>
AuthorDate: 2017-11-27 20:29:43 +0000
Commit:     Robin H. Johnson <[e-mail]>
CommitDate: 2017-11-27 21:00:29 +0000

    net-misc/netifrc: bump.
    
    New functionality & improvements:
    - Wireless: 'iw' module to replace older 'iwconfig' module.
      (Brian Evans <[e-mail]>)
    - iproute2: VXLAN & GRETAP support (iplink_$IFVAR)
      (Sergey Popov <[e-mail]>)
    - Bonding: ARP IP targets (Marc Schiffbauer <[e-mail]>)
    - wpa_supplicant: better matching of wired connections
      (Henning Schild <[e-mail]>)
    - IPv6: clearer message for Tentative duplicate address detection (DAD).
    - Refactor veinfo printing of iproute2 commands.
    
    Fixes:
    - Avoid moduleslist race condition (Hagbard Celine <[e-mail]>)
    - Delete IPv6 tunnel correctly (stkchp <[e-mail]>)
    
    Bug: https://bugs.gentoo.org/638836
    Bug: https://bugs.gentoo.org/637474
    Bug: https://bugs.gentoo.org/636846
    Bug: https://github.com/gentoo/netifrc/pull/24
    Bug: https://github.com/gentoo/netifrc/pull/26
    Bug: https://github.com/gentoo/netifrc/pull/25
    Bug: https://github.com/gentoo/netifrc/pull/27
    Package-Manager: Portage-2.3.16, Repoman-2.3.6

 net-misc/netifrc/Manifest             | 17 +++++----
 net-misc/netifrc/netifrc-0.6.0.ebuild | 71 +++++++++++++++++++++++++++++++++++
 2 files changed, 80 insertions(+), 8 deletions(-)}