Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 637310 - dev-libs/libxslt-1.1.32 stabilization (needed for glibc-2.26 compat)
Summary: dev-libs/libxslt-1.1.32 stabilization (needed for glibc-2.26 compat)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: STABLEREQ
: 638082 (view as bug list)
Depends on:
Blocks: 632214 xlocale.h
  Show dependency tree
 
Reported: 2017-11-13 09:28 UTC by Nils Freydank
Modified: 2018-09-16 18:17 UTC (History)
2 users (show)

See Also:
Package list:
dev-libs/libxslt-1.1.32
Runtime testing required: ---
stable-bot: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nils Freydank 2017-11-13 09:28:46 UTC
Hi,

in commit 22feb6cfb4d502a668287e6cada18bf52d418776 libxslt got the xlocale.h header that came previously with glibc. If older versions of libxslt are installed with glibc-2.26 build errors occur (in my case kdoctools-5.40).

Problems & ideas:
- DEPEND="<glibc-2.26" would enforce downgrade
- upstream suggests "replace xlocale.h includes with locale.h includes"
- maybe solved by fixing Bug 612194?


(Thanks to bonsaikitten & dilfridge!)

Reproducible: Always
Comment 1 Felix Janda 2017-11-13 11:37:30 UTC
This is fixed in libxslt-1.1.32 via commit [1]. The commit does a lot
of additional clean up, so it might be nicer to use the patch from [2].

[1] https://git.gnome.org//browse/libxslt/commit/?id=8b4babb8f742a1a189df4c4569e68eda308df68f
[2] http://bugzilla.gnome.org/show_bug.cgi?id=788264
Comment 2 Pacho Ramos gentoo-dev 2017-11-24 19:52:10 UTC
*** Bug 638082 has been marked as a duplicate of this bug. ***
Comment 3 charles17 2018-04-07 14:29:09 UTC
https://github.com/gentoo/gentoo/pull/7268 should close this bug.
Comment 4 Larry the Git Cow gentoo-dev 2018-04-21 12:34:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e39d23cb4ddf16005e6dc6417c929219bbb16b85

commit e39d23cb4ddf16005e6dc6417c929219bbb16b85
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2018-04-21 11:23:40 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2018-04-21 12:33:02 +0000

    dev-libs/libxslt: bump to 1.1.32
    
    Drop the m4 patch that adds CXXFLAGS with unknown reasons of existing;
    it shouldn't be necessary as no AC_LANG([C++]) or such is used in
    configure.ac, so lets try without.
    
    simplify-python and python static modules disabling patches are kept
    for now, just having to adjust for the upstream rename of configure.in
    to configure.ac
    
    xslt-config breakage was fixed upstream in a different way, thus should
    not need that patch anymore, either.
    
    xlocale.h glibc removal was handled differently as well, via
    AC_CHECK_HEADERS([locale.h xlocale.h])
    AC_CHECK_FUNCS([strxfrm_l])
    with HAVE_LOCALE_H and HAVE_XLOCALE_H in the installed xsltlocale.h,
    about which I'm not sure how consumers are supposed to handle it when
    directly or indirectly including xsltlocale.h (presumably doing their
    own AC_CHECK_HEADERS call?), but that similar before as well via
    ifdef XSLT_LOCALE_XLOCALE in 1.1.30.
    
    "rm -r .. || die" instead of "rm -rf .." while here and fix unnecessary
    removal of non-existing non-python examples. There actually is a C
    example, but not installed (due to requiring ICU), so we'd have to
    doins it instead with USE=examples, but meh. Due to no -f, python examples
    have to be removed only if use python.
    
    Closes: https://bugs.gentoo.org/632214
    Bug: https://bugs.gentoo.org/637310
    Package-Manager: Portage-2.3.28, Repoman-2.3.9

 dev-libs/libxslt/Manifest                          |   1 +
 .../libxslt/files/1.1.32-simplify-python.patch     | 250 +++++++++++++++++++++
 dev-libs/libxslt/libxslt-1.1.32.ebuild             | 123 ++++++++++
 3 files changed, 374 insertions(+)}
Comment 5 Mart Raudsepp gentoo-dev 2018-04-21 12:43:12 UTC
I assume we need this bump also stable to unblock glibc-2.26-stable bug, thus converting this one to stabilization bug. Though lets let it simmer in ~arch for a bit...
@toolchain: When you need to proceed with glibc: feel free to CC arches if you don't find any issues reported about the bump, and make the glibc stable bug depend on this one, etc.

Target arches:
alpha amd64 arm arm64 hppa ia64 m68k ~mips ppc ppc64 s390 sh sparc x86
Comment 6 Mart Raudsepp gentoo-dev 2018-04-24 12:40:20 UTC
Nothing so far, I guess we can proceed with stabilization.
Comment 7 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-04-24 19:58:43 UTC
amd64 stable
Comment 8 Larry the Git Cow gentoo-dev 2018-04-25 06:08:51 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6d98db9ac6552035247d20e5add869b2845d68ec

commit 6d98db9ac6552035247d20e5add869b2845d68ec
Author:     Rolf Eike Beer <eike@sf-mail.de>
AuthorDate: 2018-04-24 20:03:25 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-04-25 06:08:34 +0000

    dev-libs/libxslt: stable 1.1.32 for sparc
    
    Bug: https://bugs.gentoo.org/637310
    Package-Manager: Portage-2.3.24, Repoman-2.3.6
    RepoMan-Options: --include-arches="sparc"

 dev-libs/libxslt/libxslt-1.1.32.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)}
Comment 9 Mart Raudsepp gentoo-dev 2018-04-25 10:06:49 UTC
arm64 stable
Comment 10 Thomas Deutschmann (RETIRED) gentoo-dev 2018-04-25 19:29:58 UTC
x86 stable
Comment 11 Matt Turner gentoo-dev 2018-04-26 05:03:06 UTC
ppc/ppc64 stable
Comment 12 Larry the Git Cow gentoo-dev 2018-04-26 06:40:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8946284b1054b7f02e6f4c0764ba3e1131e48abc

commit 8946284b1054b7f02e6f4c0764ba3e1131e48abc
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-04-26 06:40:18 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-04-26 06:40:18 +0000

    dev-libs/libxslt: stable 1.1.32 for ia64, bug #637310
    
    Bug: https://bugs.gentoo.org/637310
    Package-Manager: Portage-2.3.28, Repoman-2.3.9
    RepoMan-Options: --include-arches="ia64"

 dev-libs/libxslt/libxslt-1.1.32.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)}
Comment 13 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-04-28 11:32:59 UTC
arm stable
Comment 14 Andreas K. Hüttel archtester gentoo-dev 2018-04-30 12:10:24 UTC
Ping pretty please. This is blocking glibc-2.26 stabilization.
Comment 15 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-05-01 20:18:53 UTC
s390 stable
Comment 16 Larry the Git Cow gentoo-dev 2018-05-08 19:13:47 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ab29410a93b296acaa3d1940813038a05ccfc24d

commit ab29410a93b296acaa3d1940813038a05ccfc24d
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2018-05-08 19:13:35 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2018-05-08 19:13:35 +0000

    dev-libs/libxslt: stable 1.1.32 for hppa, bug #637310
    
    Bug: https://bugs.gentoo.org/637310
    Package-Manager: Portage-2.3.36, Repoman-2.3.9
    RepoMan-Options: --include-arches="hppa"

 dev-libs/libxslt/libxslt-1.1.32.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 17 Matt Turner gentoo-dev 2018-05-08 22:29:57 UTC
alpha stable
Comment 18 Andreas K. Hüttel archtester gentoo-dev 2018-05-11 19:17:08 UTC
Only waiting for zombie arches.
Comment 19 Larry the Git Cow gentoo-dev 2018-06-06 05:24:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b74cf4bf4f8e2867b5feb531c358bc548405aa5

commit 3b74cf4bf4f8e2867b5feb531c358bc548405aa5
Author:     Robin H. Johnson <robbat2@gentoo.org>
AuthorDate: 2018-06-06 05:22:13 +0000
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: 2018-06-06 05:24:06 +0000

    dev-perl/XML-LibXSLT: newer dev-libs/libxslt for glibc
    
    glibc-2.26 no longer ships xlocale.h, and consumers should switch to
    locale.h instead. dev-libs/libxslt-1.1.32 contains the fix, but we need
    to make sure it's present before dev-perl/XML-LibXSLT gets rebuilt.
    
    Bug: https://bugs.gentoo.org/show_bug.cgi?id=638010
    Bug: https://bugs.gentoo.org/637310
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
    Package-Manager: Portage-2.3.33, Repoman-2.3.9

 dev-perl/XML-LibXSLT/XML-LibXSLT-1.940.0.ebuild | 4 ++--
 dev-perl/XML-LibXSLT/XML-LibXSLT-1.950.0.ebuild | 4 ++--
 dev-perl/XML-LibXSLT/XML-LibXSLT-1.960.0.ebuild | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)
Comment 20 Mikle Kolyada (RETIRED) archtester Gentoo Infrastructure gentoo-dev Security 2018-09-16 18:16:46 UTC
m68k/sh stable