Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 637178 - mail-client/mutt: crypto backends: Use more descriptive USE flag names and descriptions
Summary: mail-client/mutt: crypto backends: Use more descriptive USE flag names and de...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Nicolas Bock
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-11 20:44 UTC by brunoboclair
Modified: 2017-12-16 14:27 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description brunoboclair 2017-11-11 20:44:25 UTC
Dear maintainer

The USE flags for the crypto support (S/MIME, PGP/MIME) in neomutt are named odd and kind of misleading.
Currently we have

crypt = traditional/inline PGP and PGP/MIME support through mod_pgp_classic backend. Calls GPG binary at runtime.
gpg   = traditional/inline PGP, PGP/MIME and S/MIME support through mod_pgp_gpgme and mod_smime_gpgme backends. Needs gpgme at compile time.
smime = S/MIME support through mod_smime_classic backend. Calls OpenSSL binary at runtime.

I suggest renaming these USE flags with the following description (name and phrasing is up to debate)

gpgme =  Build gpgme backend to support S/MIME, PGP/MIME and traditional/inline PGP.
pgp_classic = Build classic_pgp backend to support PGP/MIME and traditional/inline PGP.
smime_classic = Build classic_smime backend to support S/MIME.

On your discretion you might add "uses app-crypt/gpgme library", "uses dev-libs/openssl at runtime", "uses app-crypt/gnupg at runtime".


The second issue is regarding their dependencies:

Classic PGP needs app-crypt/gnupg at runtime but this is not a dependency.
Classic S/MIME needs dev-libs/openssl at runtime which currently is pulled in by a hack: smime depends on the ssl USE flag.
However, we can use GnuTLS as TLS library and still use OpenSSL (at runtime) for the classic S/MIME. I therefore suggest to
state this dependency explicitly.
Comment 1 Fabian Groffen gentoo-dev 2017-11-12 09:25:42 UTC
reassigning to NeoMutt maintainer
Comment 2 Fabian Groffen gentoo-dev 2017-12-10 09:33:29 UTC
If I'm not mistaken this was dealt with now, thanks!
Comment 3 Larry the Git Cow gentoo-dev 2017-12-10 13:46:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b92b1c6b2c267748be8c748ebcf9ff9a6ec456b5

commit b92b1c6b2c267748be8c748ebcf9ff9a6ec456b5
Author:     Nicolas Bock <nicolasbock@gentoo.org>
AuthorDate: 2017-12-10 13:45:56 +0000
Commit:     Nicolas Bock <nicolasbock@gentoo.org>
CommitDate: 2017-12-10 13:45:56 +0000

    mail-client/mutt: Update USE flag descriptions
    
    The crypto related USE flags are named and described somewhat
    confusingly. This change updates the crypto related USE flags and adds
    some more consistent descriptions. This change brings those USE flags in
    sync with the neomutt package.
    
    Closes: https://bugs.gentoo.org/637178
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 mail-client/mutt/metadata.xml         |  67 +++++----
 mail-client/mutt/mutt-1.9.1-r3.ebuild | 264 ++++++++++++++++++++++++++++++++++
 2 files changed, 301 insertions(+), 30 deletions(-)
Comment 4 Fabian Groffen gentoo-dev 2017-12-10 15:10:10 UTC
Ok, it seems we had some confusion here, I got the feeling this only applied to neomutt, not mutt.  My bad for not updating the subject of this bug.
Comment 5 Fabian Groffen gentoo-dev 2017-12-10 16:31:52 UTC
I added the rdeps too, so now we can conclude this entire bug is fixed.
Comment 6 Nicolas Bock gentoo-dev 2017-12-11 12:24:08 UTC
Sorry if I misunderstood this bug. I looked at the title and didn't read the bug text carefully enough :( I could roll them back if you prefer.
Comment 7 Fabian Groffen gentoo-dev 2017-12-11 12:29:03 UTC
that only creates more confusion :) let's keep it this way, I'll remove the old flags on the next major release (1.10 or 2.0).
Comment 8 Nicolas Bock gentoo-dev 2017-12-11 12:32:27 UTC
Thanks!
Comment 9 brunoboclair 2017-12-16 14:27:33 UTC
Hi guys

Just wanted to say thank you for taking care of this issue. Keep up the good work!