Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 637104 - app-vim/gentoo-syntax show trailing white space and tabs
Summary: app-vim/gentoo-syntax show trailing white space and tabs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Vim Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-10 22:50 UTC by Jonas Stein
Modified: 2018-08-20 21:06 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2017-11-10 22:50:50 UTC
It would be great, if vim would show trailing white space in .ebuild and metadata.xml files and tabs per default.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-08-20 15:26:09 UTC
Do I understand correctly that you mean whitespace errors?
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2018-08-20 20:23:12 UTC
Well, the gentoo-common rules are apparently supposed to handle that.  FWICS, they work correctly in global scope but for some reason don't trigger inside shell functions.  I'm afraid it's above my vim skills to figure out why.
Comment 3 Larry the Git Cow gentoo-dev 2018-08-20 20:37:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/gentoo-syntax.git/commit/?id=9b572f92349cf63d44ff457e2942838d7e1385e3

commit 9b572f92349cf63d44ff457e2942838d7e1385e3
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-08-20 20:36:07 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-08-20 20:36:07 +0000

    syntax/ebuild: Also detect whitespace errors in double quotes
    
    Include our whitespace error thingies in the list of thingies for
    double-quotes.  Sadly, the shell syntax highlighting seems to miss
    a list for single quotes.
    
    Bug: https://bugs.gentoo.org/637104

 syntax/ebuild.vim | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

https://gitweb.gentoo.org/proj/gentoo-syntax.git/commit/?id=0c91fccc7bf5477812de0438a6f7dc79fa65f5bf

commit 0c91fccc7bf5477812de0438a6f7dc79fa65f5bf
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-08-20 20:33:41 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-08-20 20:33:55 +0000

    syntax/gentoo-common: Detect mixed tab-space indent
    
    Bug: https://bugs.gentoo.org/637104

 syntax/gentoo-common.vim | 2 ++
 1 file changed, 2 insertions(+)

https://gitweb.gentoo.org/proj/gentoo-syntax.git/commit/?id=47fb36a2ef522919704b0403fcc82b7e1bb8770a

commit 47fb36a2ef522919704b0403fcc82b7e1bb8770a
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-08-20 20:29:07 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-08-20 20:29:27 +0000

    syntax/ebuild: Detect whitespace errors inside functions too
    
    Bug: https://bugs.gentoo.org/637104

 syntax/ebuild.vim | 1 +
 1 file changed, 1 insertion(+)
Comment 4 Larry the Git Cow gentoo-dev 2018-08-20 21:06:53 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=daddf63e4386056e4f71945f9d5ed3247ac1e6e6

commit daddf63e4386056e4f71945f9d5ed3247ac1e6e6
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-08-20 20:50:21 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-08-20 21:06:43 +0000

    app-vim/gentoo-syntax: Bump to 20180820
    
    Closes: https://bugs.gentoo.org/637104
    Closes: https://bugs.gentoo.org/637100
    Closes: https://bugs.gentoo.org/605078

 app-vim/gentoo-syntax/Manifest                     |  1 +
 .../gentoo-syntax/gentoo-syntax-20180820.ebuild    | 42 ++++++++++++++++++++++
 2 files changed, 43 insertions(+)