Created attachment 503404 [details] Cumulative diff for three ebuilds to include acpi USE flag and acpid dep Enlightenment can make use of ACPI events (e.g. suspend if laptop lid closed), but it needs sys-power/acpid for this. Found this out the hard way as there do not seem to be any error messages hinting at this necessary dependency. Therefore, the acpi USE flag should be added to current ebuilds. A patch for enlightenment-0.2* ebuilds is attached.
In much the same way, connman is missing as a dependency when selected as an enlightenment module. In the os-xtoo overlay (https://github.com/Obsidian-StudiosInc/os-xtoo/blob/master/x11-wm/enlightenment/enlightenment-9999.ebuild) connman is not selectable as a module, but is a normal use flag. I don't know whether this has any advantage, but it sounds a little more logical, as a system-wide connman use flag would automatically pull it in, without the need to specify the module explicitly. Otherwise, this should do: enlightenment_modules_connman? ( net-misc/connman )
Ill make a PR to update E21 into 0.21.11. It has acpi USE flag with sys-power/acpid dependency. Ill also update this for E22 when 0.22.4 hits. Not sure about the connman dependency. Fast glancing through source files it seems to depend a lot on econnman thats (currently) not available in portage. Can you confirm it works without econnman? If it does, Id say connman USE flag to enable it, because most people have all the modules enabled and dont think about them too much. I plan to remove <0.21.11 when 0.21.11 gets arch keyworded and stabilized (hopefully soon) so Ill leave already existing ebuilds untouched for now...
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e1b578a4e713b27b2911edaff50f9fc9c7ac119 commit 0e1b578a4e713b27b2911edaff50f9fc9c7ac119 Author: Joonas Niilola <juippis@gmail.com> AuthorDate: 2018-05-25 14:30:51 +0000 Commit: Aaron Bauman <bman@gentoo.org> CommitDate: 2018-05-25 18:11:32 +0000 x11-wm/enlightenment: bump E21 to 0.21.11 Bug: https://bugs.gentoo.org/637034 Bug: https://bugs.gentoo.org/615426 Package-Manager: Portage[mgorny]-2.3.36.1 Closes: https://github.com/gentoo/gentoo/pull/8583 x11-wm/enlightenment/Manifest | 1 + x11-wm/enlightenment/enlightenment-0.21.11.ebuild | 139 +++++++++++++++++++++ .../files/enlightenment-0.21.11-quickstart.diff | 13 ++ x11-wm/enlightenment/metadata.xml | 1 + 4 files changed, 154 insertions(+)
Yes, it definitely works without econnman. It just shows the connman status. For configuring it, econnman is necessary.
Ok, thanks for confirming. Ill prepare a PR to fix this in >=0.21.11. Ill investigate if efl[connman] is needed for the module, or is efl[connman] only used by econnman. Once again, Ill leave <0.21.11 untouched because they are waiting to be removed, but Ill mark the bug fixed when PR gets merged. Then this will be noted in future versions, thanks!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0c0d00c060fb5f87129d0b4acf7d981b3a31e76c commit 0c0d00c060fb5f87129d0b4acf7d981b3a31e76c Author: Joonas Niilola <juippis@gmail.com> AuthorDate: 2018-06-03 14:22:26 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-06-09 09:32:45 +0000 x11-wm/enlightenment: add 'acpi' and 'connman' USE flags to 0.22.3 Removed sed line which 'fixed' QA issues. Updated description. Closes: https://bugs.gentoo.org/637034 Closes: https://github.com/gentoo/gentoo/pull/8711 Package-Manager: Portage[mgorny]-2.3.36.1 x11-wm/enlightenment/enlightenment-0.22.3.ebuild | 31 ++++++++++++------------ 1 file changed, 16 insertions(+), 15 deletions(-) Additionally, it has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e069e34bad9acd52454f693588a89b9c234a63e commit 3e069e34bad9acd52454f693588a89b9c234a63e Author: Joonas Niilola <juippis@gmail.com> AuthorDate: 2018-06-03 14:14:58 +0000 Commit: Michał Górny <mgorny@gentoo.org> CommitDate: 2018-06-09 08:31:26 +0000 x11-wm/enlightenment: add 'connman' USE flag for 0.21.11 Bug: https://bugs.gentoo.org/637034 Package-Manager: Portage[mgorny]-2.3.36.1 x11-wm/enlightenment/enlightenment-0.21.11.ebuild | 24 ++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-)
