Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 636924 - gnome-extra/cinnamon-screensaver-3.4.2 - add USE=xinerama
Summary: gnome-extra/cinnamon-screensaver-3.4.2 - add USE=xinerama
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Cinnamon Team (DISABLED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-08 21:23 UTC by cronolio
Modified: 2017-11-28 19:52 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
cinnamon-screensaver-3.4.2.ebuild (file_636924.txt,2.59 KB, text/plain)
2017-11-10 08:33 UTC, cronolio
Details

Note You need to log in before you can comment on or make changes to this bug.
Description cronolio 2017-11-08 21:23:48 UTC
## original ##
IUSE="debug doc pam systemd"
COMMON_DEPEND="
..........
${PYTHON_DEPS}

pam? ( virtual/pam )
systemd? ( >=sys-apps/systemd-31:0= )
"

........

src_configure() {
	gnome2_src_configure \
		$(usex debug --enable-debug ' ') \
.....
}


## my ##
IUSE="debug doc pam systemd xinerama"
COMMON_DEPEND="
..........
${PYTHON_DEPS}

pam? ( virtual/pam )
systemd? ( >=sys-apps/systemd-31:0= )
xinerama? ( x11-libs/libXinerama )
"

........

src_configure() {
	gnome2_src_configure \
		$(usex debug --enable-debug ' ') \
                $(use_enable xinerama)
.....
}


Thanks
Comment 1 Andreas Sturmlechner gentoo-dev 2017-11-09 23:17:06 UTC
Thanks for your report. You can help get your changes easier to review and faster to tree if you attach them as unified diffs over the latest ebuild rather than inline snippets.
Comment 2 cronolio 2017-11-10 08:33:15 UTC
Created attachment 503402 [details]
cinnamon-screensaver-3.4.2.ebuild

i can provide full my ebuild
Comment 3 Kristian Fiskerstrand (RETIRED) gentoo-dev 2017-11-10 09:00:43 UTC
(In reply to cronolio from comment #2)
> Created attachment 503402 [details]
> cinnamon-screensaver-3.4.2.ebuild
> 
> i can provide full my ebuild

It is always better to provide a git format-patch for a revision bump including a proper commit message.
Comment 4 cronolio 2017-11-10 09:51:32 UTC
(In reply to Kristian Fiskerstrand from comment #3)
> (In reply to cronolio from comment #2)
> > Created attachment 503402 [details]
> > cinnamon-screensaver-3.4.2.ebuild
> > 
> > i can provide full my ebuild
> 
> It is always better to provide a git format-patch for a revision bump
> including a proper commit message.

when i will know git.. of course. and i'm not sure about each line of my ebuild. take it like user-level ebuild
Comment 5 Larry the Git Cow gentoo-dev 2017-11-28 19:52:18 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0161e52577c0d12c50854c6e2441f2d7ebd7a4e5

commit 0161e52577c0d12c50854c6e2441f2d7ebd7a4e5
Author:     Kristian Fiskerstrand <k_f@gentoo.org>
AuthorDate: 2017-11-28 19:51:48 +0000
Commit:     Kristian Fiskerstrand <k_f@gentoo.org>
CommitDate: 2017-11-28 19:52:06 +0000

    gnome-extra/cinnamon-screensaver: Add xinerama use flag
    
    Thanks-To: cronolio
    Bug: https://bugs.gentoo.org/636924
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 .../cinnamon-screensaver-3.6.1-r1.ebuild           | 93 ++++++++++++++++++++++
 1 file changed, 93 insertions(+)}