Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 636886 - =sci-misc/boinc-7.8.1 - update icon cache
Summary: =sci-misc/boinc-7.8.1 - update icon cache
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Sven Eden
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-08 17:24 UTC by Francesco Turco
Modified: 2017-12-21 10:47 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Francesco Turco 2017-11-08 17:24:31 UTC
/usr/share/icons/hicolor/icon-theme.cache needs to be updated every time users install or remove BOINC.
Comment 1 Francesco Turco 2017-11-08 19:26:39 UTC
https://github.com/gentoo/gentoo/pull/5719/
Comment 2 Sven Eden 2017-11-19 16:16:38 UTC
The PR looks in order to me.
Comment 3 Larry the Git Cow gentoo-dev 2017-12-20 20:13:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4f8f65525b333b3f895d6c59e514433270b87cfc

commit 4f8f65525b333b3f895d6c59e514433270b87cfc
Author:     Francesco Turco <fturco@fastmail.fm>
AuthorDate: 2017-09-18 11:59:46 +0000
Commit:     Craig Andrews <candrews@gentoo.org>
CommitDate: 2017-12-20 20:13:26 +0000

    sci-misc/boinc: update icon cache
    
    /usr/share/icons/hicolor/icon-theme.cache needs to be updated
    every time users install or remove BOINC
    
    Closes: https://bugs.gentoo.org/636886

 sci-misc/boinc/boinc-7.8.1-r1.ebuild | 189 +++++++++++++++++++++++++++++++++++
 1 file changed, 189 insertions(+)
Comment 4 Mart Raudsepp gentoo-dev 2017-12-21 10:35:50 UTC
savelist is unnecessary if you unconditionally call gnome2_icon_cache_update anyways. Revbump is unnecessary for such a change, as any other rebuild or upgrade that calls the update would have it fixed anyways -- the CONTENTS does NOT change.
Comment 5 Larry the Git Cow gentoo-dev 2017-12-21 10:47:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ff0b882bc4eb16abcca916707bd2cb7d6ace4e5

commit 8ff0b882bc4eb16abcca916707bd2cb7d6ace4e5
Author:     Mart Raudsepp <leio@gentoo.org>
AuthorDate: 2017-12-21 10:44:08 +0000
Commit:     Mart Raudsepp <leio@gentoo.org>
CommitDate: 2017-12-21 10:46:54 +0000

    sci-misc/boinc: update icon cache in 7.8.4 as well
    
    This brings in the iconcache update fix from 7.8.1-r1 that was
    pushed while 7.8.4 PR was still unmerged. But without the
    redundant gnome2_icon_savelist call, as the conditional to
    only call cache update isn't inside itself since a while now.
    
    Bug: https://bugs.gentoo.org/636886
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 sci-misc/boinc/boinc-7.8.4.ebuild | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)}