Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 636734 - media-plugins/audacious-plugins-3.9 - USE=utils for dev-libs/glib not needed?
Summary: media-plugins/audacious-plugins-3.9 - USE=utils for dev-libs/glib not needed?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jason A. Donenfeld
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-06 20:07 UTC by Chris Mayo
Modified: 2017-11-14 09:48 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Ebuild for media-plugins/audacious-3.9 without dev-libs/glib[utils] dependency (audacious-plugins-3.9.ebuild,4.26 KB, text/plain)
2017-11-11 22:06 UTC, Sophie Hamilton
Details
Ebuild for media-plugins/audacious-3.9 without dev-libs/glib[utils] dependency (audacious-plugins-3.9.ebuild,4.27 KB, text/plain)
2017-11-11 22:11 UTC, Sophie Hamilton
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Mayo 2017-11-06 20:07:16 UTC
RDEPEND has dev-libs/glib[utils]

utils was added by bug 485142, but this was probably an error because the reason it works is that it pulls in dev-util/gdbus-codegen?

Working fine for me without USE="utils" for dev-libs/glib, although I'm only really using alsa and flac plugins.
Comment 1 Sophie Hamilton 2017-11-11 22:06:40 UTC
Created attachment 503654 [details]
Ebuild for media-plugins/audacious-3.9 without dev-libs/glib[utils] dependency

Grepping through the audacious-plugins unpacked source shows no occurrences of "gtester" at all, let alone gtester-report.

As such, it does seem like gdbus-codegen is what is actually wanted, and this seems to already be listed as a build-time dependency in the DEPEND variable.

In previous versions, this was listed in RDEPEND as a run-time dependency:

> ( || ( >=dev-libs/glib-2.32.2[utils] dev-util/gdbus-codegen ) )

This was correctly pointed out in bug #590008 as being incorrect as gdbus-codegen was only ever used at build time, and the gdbus-codegen dependency was thus moved to the DEPEND variable for the 3.9 ebuild. My guess is that when this happened, the dependency on glib was left in RDEPEND incorrectly (and I believe it should never have been there in the first place; even dev-libs/glib-2.32.4-r1 - the earliest version I still have an ebuild file hanging around for - had the gdbus-codegen dependency for "utils").

I've made a local ebuild without this dependency and so far everything appears to be working correctly. I've attached the ebuild I'm using.

Note that this change will need to be made to audacious-plugins-9999.ebuild as well.
Comment 2 Sophie Hamilton 2017-11-11 22:11:23 UTC
Created attachment 503656 [details]
Ebuild for media-plugins/audacious-3.9 without dev-libs/glib[utils] dependency

My apologies; it *does* require dev-libs/glib, but doesn't require the "utils" USE flag. Here's the correct ebuild.
Comment 3 Larry the Git Cow gentoo-dev 2017-11-14 09:48:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4d1226da2e7d83317aa11738cb48e03d9c714634

commit 4d1226da2e7d83317aa11738cb48e03d9c714634
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2017-11-14 09:34:00 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2017-11-14 09:47:32 +0000

    media-plugins/audacious-plugins: Remove 'utils' USE dep on glib
    
    Closes: https://bugs.gentoo.org/636734
    Package-Manager: Portage-2.3.13, Repoman-2.3.4

 media-plugins/audacious-plugins/audacious-plugins-3.9.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)