In profiles/base/make.defaults we have: # Ole Markus With <olemarkus@gentoo.org> (09 Oct 2010) # Default PHP targets (should always be latest stable version) PHP_TARGETS="php5-6" Yet the current stable version is php-7.0.23. This is causing problems with ebuilds that make use of PHP_TARGETS.
(In reply to Anthony Basile from comment #0) > In profiles/base/make.defaults we have: > > # Ole Markus With <olemarkus@gentoo.org> (09 Oct 2010) > # Default PHP targets (should always be latest stable version) > PHP_TARGETS="php5-6" > > Yet the current stable version is php-7.0.23. This is causing problems with > ebuilds that make use of PHP_TARGETS. Very few ebuilds do not use php_targets_php5-6 (I count 2) and have higher versions. The problem with forcing it higher right now is the extended support period for 5.6 so older projects have a chance to fix the backwards compatibility breaks with higher versions. This should have been completed for most by now, but I cannot comment on all software in the wild. What would someone recommend? Change it to PHP_TARGETS="php5-6 php7-0"? In 13 months, both of those targets go EOL and the first security bug will promote 7.1 (or maybe 7.2) as the default by then.
If anything, we would make it PHP_TARGETS="php5-6 php7-0" because the eclass only uses a particular target if it appears in *both* PHP_TARGETS and USE_PHP (therefore, adding more targets shouldn't hurt). Regardless, I don't think that's the problem in bug 635826. Somehow, the ebuild wound up trying to use php-5.6 even though php-5.6 wasn't installed -- the eclass should be taking care of that, though.
(In reply to Michael Orlitzky from comment #2) > If anything, we would make it > > PHP_TARGETS="php5-6 php7-0" > > because the eclass only uses a particular target if it appears in *both* > PHP_TARGETS and USE_PHP (therefore, adding more targets shouldn't hurt). > > Regardless, I don't think that's the problem in bug 635826. Somehow, the > ebuild wound up trying to use php-5.6 even though php-5.6 wasn't installed > -- the eclass should be taking care of that, though. Thanks guys. I'll take your lead on this. Let me know what you decide for the eclass and I'll take care of any downstream ramifications, like bug 635826.
(In reply to Anthony Basile from comment #3) > (In reply to Michael Orlitzky from comment #2) > > If anything, we would make it > > > > PHP_TARGETS="php5-6 php7-0" > > > > because the eclass only uses a particular target if it appears in *both* > > PHP_TARGETS and USE_PHP (therefore, adding more targets shouldn't hurt). > > > > Regardless, I don't think that's the problem in bug 635826. Somehow, the > > ebuild wound up trying to use php-5.6 even though php-5.6 wasn't installed > > -- the eclass should be taking care of that, though. > > Thanks guys. I'll take your lead on this. Let me know what you decide for > the eclass and I'll take care of any downstream ramifications, like bug > 635826. The eclass is doing its job that I can tell. When I tested the patch in the bug 635826, the dependencies were listed in the environment file. So, the only thing to discuss is if we should expand PHP_TARGETS now or wait for another time.
I've been thinking about this, and I'm leaning towards PHP_TARGETS="php5-6 php7-0" instead of PHP_TARGETS="php7-0" The default should work for people who "don't care about PHP," namely those people who have it pulled in as a dependency of something else. Normally the "latest stable version" would work, but there are still some extensions that don't build with php7-0, and we shouldn't make users stop to mess with their PHP_TARGETS if a usable (stable) php5-6 would work for them.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=afaef996e561f8069b8d177ea76fcde1d0bc20a6 commit afaef996e561f8069b8d177ea76fcde1d0bc20a6 Author: Michael Orlitzky <mjo@gentoo.org> AuthorDate: 2017-11-17 18:48:55 +0000 Commit: Michael Orlitzky <mjo@gentoo.org> CommitDate: 2017-11-18 01:11:46 +0000 profiles: add "php7-0" to PHP_TARGETS in base/make.defaults. The old value of the PHP_TARGETS variable was "php5-6", but these days PHP_TARGETS="php5-6 php7-0" is more appropriate. The rationale for this change is now included as a comment above the variable. Closes: https://bugs.gentoo.org/636692 profiles/base/make.defaults | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-)
