Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 636164 - net-im/signal-desktop - Signal Private Messenger for the Desktop
Summary: net-im/signal-desktop - Signal Private Messenger for the Desktop
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Default Assignee for New Packages
URL: https://signal.org/blog/standalone-si...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-01 14:42 UTC by Dennis Schridde
Modified: 2017-11-23 05:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2017-11-01 14:42:03 UTC
It would be great to have an ebuild for net-im/signal-desktop, which was just announced [1].

DESCRIPTION="Signal Private Messenger for the Desktop"
HOMEPAGE="https://signal.org/"

The app is built with dev-util/electron, which hopefully allows to create a from-source ebuild, instead of using the binary packages from their download page [2].

[1]: https://signal.org/blog/standalone-signal-desktop/
[2]: https://signal.org/download/
Comment 1 Robert G. Siebeck 2017-11-02 14:59:08 UTC
I wrote an ebuild. However, it's using the official .deb file, so not building from source.

https://github.com/robert7k/gentoo-overlay/blob/master/net-im/signal-desktop-bin/signal-desktop-bin-1.0.35.ebuild
Comment 2 K3A 2017-11-02 16:28:37 UTC
I wrote ebuild which makes it from the source. It uses yarn (recommended npm replacement) to fetch NPM packages and internal Gruntfile.js to compile.

https://github.com/k3a/gentoo-overlay/tree/master/net-im/signal-desktop

* 9999 version uses latest development git repo without modification.

* Numbered version changes build process minimally to get the modification time of package.json in order to set up expiration timer. Normally expiration timer is based on latest git commit time but tar.gz releases are not git repo so I use package.json mod. time instead.

Enjoy!
Comment 3 Louis Sautier (sbraz) gentoo-dev 2017-11-16 16:08:31 UTC
Would one of you guys be interested in proxy-maintaining it? https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
Comment 4 Louis Sautier (sbraz) gentoo-dev 2017-11-16 19:12:18 UTC
(In reply to K3A from comment #2)
> I wrote ebuild which makes it from the source. It uses yarn (recommended npm
> replacement) to fetch NPM packages and internal Gruntfile.js to compile.
> 
> https://github.com/k3a/gentoo-overlay/tree/master/net-im/signal-desktop
> 
> * 9999 version uses latest development git repo without modification.
> 
> * Numbered version changes build process minimally to get the modification
> time of package.json in order to set up expiration timer. Normally
> expiration timer is based on latest git commit time but tar.gz releases are
> not git repo so I use package.json mod. time instead.
> 
> Enjoy!

Your ebuild requires network access, isn't there a way to pull all the dependencies in SRC_URI?
The binary ebuild seems to work fine.
Comment 5 Dennis Schridde 2017-11-17 05:41:19 UTC
(In reply to Louis Sautier (sbraz) from comment #4)
> Your ebuild requires network access, isn't there a way to pull all the
> dependencies in SRC_URI?

I would suggest to mimic the app-editors/atom ebuild, which is also based on dev-util/electron.  That's how I would approach this, would I have the time.
Comment 6 Robert G. Siebeck 2017-11-18 13:46:35 UTC
(In reply to Louis Sautier (sbraz) from comment #3)
> Would one of you guys be interested in proxy-maintaining it?
> https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers

I could do that for the binary package I wrote. I read that page and some other pages linked there, but I'm not sure how to get started with being a proxied maintainer.
Comment 7 Louis Sautier (sbraz) gentoo-dev 2017-11-18 14:00:43 UTC
(In reply to Robert G. Siebeck from comment #6)
> (In reply to Louis Sautier (sbraz) from comment #3)
> > Would one of you guys be interested in proxy-maintaining it?
> > https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
> 
> I could do that for the binary package I wrote. I read that page and some
> other pages linked there, but I'm not sure how to get started with being a
> proxied maintainer.

You can join #gentoo-proxy-maint on irc.freenode.net and you'll get help there :)
It's often done through pull requests on github.
Comment 8 Larry the Git Cow gentoo-dev 2017-11-19 13:38:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a60d22e460dd79d5386b957fa941427183883dd7

commit a60d22e460dd79d5386b957fa941427183883dd7
Author:     robert <robert@siebeck.org>
AuthorDate: 2017-11-19 13:24:33 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2017-11-19 13:37:21 +0000

    net-im/signal-desktop-bin: Initial addition
    
    Closes: https://bugs.gentoo.org/636164
    Closes: https://github.com/gentoo/gentoo/pull/6233

 net-im/signal-desktop-bin/Manifest                 |  1 +
 net-im/signal-desktop-bin/metadata.xml             | 13 ++++++
 .../signal-desktop-bin-1.0.38.ebuild               | 49 ++++++++++++++++++++++
 3 files changed, 63 insertions(+)
Comment 9 Simon 2017-11-23 05:35:34 UTC
I dont think this bug should be closed with only a binary ebuild in the tree, this ebuild is security related so source build should be available or even mandatory.