Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 636098 - kde-plasma/powerdevil-5.11.2[brightness-control] WITH_DDCUTIL flag is not recognized during cmake
Summary: kde-plasma/powerdevil-5.11.2[brightness-control] WITH_DDCUTIL flag is not rec...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo KDE team
URL: https://phabricator.kde.org/D8626
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-31 19:01 UTC by Hannes Schweizer
Modified: 2018-02-03 01:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
ddcutil_define.patch (ddcutil_define.patch,409 bytes, patch)
2017-10-31 19:01 UTC, Hannes Schweizer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hannes Schweizer 2017-10-31 19:01:55 UTC
Created attachment 501434 [details, diff]
ddcutil_define.patch

I've been trying to enable brightness control of my external monitor by adding the following USE flags:
# control brightness of external monitor from kde
kde-plasma/powerdevil brightness-control
app-misc/ddcutil user-permissions

However powerdevil reported issues (cat ~/.local/share/sddm/xorg-session.log | grep -i ddc):
powerdevil: Xrandr not supported, trying ddc, helper
powerdevil: [DDCutilBrightness] compiled without DDC/CI support

After a little digging through the build.log, I think powerdevil is indeed finding the necessary ddcutil files, however one crucial define is not correctly passed during cmake (see attached patch).

With this patch in place, it finally worked:
powerdevil: Xrandr not supported, trying ddc, helper
powerdevil: Check for monitors using ddca_get_displays()...
powerdevil: ddca_get_display_info_list() returned  0x56048b2fbb50
powerdevil: [DDCutilBrightness]  1 display(s) were detected
powerdevil: [DDCutilBrightness]  30 capabilities parsed
powerdevil: Using DDCutillib

I'm not really familiar with the cmake.eclass, so I cannot determine whether it's an ebuild or upstream problem. I'm happy to generate a proper PR (with a new ebuild release + patch) for gentoo, if required.


# emerge --info
Portage 2.3.13 (python 2.7.12-final-0, default/linux/amd64/17.0/desktop/plasma, gcc-7.2.0, glibc-2.25-r8, 4.13.10-gentoo x86_64)
=================================================================
System uname: Linux-4.13.10-gentoo-x86_64-Intel-R-_Core-TM-_i5_CPU_760_@_2.80GHz-with-gentoo-2.4.1
KiB Mem:    12303572 total,   2865264 free
KiB Swap:          0 total,         0 free
Head commit of repository gentoo: 99e31d7df188eec0b6d9c1233250e4752f9beea5

sh bash 4.3_p48-r1
ld GNU ld (Gentoo 2.29.1 p3) 2.29.1
app-shells/bash:          4.3_p48-r1::gentoo
dev-java/java-config:     2.2.0-r3::gentoo
dev-lang/perl:            5.24.3::gentoo
dev-lang/python:          2.7.12::gentoo, 3.4.5::gentoo
dev-util/cmake:           3.8.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.32.1::gentoo
sys-apps/sandbox:         2.10-r4::gentoo
sys-devel/autoconf:       2.13::gentoo, 2.69::gentoo
sys-devel/automake:       1.11.6-r1::gentoo, 1.15-r2::gentoo
sys-devel/binutils:       2.29.1-r1::gentoo
sys-devel/gcc:            7.2.0::gentoo
sys-devel/gcc-config:     1.9.0-r1::lto-overlay
sys-devel/libtool:        2.4.6-r3::gentoo
sys-devel/make:           4.2.1::gentoo
sys-kernel/linux-headers: 4.13::gentoo (virtual/os-headers)
sys-libs/glibc:           2.25-r8::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: git
    sync-uri: https://github.com/nilathak/gentoo.git
    priority: -1000

kde
    location: /var/lib/layman/kde
    sync-type: laymansync
    sync-uri: https://github.com/gentoo/kde.git
    masters: gentoo
    priority: 50

lto-overlay
    location: /var/lib/layman/lto-overlay
    sync-type: laymansync
    sync-uri: https://github.com/InBetweenNames/gentooLTO.git
    masters: gentoo mv
    priority: 50

mv
    location: /var/lib/layman/mv
    sync-type: laymansync
    sync-uri: https://anongit.gentoo.org/git/user/mv.git
    masters: gentoo
    priority: 50

science
    location: /var/lib/layman/science
    sync-type: laymansync
    sync-uri: https://anongit.gentoo.org/git/proj/sci.git
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="* -@EULA PUEL"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O3 -fgraphite-identity -ftree-loop-distribution -floop-nest-optimize -flto=8 -fuse-linker-plugin -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.0/ext-active/ /etc/php/cgi-php7.0/ext-active/ /etc/php/cli-php7.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=native -O3 -fgraphite-identity -ftree-loop-distribution -floop-nest-optimize -flto=8 -fuse-linker-plugin -pipe"
DISTDIR="/tmp"
EMERGE_DEFAULT_OPTS="--autounmask-unrestricted-atoms --autounmask-keep-masks --verbose-conflict --with-bdeps=y -j --load-average=5.0"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles merge-sync multilib-strict news nodoc noinfo parallel-fetch preserve-libs protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://ftp.uni-erlangen.de/pub/mirrors/gentoo/ http://ftp-stud.hs-esslingen.de/pub/Mirrors/gentoo/"
LANG="en_US.utf8"
LDFLAGS="-Wl,--as-needed -Wl,--hash-style=gnu"
MAKEOPTS="-j5"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi activities alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli consolekit cracklib crypt css cups cxx dbus declarative dri dts dvd dvdr emacs emboss encode exif fam ffmpeg firefox flac fortran gif glamor gphoto2 gpm iconv ipv6 jpeg kde kipi kwallet lcms libnotify mad mng modules mp3 mp4 mpeg ncurses nptl ogg opencl opengl openmp pam pango pcre pdf phonon plasma png policykit ppds qml qt3support qt4 qt5 readline sdl seccomp semantic-desktop session ssl startup-notification svg tcpd threads tiff truetype udev udisks unicode upower usb vdpau vorbis widgets wxwidgets x264 x265 xattr xcb xcomposite xinerama xml xscreensaver xv xvid zlib" ABI_X86="64" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="kexi words flow plan sheets stage tables krita karbon braindump author" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="evdev" KERNEL="linux" L10N="en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php5-6" POSTGRES_TARGETS="postgres9_5" PYTHON_SINGLE_TARGET="python3_4" PYTHON_TARGETS="python2_7 python3_4" RUBY_TARGETS="ruby22" USERLAND="GNU" VIDEO_CARDS="radeon r600" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Larry the Git Cow gentoo-dev 2017-11-15 23:27:50 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=cb5c3d447d051d48ed59861904ca4b9a0f5b51df

commit cb5c3d447d051d48ed59861904ca4b9a0f5b51df
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2017-11-15 22:12:38 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2017-11-15 23:26:57 +0000

    kde-plasma/powerdevil: Drop USE=brightness-control
    
    Upstream switched it off by default in the last minute before 5.11.0
    release, after ddcutil upstream remarks, probably for a good reason.
    
    Closes: https://bugs.gentoo.org/636098
    Package-Manager: Portage-2.3.14, Repoman-2.3.6

 kde-plasma/powerdevil/metadata.xml             | 1 -
 kde-plasma/powerdevil/powerdevil-5.11.3.ebuild | 5 ++---
 2 files changed, 2 insertions(+), 4 deletions(-)
Comment 2 Larry the Git Cow gentoo-dev 2017-11-15 23:48:44 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/proj/kde.git/commit/?id=9286d9251eaad144dc65ccaf90a40b51c5bdfebb

commit 9286d9251eaad144dc65ccaf90a40b51c5bdfebb
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2017-11-15 22:43:07 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2017-11-15 22:43:07 +0000

    kde-plasma/powerdevil: Drop USE=brightness-control on stable branch
    
    Upstream switched it off by default in the last minute before 5.11.0
    release, after ddcutil upstream remarks, probably for a good reason.
    
    Closes: https://bugs.gentoo.org/636098
    Package-Manager: Portage-2.3.14, Repoman-2.3.6

 kde-plasma/powerdevil/powerdevil-5.11.49.9999.ebuild | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)