Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 635932 - net-p2p/mldonkey with >=dev-lang/ocaml-4.06 - ?
Summary: net-p2p/mldonkey with >=dev-lang/ocaml-4.06 - ?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Jesús P Rey (Chuso)
URL:
Whiteboard:
Keywords: InVCS, PATCH, PullRequest
: 705582 (view as bug list)
Depends on: 749954
Blocks: 655624 688108 ocaml-4.09
  Show dependency tree
 
Reported: 2017-10-30 19:39 UTC by Jesús P Rey (Chuso)
Modified: 2020-11-07 21:17 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mldonkey-3.1.6-r2.ebuild (mldonkey-3.1.6-r2.ebuild,4.42 KB, text/plain)
2017-10-30 19:39 UTC, Jesús P Rey (Chuso)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús P Rey (Chuso) 2017-10-30 19:39:20 UTC
Created attachment 501130 [details]
mldonkey-3.1.6-r2.ebuild

MLDonkey fails to compile with OCaml >= 4.06.

<dev-lang/ocaml-4.06 should be added to the dependencies.

Upstream confirmation: https://github.com/ygrek/mldonkey/issues/24#issuecomment-336798653
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2018-05-13 11:47:15 UTC
Comment on attachment 501130 [details]
mldonkey-3.1.6-r2.ebuild

--- mldonkey-3.1.6-r1.ebuild    2018-01-06 16:32:33.314664113 +0100
+++ mldonkey-3.1.6-r2.ebuild    2018-05-13 13:46:13.147972460 +0200
@@ -1,13 +1,14 @@
-# Copyright 1999-2018 Gentoo Foundation
+# Copyright 1999-2017 Gentoo Foundation
 # Distributed under the terms of the GNU General Public License v2

 EAPI="6"
+WANT_AUTOCONF=2.5

 inherit versionator flag-o-matic eutils autotools toolchain-funcs user

 IUSE="bittorrent doc fasttrack gd gnutella gtk guionly magic +ocamlopt upnp"

-DESCRIPTION="Multi-network P2P application written in Ocaml, with Gtk, web & telnet interface"
+DESCRIPTION="A multi-network P2P application written in Ocaml, with its own Gtk GUI, web and telnet interface"
 HOMEPAGE="http://mldonkey.sourceforge.net/"
 SRC_URI="https://github.com/ygrek/mldonkey/releases/download/release-$(replace_all_version_separators '-')/${P}.tar.bz2"

@@ -27,7 +28,8 @@
 "

 DEPEND="${RDEPEND}
-       >=dev-lang/ocaml-3.10.2[ocamlopt?]"
+       >=dev-lang/ocaml-3.10.2[ocamlopt?]
+       <dev-lang/ocaml-4.06"

 MLUSER="p2p"
Comment 2 alex Mezey 2020-05-06 03:44:53 UTC
This issue is still actual. I ran in to it yesterday.
For 2 Years this problem is localized and a fix for the ebuild proposed and no one has applied the ebuild.
Another upstream confirmation is here:
https://github.com/ygrek/mldonkey/issues/27

It looks like someone has written a patch but it's not implemented yet.

as long as neither the mldonkey guys get it fixed nor we have a patched ebuild, this is what you can do to GET YOUR OWN mldonkey compile:

Add those line's to /etc/portage/package.mask
#for net-p2p/mldonkey-3.1.6-r1
>=dev-lang/ocaml-4.06

or put the an ebuild to your local ebuilds with Jeroen's patch.
The latter is more work but will allow updating dev-lang/ocaml automatically as soon as a new version of mldonkey (with hopefully a fix for this problem) is available.
Comment 3 Jesús P Rey (Chuso) 2020-05-16 16:46:49 UTC
It works for me now with dev-lang/ocaml-4.09.0 and dev-ml/num and the latest mldonkey version from Git master.
Comment 4 Jesús P Rey (Chuso) 2020-07-10 12:27:46 UTC
A new mldonkey version was released recently which fixes this and other issues.

I submitted a pull request: https://github.com/gentoo/gentoo/pull/16648
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2020-10-17 02:10:33 UTC
*** Bug 705582 has been marked as a duplicate of this bug. ***
Comment 6 Larry the Git Cow gentoo-dev 2020-10-17 02:27:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1b70b64f68dfe5c09a67f106131448b4fc3f7643

commit 1b70b64f68dfe5c09a67f106131448b4fc3f7643
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2020-07-11 11:59:23 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-10-17 02:24:29 +0000

    net-p2p/mldonkey: version bump to 3.1.7
    
    Signed-off-by: Jesus P Rey <gentoo@chuso.net>
    Bug: https://bugs.gentoo.org/595798
    Bug: https://bugs.gentoo.org/705582
    Closes: https://bugs.gentoo.org/582136
    Closes: https://bugs.gentoo.org/615322
    Closes: https://bugs.gentoo.org/635932
    Closes: https://bugs.gentoo.org/704684
    Signed-off-by: Sam James <sam@gentoo.org>

 net-p2p/mldonkey/Manifest              |   1 +
 net-p2p/mldonkey/mldonkey-3.1.7.ebuild | 183 +++++++++++++++++++++++++++++++++
 2 files changed, 184 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=fe816fa31d9e80e8e8347f6e3a141972a67b4385

commit fe816fa31d9e80e8e8347f6e3a141972a67b4385
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2020-09-20 17:28:33 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-10-17 02:24:33 +0000

    net-p2p/mldonkey: new maintainer
    
    Signed-off-by: Jesus P Rey <gentoo@chuso.net>
    Bug: https://bugs.gentoo.org/635932
    Closes: https://github.com/gentoo/gentoo/pull/16648
    Signed-off-by: Sam James <sam@gentoo.org>

 net-p2p/mldonkey/metadata.xml | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2c924217d62588a10c038f621925686c534f992

commit f2c924217d62588a10c038f621925686c534f992
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2020-07-11 11:58:56 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-10-17 02:24:19 +0000

    acct-user/p2p: new package (378)
    
    Signed-off-by: Jesus P Rey <gentoo@chuso.net>
    Bug: https://bugs.gentoo.org/635932
    Signed-off-by: Sam James <sam@gentoo.org>

 acct-user/p2p/metadata.xml | 12 ++++++++++++
 acct-user/p2p/p2p-0.ebuild | 11 +++++++++++
 2 files changed, 23 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5720416e908c7f0f5c4333472dee5dc5563823ec

commit 5720416e908c7f0f5c4333472dee5dc5563823ec
Author:     Jesus P Rey (Chuso) <gentoo@chuso.net>
AuthorDate: 2020-07-11 11:57:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-10-17 02:23:47 +0000

    acct-group/p2p: new package (378)
    
    Signed-off-by: Jesus P Rey <gentoo@chuso.net>
    Bug: https://bugs.gentoo.org/635932
    Signed-off-by: Sam James <sam@gentoo.org>

 acct-group/p2p/metadata.xml | 12 ++++++++++++
 acct-group/p2p/p2p-0.ebuild |  8 ++++++++
 2 files changed, 20 insertions(+)
Comment 7 Jesús P Rey (Chuso) 2020-10-18 14:32:04 UTC
Reopening as discussed on #gentoo-proxy-maint as the currently stable version in Portage is still affected.

As a workaround until it's stabilized,, you can accept the unstable keyword in net-p2p/mldonkey-3.1.7.