Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 635742 - default/linux/make.defaults: unset USE=session by default
Summary: default/linux/make.defaults: unset USE=session by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Profiles (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: https://archives.gentoo.org/gentoo-de...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-29 01:27 UTC by Michael Orlitzky
Modified: 2018-01-06 16:58 UTC (History)
11 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-profiles-unset-USE-session-in-default-linux-make.def.patch (0001-profiles-unset-USE-session-in-default-linux-make.def.patch,2.31 KB, patch)
2017-12-27 00:34 UTC, Michael Orlitzky
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Orlitzky gentoo-dev 2017-10-29 01:27:35 UTC
The "session" USE flag is enabled by default for all linux profiles in default/linux/make.defaults:

  # 2010/10/21 - Ole Markus With <olemarkus@gentoo.org>
  # These USE flags were originally inserted here because of PHP
  # and were later removed by me. Reinserting the USE flags again because
  # they are global USE flags that may be expected to be set by other packages.
  USE="${USE} cli pcre session"

The "session" flag has no standard meaning across packages, so it wasn't a great global flag in the first place. It may be useful for a few packages, but a better approach these days is to put "+session" in IUSE, or to force the flag in our profiles for specific packages (dev-lang/php is already dealt with).

I suggest we disable USE=session by default. I'll eventually do that myself if no one objects after a long-enough period of time.

I'm CCing the maintainers of all affected packages. If anyone would like us to wait until they've set "+session" in their ebuilds, please just file a blocker bug against this.

Affected packages:

  * app-editors/gvim
  * app-misc/recoll
  * dev-php/agavi
  * mail-client/claws-mail
  * media-sound/patchage
  * net-irc/emech
  * x11-plugins/wmfire
  * x11-terms/mrxvt
  * x11-wm/openbox
Comment 1 Bernard Cafarelli gentoo-dev 2017-10-30 15:47:18 UTC
Thanks for the heads-up!

No update needed for x11-plugins/wmfire (on my list)
Comment 2 Michael Orlitzky gentoo-dev 2017-12-27 00:34:26 UTC
Created attachment 511706 [details, diff]
0001-profiles-unset-USE-session-in-default-linux-make.def.patch

Proposed patch. I'll send it to the -dev list in a second, and commit it after a few days of no complaints.
Comment 3 Larry the Git Cow gentoo-dev 2018-01-06 16:58:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=15490cb0fbb3a29dc024aa30b06fdcf06c23cf50

commit 15490cb0fbb3a29dc024aa30b06fdcf06c23cf50
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2017-12-27 00:04:22 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2018-01-06 16:56:12 +0000

    profiles: unset USE=session in default/linux/make.defaults.
    
    The "session" USE flag has been enabled by default for all linux
    profiles in default/linux/make.defaults since 2010. According to the
    comment in that file, the flag was added for dev-lang/php where
    session support is near-critical. But, now that we have an IUSE
    default, the global setting is redundant.
    
    This commit drops USE=session from the default/linux profile's
    make.defaults, and also drops the (now unnecessary) override of that
    flag in the features/hardened profile's make.defaults.
    
    A few other packages with "session" in IUSE will be affected by this
    change; however, the meaning of "session" varies wildly between the
    packages that use it. Since the meaning of "session" is dependent on
    the package in question, within the package itself (that is, with IUSE
    defaults) is a better place to enable this flag by default.
    
    Closes: https://bugs.gentoo.org/635742

 profiles/default/linux/make.defaults     | 2 +-
 profiles/features/hardened/make.defaults | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)