Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 635276 - dev-util/electron-1.6.11-r1 with dev-libs/icu-59.1 - ../../v8/src/runtime/runtime-i18n.cc:944:39: error: ‘u_strToUpper’ was not declared in this scope
Summary: dev-util/electron-1.6.11-r1 with dev-libs/icu-59.1 - ../../v8/src/runtime/run...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Elvis Pranskevichus
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-24 07:49 UTC by Dennis Schridde
Modified: 2017-12-08 22:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (xz-compressed) (build.log.xz,29.43 KB, application/x-xz)
2017-10-24 07:50 UTC, Dennis Schridde
Details
Build log with glibc-2.26 (build.tar.gz,786.87 KB, application/gzip)
2017-11-22 08:25 UTC, Jakub Caban
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dennis Schridde 2017-10-24 07:49:51 UTC
../../v8/src/runtime/runtime-i18n.cc: In function ‘v8::internal::Object* v8::internal::{anonymous}::LocaleConvertCase(v8::internal::Handle<v8::internal::String>, v8::internal::Isolate*, bool, const char*)’:
../../v8/src/runtime/runtime-i18n.cc:944:39: error: ‘u_strToUpper’ was not declared in this scope
   auto case_converter = is_to_upper ? u_strToUpper : u_strToLower;
                                       ^~~~~~~~~~~~
../../v8/src/runtime/runtime-i18n.cc:944:54: error: ‘u_strToLower’ was not declared in this scope
   auto case_converter = is_to_upper ? u_strToUpper : u_strToLower;
                                                      ^~~~~~~~~~~~
ninja: build stopped: subcommand failed.

I have dev-libs/icu-59.1 unmasked and installed, dev-util/electron-1.6.11-r1 seems incompatible.
Comment 1 Dennis Schridde 2017-10-24 07:50:13 UTC
Created attachment 499856 [details]
build.log (xz-compressed)
Comment 2 Elvis Pranskevichus 2017-10-28 21:13:26 UTC
It appears that older chromium versions are not compatible with >=icu-59.  See https://bugs.gentoo.org/619796.  I'll take the same approach with system-icu USE-flag.
Comment 3 Dennis Schridde 2017-10-30 16:13:04 UTC
(In reply to Elvis Pranskevichus from comment #2)
> It appears that older chromium versions are not compatible with >=icu-59. 
> See https://bugs.gentoo.org/619796.  I'll take the same approach with
> system-icu USE-flag.

Could you please also depend on <dev-libs/icu-59, so that portage can actually see the problem, and people don't have to wait for the build to fail to figure that out?
Comment 4 Jakub Caban 2017-11-22 08:24:17 UTC
New version from atom-overlay, which does not fail on ICU stuff (even with +system-icu - well done!) fail with newer glibc (2.26).

I've seen mentions on other bugtrackers about patch that solves it for chromium, but going to the patch gave me 404, so couldn't test it :(

I will attach build log.
Comment 5 Jakub Caban 2017-11-22 08:25:11 UTC
Created attachment 505606 [details]
Build log with glibc-2.26
Comment 6 Larry the Git Cow gentoo-dev 2017-12-08 22:23:01 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=08f69fe500076c4ecd3291a4297eb6b392f69985

commit 08f69fe500076c4ecd3291a4297eb6b392f69985
Author:     Elvis Pranskevichus <elvis@magic.io>
AuthorDate: 2017-12-04 16:51:54 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2017-12-08 22:22:06 +0000

    dev-util/electron: version bump to 1.6.15.
    
    Closes: https://bugs.gentoo.org/633720
    Closes: https://bugs.gentoo.org/635276
    Closes: https://bugs.gentoo.org/638270
    Closes: https://bugs.gentoo.org/638992
    Closes: https://bugs.gentoo.org/640140
    Closes: https://github.com/gentoo/gentoo/pull/6478
    
    Signed-off-by: Elvis Pranskevichus <elvis@magic.io>
    Package-Manager: Portage-2.3.13, Repoman-2.3.3

 dev-util/electron/Manifest                         |  49 +-
 ...ron-1.6.11-r1.ebuild => electron-1.6.15.ebuild} |  90 +++-
 dev-util/electron/files/chromium-gcc-7-r0.patch    | 114 ++++
 dev-util/electron/files/chromium-icu-59-r0.patch   | 582 +++++++++++++++++++++
 dev-util/electron/files/chromium-icu-60-r0.patch   |  66 +++
 .../files/chromium-python3-compat-r0.patch         |  34 ++
 .../electron/files/chromium-shared-v8-r2.patch     |  94 +---
 .../electron/files/chromium-system-icu-r0.patch    | 140 +++++
 .../electron/files/chromium-v8-icu-59-r0.patch     |  83 +++
 ...electron-1.6.11-vendor-libchromiumcontent.patch |  86 ---
 .../files/electron-1.6.15-vendor-breakpad.patch    | 223 ++++++++
 ...atch => electron-1.6.15-vendor-brightray.patch} |  74 ++-
 ...electron-1.6.15-vendor-libchromiumcontent.patch | 202 +++++++
 ...ode.patch => electron-1.6.15-vendor-node.patch} |  44 +-
 ...electron-1.6.11.patch => electron-1.6.15.patch} | 124 +++--
 .../electron/files/electron-system-icu-r0.patch    |  34 ++
 16 files changed, 1744 insertions(+), 295 deletions(-)