Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 635154 - dev-util/diffoscope: RFC: include external tool dependencies?
Summary: dev-util/diffoscope: RFC: include external tool dependencies?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Linux bug wranglers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-23 12:06 UTC by Karl-Johan Karlsson
Modified: 2017-10-24 11:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild with dependencies on external tools (diffoscope-87.ebuild,1.79 KB, text/plain)
2017-10-23 12:06 UTC, Karl-Johan Karlsson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl-Johan Karlsson 2017-10-23 12:06:04 UTC
Created attachment 499752 [details]
ebuild with dependencies on external tools

dev-util/diffoscope is quite useless without its external tools, and discovering which tools it can use is non-trivial for a user. Would it be a good idea to include that information in USE flags and RDEPEND?

It's a similar situation to automagic dependencies, since Diffoscope will use the tools if they are installed, regardless of the setting of the USE flags. On the other hand, nothing will actually break.

I read the source code (diffoscope/external_tools.py) and put together a list of all external tolls it can use that are present in Gentoo. See attached ebuild (which is also a bump to version 87).
Comment 1 Larry the Git Cow gentoo-dev 2017-10-24 11:42:48 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=85448b342438c8ababb5c023c51462c197524903

commit 85448b342438c8ababb5c023c51462c197524903
Author:     Andrey Grozin <grozin@gentoo.org>
AuthorDate: 2017-10-24 11:42:16 +0000
Commit:     Andrey Grozin <grozin@gentoo.org>
CommitDate: 2017-10-24 11:42:16 +0000

    dev-util/diffoscope: bump to 87, add USE flags
    
    Suggested-by:  Karl-Johan Karlsson <creideiki+gentoo-bugzilla@lysator.liu.se>
    Closes: https://bugs.gentoo.org/635154
    Package-Manager: Portage-2.3.11, Repoman-2.3.3

 dev-util/diffoscope/Manifest             |  1 +
 dev-util/diffoscope/diffoscope-87.ebuild | 59 ++++++++++++++++++++++++++++++++
 dev-util/diffoscope/metadata.xml         | 27 +++++++++++++++
 3 files changed, 87 insertions(+)