Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 635052 - media-sound/linuxsampler-9999: consider adding live ebuild to the main tree
Summary: media-sound/linuxsampler-9999: consider adding live ebuild to the main tree
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL: https://gitweb.gentoo.org/dev/fordfro...
Whiteboard:
Keywords: EBUILD, InOverlay
Depends on:
Blocks:
 
Reported: 2017-10-22 08:29 UTC by Miroslav Šulc
Modified: 2019-12-13 11:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Šulc gentoo-dev 2017-10-22 08:29:34 UTC
please consider adding live ebuild to the main tree. this ebuild also contains significant improvements.
Comment 1 Andreas Sturmlechner gentoo-dev 2018-12-17 00:33:39 UTC
ebuild looks more like a work in progress - we can't add several USE flags without actually using them for build switches.
Comment 2 Miroslav Šulc gentoo-dev 2018-12-17 09:06:20 UTC
(In reply to Andreas Sturmlechner from comment #1)
> ebuild looks more like a work in progress - we can't add several USE flags
> without actually using them for build switches.

i just checked all use flags and the only one that is not used anymore is dbus. so i dropped that one.

for the rest you can see this:

# ldd /usr/lib64/linuxsampler/liblinuxsampler.so.5.0.0
	linux-vdso.so.1 (0x00007ffc4ef6a000)
	libgig.so.8 => /usr/lib64/libgig/libgig.so.8 (0x00007fdc206a0000)
	libsndfile.so.1 => /usr/lib64/libsndfile.so.1 (0x00007fdc20428000)
	libjack.so.0 => /usr/lib64/libjack.so.0 (0x00007fdc201de000)
	libasound.so.2 => /usr/lib64/libasound.so.2 (0x00007fdc1fefc000)
	libpthread.so.0 => /lib64/libpthread.so.0 (0x00007fdc1fcdb000)
	libdl.so.2 => /lib64/libdl.so.2 (0x00007fdc1fad7000)
	libstdc++.so.6 => /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.0/libstdc++.so.6 (0x00007fdc1f6cf000)
	libm.so.6 => /lib64/libm.so.6 (0x00007fdc1f34f000)
	libc.so.6 => /lib64/libc.so.6 (0x00007fdc1ef83000)
	libgcc_s.so.1 => /usr/lib/gcc/x86_64-pc-linux-gnu/8.2.0/libgcc_s.so.1 (0x00007fdc1ed6b000)
	libuuid.so.1 => /lib64/libuuid.so.1 (0x00007fdc1eb64000)
	libFLAC.so.8 => /usr/lib64/libFLAC.so.8 (0x00007fdc1e928000)
	libogg.so.0 => /usr/lib64/libogg.so.0 (0x00007fdc1e720000)
	libvorbis.so.0 => /usr/lib64/libvorbis.so.0 (0x00007fdc1e4f5000)
	libvorbisenc.so.2 => /usr/lib64/libvorbisenc.so.2 (0x00007fdc1e24c000)
	libdb-6.0.so => /usr/lib64/libdb-6.0.so (0x00007fdc1de78000)
	librt.so.1 => /lib64/librt.so.1 (0x00007fdc1dc70000)
	/lib64/ld-linux-x86-64.so.2 (0x00007fdc20f30000)

and this:
https://svn.linuxsampler.org/svn/linuxsampler/trunk/configure.ac

i hope that helps to clarify the issue...
Comment 3 Andreas Sturmlechner gentoo-dev 2018-12-17 21:14:39 UTC
That's beside the point. A USE flag added without it being reflected anywhere in the configure process is a big no-no. If it's really optional you are building the package in random mode, but in fact, most of those are just false positives. It is actually libsndfile linking to flac, vorbis and ogg, not linuxsampler. Don't use ldd for those lookups.
Comment 4 Larry the Git Cow gentoo-dev 2018-12-23 22:48:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=518a5241c6bd17b5a664df32d9f235aa4ae39632

commit 518a5241c6bd17b5a664df32d9f235aa4ae39632
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-12-17 01:02:59 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-12-23 22:47:56 +0000

    media-sound/linuxsampler: 2.1.0 version bump
    
    Bug: https://bugs.gentoo.org/635052
    Closes: https://bugs.gentoo.org/556330
    Package-Manager: Portage-2.3.52, Repoman-2.3.12
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 media-sound/linuxsampler/Manifest                  |  1 +
 media-sound/linuxsampler/linuxsampler-2.1.0.ebuild | 76 ++++++++++++++++++++++
 media-sound/linuxsampler/metadata.xml              | 15 +++--
 3 files changed, 85 insertions(+), 7 deletions(-)
Comment 5 Larry the Git Cow gentoo-dev 2019-12-13 11:08:34 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8500a9cd34b9f95e096e56c1be53145e44d1f6c0

commit 8500a9cd34b9f95e096e56c1be53145e44d1f6c0
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2019-12-13 11:08:11 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2019-12-13 11:08:25 +0000

    media-sound/linuxsampler-9999: added live ebuild
    
    Closes: https://bugs.gentoo.org/635052
    Package-Manager: Portage-2.3.81, Repoman-2.3.20
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/linuxsampler/linuxsampler-9999.ebuild | 76 +++++++++++++++++++++++
 1 file changed, 76 insertions(+)