Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 634608 - media-libs/faad2: faad2-2.8.5-libmp4ff-shared-lib.patch partially unnecessary
Summary: media-libs/faad2: faad2-2.8.5-libmp4ff-shared-lib.patch partially unnecessary
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal trivial (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-18 05:44 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2017-10-18 06:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2017-10-18 05:44:05 UTC 
frontend/Makefile.am part of faad2-2.8.5-libmp4ff-shared-lib.patch contains:

-faad_LDADD = $(top_builddir)/libfaad/libfaad.la
+faad_LDADD = $(top_builddir)/libfaad/libfaad.la \
+           $(top_builddir)/common/mp4ff/libmp4ff.la


This is unnecessary. When -Wl,--as-needed is used, /usr/bin/faad is not linked against libmp4ff.so.0 library. Building succeeds after deleting frontend/Makefile.am part of faad2-2.8.5-libmp4ff-shared-lib.patch.
Comment 1 Larry the Git Cow gentoo-dev 2017-10-18 06:40:32 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=aa99c91b5fce906696ce4d0d7cce90c765baaecb

commit aa99c91b5fce906696ce4d0d7cce90c765baaecb
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2017-10-18 06:38:50 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2017-10-18 06:39:49 +0000

    media-libs/faad2: Removed unnecessary part of patch.
    
    Bug: https://bugs.gentoo.org/634608
    Package-Manager: Portage-2.3.11, Repoman-2.3.3

 media-libs/faad2/files/faad2-2.8.5-libmp4ff-shared-lib.patch | 12 ------------
 1 file changed, 12 deletions(-)}