Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 634566 - dev-qt/assistant:5 doesn't install any desktop menu entries
Summary: dev-qt/assistant:5 doesn't install any desktop menu entries
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-17 19:01 UTC by Evan Teran
Modified: 2018-02-03 13:57 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Evan Teran 2017-10-17 19:01:59 UTC
I recently noticed that when I uninstalled dev-qt/assistant-4.x that I no longer had a working menu item in KDE for assistant despite still have 5.x installed.

After a little bit of investigation, I've noticed this difference:

the 4.x ebuilds have the following:

multilib_src_install_all() {
	qt4_multilib_src_install_all

	doicon tools/assistant/tools/assistant/images/assistant.png
	make_desktop_entry assistant Assistant assistant 'Qt;Development;Documentation'
}


while the 5.x ebuilds do not. It would be nice if the ebuild create desktop entries as well so I don't have to manually create launchers for it.


Reproducible: Always
Comment 1 Larry the Git Cow gentoo-dev 2017-12-25 02:42:24 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=03235d3408db759181a4c82263cd1dd782e8abab

commit 03235d3408db759181a4c82263cd1dd782e8abab
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2017-12-25 02:42:02 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2017-12-25 02:42:14 +0000

    dev-qt/assistant: install icons and desktop file
    
    Bug: https://bugs.gentoo.org/634566
    Package-Manager: Portage-2.3.14, Repoman-2.3.6

 dev-qt/assistant/assistant-5.10.0.ebuild    | 20 +++++++++++++++++++-
 dev-qt/assistant/assistant-5.10.9999.ebuild | 20 +++++++++++++++++++-
 dev-qt/assistant/assistant-5.9.9999.ebuild  | 20 +++++++++++++++++++-
 dev-qt/assistant/assistant-5.9999.ebuild    | 20 +++++++++++++++++++-
 4 files changed, 76 insertions(+), 4 deletions(-)}
Comment 2 Davide Pesavento (RETIRED) gentoo-dev 2017-12-25 04:33:57 UTC
Not just assistant... as far as I know, no qt5 tools install a desktop file (yet).
In qt4, linguist, designer, and qdbusviewer also installed a desktop file. There may be more in qt5.

The desktop file should work independently from qtchooser configuration, therefore the Exec= line should point directly to "${QT5_BINDIR}/${tool}".

I would also include "Qt5" in the Name= line, to avoid ambiguities.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2017-12-25 07:52:36 UTC
(In reply to Davide Pesavento from comment #2)
> Not just assistant... as far as I know, no qt5 tools install a desktop file
> (yet).
> In qt4, linguist, designer, and qdbusviewer also installed a desktop file.
> There may be more in qt5.
Yep, there's definitely multiple, see also bug #577680. I just happened to pick this random bug to work on.

> The desktop file should work independently from qtchooser configuration,
> therefore the Exec= line should point directly to "${QT5_BINDIR}/${tool}".
Thanks, fixed.

> I would also include "Qt5" in the Name= line, to avoid ambiguities.
Do you think it's worth it this close to Qt 4's demise? Of course, then this might future-proof us for Qt 6.
Comment 4 Davide Pesavento (RETIRED) gentoo-dev 2017-12-26 02:21:57 UTC
(In reply to Michael Palimaka (kensington) from comment #3)
> (In reply to Davide Pesavento from comment #2)
> > I would also include "Qt5" in the Name= line, to avoid ambiguities.
> Do you think it's worth it this close to Qt 4's demise? Of course, then this
> might future-proof us for Qt 6.

Yes, not only for future-proofing, but also because having a menu entry that just says "Assistant" may not be very meaningful to the user.
Comment 5 Michael Palimaka (kensington) gentoo-dev 2018-02-03 13:57:02 UTC
For the record, this got updated to 'Qt 5 Assistant' in https://gitweb.gentoo.org/proj/qt.git/commit/?id=18b5775c3c9b1454e84f42c899ddddd7a766b2a8.
Comment 6 Michael Palimaka (kensington) gentoo-dev 2018-02-03 13:57:22 UTC
Fixed in 5.9.4.