I use Plasma Wayland session and pinentry-qt shows generic Wayland icon. In order to fix this, application should ship a desktop file with Icon="icon" attribute (e.g. see https://cgit.kde.org/plasma-workspace.git/commit/?id=97a88917a546c426be73e6bff0b248135aca7033) and call setDesktopFileName. In my opinion this is an upstream issue but when I filled an upstream bug (https://dev.gnupg.org/T3449), they said it's up to distributions. Reproducible: Always Steps to Reproduce: 1. Launch pinentry-qt on Plasma Wayland session Actual Results: Generic Wayland icon is shown Expected Results: pinentry (lock) icon is shown
(In reply to Andrius Štikonas from comment #0) > I use Plasma Wayland session and pinentry-qt shows generic Wayland icon. > Thanks for the report > In order to fix this, application should ship a desktop file with > Icon="icon" attribute (e.g. see > https://cgit.kde.org/plasma-workspace.git/commit/ > ?id=97a88917a546c426be73e6bff0b248135aca7033) and call setDesktopFileName. > > In my opinion this is an upstream issue but when I filled an upstream bug > (https://dev.gnupg.org/T3449), they said it's up to distributions. > I would normally agree it is an upstream issue, but given the upstream response, I'm open to accepting a patch for it downstream.
Thanks, I'll try to write a patch at some point, maybe over the weekend...
Created attachment 522672 [details, diff] 0001-Make-pinentry-qt-icon-work-under-Plasma-Wayland.patch Tested on Wayland. I can see the document-encrypt icon (although it shows document-encrypt from Breeze theme not the one shipped with pinentry, but I guess it's OK)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1dd048d3aea02a2cfbec81db25008e7098ac895c commit 1dd048d3aea02a2cfbec81db25008e7098ac895c Author: Kristian Fiskerstrand <k_f@gentoo.org> AuthorDate: 2018-03-21 19:34:44 +0000 Commit: Kristian Fiskerstrand <k_f@gentoo.org> CommitDate: 2018-03-21 19:34:44 +0000 app-crypt/pinentry: Make pinentry-qt icon show under Plasma-Wayland Bug: https://dev.gnupg.org/T3449 Closes: https://bugs.gentoo.org/634356 Thanks-To: Andrius Štikonas Package-Manager: Portage-2.3.24, Repoman-2.3.6 ...1.0.0-make-icon-work-under-Plasma-Wayland.patch | 52 +++++++++++ app-crypt/pinentry/pinentry-1.0.0-r3.ebuild | 103 +++++++++++++++++++++ 2 files changed, 155 insertions(+)
re-opening c.f bug 652764 comment 4
(In reply to Kristian Fiskerstrand from comment #5) > re-opening c.f bug 652764 comment 4 Hmm, what is actually incompatible about the patch? I just ran patch -p1 < pinentry-1.0.0-make-icon-work-under-Plasma-Wayland.patch patching file qt/Makefile.am patching file qt/main.cpp Hunk #1 succeeded at 354 (offset -18 lines). patching file qt/org.gnupg.pinentry-qt.desktop Seems to work...
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=57f2b63e2db775e6ae31bccfd3481671a9cd7a5f commit 57f2b63e2db775e6ae31bccfd3481671a9cd7a5f Author: Kristian Fiskerstrand <k_f@gentoo.org> AuthorDate: 2018-04-12 08:27:25 +0000 Commit: Kristian Fiskerstrand <k_f@gentoo.org> CommitDate: 2018-04-12 08:29:05 +0000 app-crypt/pinentry: Readd wayland patch Closes: https://bugs.gentoo.org/634356 Package-Manager: Portage-2.3.24, Repoman-2.3.6 app-crypt/pinentry/pinentry-1.1.0-r1.ebuild | 100 ++++++++++++++++++++++++++++ 1 file changed, 100 insertions(+)
