Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 634300 - app-arch/ipkg-utils: Bump to EAPI6
Summary: app-arch/ipkg-utils: Bump to EAPI6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Proxy Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-15 06:47 UTC by James Rowe
Modified: 2017-11-24 20:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
EAPI6 bump patch (ipkg-utils-eapi_bump.patch,1.17 KB, patch)
2017-10-15 06:47 UTC, James Rowe
Details | Diff
Updated hashlib patch (ipkg-utils-1.7.050831-hashlib-r2.patch,534 bytes, patch)
2017-10-15 06:48 UTC, James Rowe
Details | Diff
ipkg-utils-1.7.050831-r3.ebuild (ipkg-utils-1.7.050831-r3.ebuild,1.38 KB, text/plain)
2017-10-16 00:28 UTC, James Rowe
Details

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2017-10-15 06:47:24 UTC
Created attachment 498700 [details, diff]
EAPI6 bump patch

This attached patches moves ipkg-utils to EAPI6.

The attached `ipkg-utils-1.7.050831-hashlib-r2.patch` for files/ is also required, as
the original hashlib fix wasn't created for -p1 usage.  As I had to change it anyway 
I've dropped the Python 2.4 conditional import too.

Thanks,

James
Comment 1 James Rowe 2017-10-15 06:48:02 UTC
Created attachment 498702 [details, diff]
Updated hashlib patch
Comment 2 Jonas Stein gentoo-dev 2017-10-15 08:19:01 UTC
please use the complete package name cat/pkg in the title. I change it for you.
If the title is correct, we can use a nice tool which helps us to assign bugs.

Technically a patch in bugzilla is still fine.

Since your last bump we also prepared a github repository, where proxied maintainers can make pull requests
https://github.com/gentoo/gentoo
Here you have some more features such as automatic tests, if your changes have mistakes and many others can comment on your improvements.
Perhaps this is the best platform to discuss your changes, if we want to review your changes together.

So far: it was good to update the patch to -p1.

PATCHES= is the right way

Have you tested with repoman full?


 # Copyright 1999-2014 Gentoo Foundation
The header needs to be updated

The EAPI=6 bump requires a version bump or a revision bump.
https://devmanual.gentoo.org/general-concepts/ebuild-revisions/
Comment 3 James Rowe 2017-10-16 00:27:40 UTC
> please use the complete package name cat/pkg in the title. I change it for you.

  Oops, thanks.

> Technically a patch in bugzilla is still fine.
>
> Since your last bump we also prepared a github repository, where proxied maintainers can make pull requests
>https://github.com/gentoo/gentoo

  I read the new (to me) proxy maintainer docs before I started, and did decide to 
use GitHub.  However, I can't complete a clone on my side without receiving network 
errors.  I also looked at the mailing list option, but the list appeared to be 
unused.

> Have you tested with repoman full?

  Yes, and I've just checked again to make sure.  No issues reported with repoman 
2.3.3.

> The EAPI=6 bump requires a version bump or a revision bump.
https://devmanual.gentoo.org/general-concepts/ebuild-revisions/

  Okay.  I'll attach the full file.  I had chosen the diff as that is what I've 
done in the past even for bumps, but I get that things change ;)

  I'll also hold off on any other updates until I can get a clone to complete 
without error.
Comment 4 James Rowe 2017-10-16 00:28:49 UTC
Created attachment 498806 [details]
ipkg-utils-1.7.050831-r3.ebuild
Comment 5 Jonas Stein gentoo-dev 2017-10-16 10:23:22 UTC
Tahnk you for your improvements.

About your questions: I would suggest to discuss on IRC #gentoo-proxy-maint the mailinglist is indeed not used much.
Comment 6 Larry the Git Cow gentoo-dev 2017-11-24 20:50:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a8e9a3c3e099bbb8fa7d711eb555afd845ec7588

commit a8e9a3c3e099bbb8fa7d711eb555afd845ec7588
Author:     James Rowe <jnrowe@gmail.com>
AuthorDate: 2017-11-24 20:35:02 +0000
Commit:     Jonas Stein <jstein@gentoo.org>
CommitDate: 2017-11-24 20:48:20 +0000

    app-arch/ipkg-utils: Bump to EAPI=6
    
    also update import md5 patch
    
    Closes: https://bugs.gentoo.org/634300
    Package-Manager: Portage-2.3.16, Repoman-2.3.5

 app-arch/ipkg-utils/Manifest                       |  2 +-
 .../files/ipkg-utils-1.7.050831-hashlib-r2.patch   | 25 ++++++++
 .../ipkg-utils/ipkg-utils-1.7.050831-r3.ebuild     | 66 ++++++++++++++++++++++
 3 files changed, 92 insertions(+), 1 deletion(-)