Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 633754 - x11-wm/enlightenment: invalid empty flag description
Summary: x11-wm/enlightenment: invalid empty flag description
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal QA
Assignee: enlightenment+disabled
URL:
Whiteboard:
Keywords:
: 640762 (view as bug list)
Depends on:
Blocks: 648896
  Show dependency tree
 
Reported: 2017-10-08 11:02 UTC by Michał Górny
Modified: 2018-02-27 08:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
drop policy-mobile patch (enlightenment_drop_policy_use.patch,3.15 KB, patch)
2018-01-14 20:08 UTC, Vadim Efimov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-10-08 11:02:00 UTC
<flag name="enlightenment_modules_policy-mobile"/>

It should obviously be filled in.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-12-31 10:44:08 UTC
*** Bug 640762 has been marked as a duplicate of this bug. ***
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-12-31 10:52:33 UTC
Please consider this urgent, provided if E team is still alive. Otherwise, I believe we should proceed with treecleaning this.
Comment 3 Vadim Efimov 2017-12-31 14:56:32 UTC
(In reply to Michał Górny from comment #2)
> Please consider this urgent, provided if E team is still alive. Otherwise, I
> believe we should proceed with treecleaning this.

Hi,

What wrong with my answer in duplicated bug? https://bugs.gentoo.org/640762#c1

What action is expected, if even Devs of this of code drop it because they don't know what it really do?

I answer here, because most of descriptions was pulled from my overlay, a while ago, but as you can see I not gentoo dev.
Comment 4 Pacho Ramos gentoo-dev 2017-12-31 15:17:56 UTC
From your comment in the other bug I think that the solution would be to drop that USE flag completely and disable that module as it seems it's better to not use it
Comment 5 Vadim Efimov 2017-12-31 15:35:03 UTC
If all E team get lost, I'll prepare patch for that issue in day or to (because of holiday here). Is it possible to get it applied by someone else?
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-12-31 15:47:02 UTC
Every flag needs to have a description of some kind. If you have no clue what it does, then you need to either explain that or remove the flag.
Comment 7 Vadim Efimov 2018-01-14 20:08:32 UTC
Created attachment 514810 [details, diff]
drop policy-mobile patch

2 days almost become 2 weeks, but anyway - patch for removing use-flag attached.
Comment 8 Larry the Git Cow gentoo-dev 2018-02-26 10:26:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e25cf18ca19463a7d05519aa843cc76a189ab75c

commit e25cf18ca19463a7d05519aa843cc76a189ab75c
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2018-02-26 10:15:38 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2018-02-26 10:26:09 +0000

    x11-wm/enlightenment: [QA] Remove undescribed policy-mobile module
    
    Patch-by: Vadim Efimov <evadim@evadim.ru>
    Closes: https://bugs.gentoo.org/633754

 x11-wm/enlightenment/enlightenment-0.17.9999.ebuild | 2 +-
 x11-wm/enlightenment/enlightenment-0.20.5.ebuild    | 2 +-
 x11-wm/enlightenment/enlightenment-0.20.6.ebuild    | 2 +-
 x11-wm/enlightenment/enlightenment-0.21.7.ebuild    | 2 +-
 x11-wm/enlightenment/metadata.xml                   | 1 -
 5 files changed, 4 insertions(+), 5 deletions(-)