Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 633660 - x11-misc/xsr: X Steps Recorder
Summary: x11-misc/xsr: X Steps Recorder
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Domonkos Lezsák
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-07 05:34 UTC by Domonkos Lezsák
Modified: 2017-10-28 10:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
A copy of https://raw.githubusercontent.com/lezsakdomi/xsr/patch-1/xsr-1.0.0.ebuild (xsr-1.0.0.ebuild,521 bytes, text/plain)
2017-10-07 05:34 UTC, Domonkos Lezsák
Details
xsr-1.0.0.ebuild (file_633660.txt,579 bytes, text/plain)
2017-10-08 06:58 UTC, Domonkos Lezsák
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Domonkos Lezsák 2017-10-07 05:34:58 UTC
Created attachment 497944 [details]
A copy of https://raw.githubusercontent.com/lezsakdomi/xsr/patch-1/xsr-1.0.0.ebuild

Hi!

I've just created an ebuild for the first release of https://github.com/nonnymoose/xsr
It's a screen recording application, similar to the Problem Steps Recorder on Windows, but entirely written in Perl and having an MIT license.

I'll be happy, if this package is present on Gentoo.
Comment 1 Tomáš Mózes 2017-10-07 09:50:04 UTC
Hello, would you like to proxy maintain this package in Gentoo?
Comment 2 Tomáš Mózes 2017-10-07 09:56:30 UTC
A few notes to the ebuild itself:
- replace the version in SRC_URI for ${PV}. Also this creates a file v1.0.0.tar.gz in DISTFILES which is not unique, change it to ${P}.tar.gz for example. Something like:
SRC_URI="https://github.com/nonnymoose/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz"

- only put those arches to KEYWORDS that you have tested on

- media-gfx/imagemagock is probaly a typo

- are you sure you need all of ${DEPEND} to build this app?
Comment 3 Domonkos Lezsák 2017-10-07 20:01:38 UTC
(In reply to Tomáš Mózes from comment #1)
> Hello, would you like to proxy maintain this package in Gentoo?

Yes... Maybe. I'm quite new in Gentoo and this is my first (and buggy :) ) ebuild, so I am no responsible, but as stated in https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers/User_Guide#Privileges_and_responsibilities_of_proxied_maintainers:
> What you get as a proxied maintainer:
>   * training and credibility needed to become a Gentoo developer.
If so, I think, I could do it. And I would happily do it :)
Comment 4 Domonkos Lezsák 2017-10-08 06:58:54 UTC
Created attachment 498064 [details]
xsr-1.0.0.ebuild

Now passes repoman
Comment 5 Domonkos Lezsák 2017-10-08 07:09:28 UTC
(In reply to Tomáš Mózes from comment #2)
> A few notes to the ebuild itself:
> - replace the version in SRC_URI for ${PV}. Also this creates a file
> v1.0.0.tar.gz in DISTFILES which is not unique, change it to ${P}.tar.gz for
> example. Something like:
> SRC_URI="https://github.com/nonnymoose/${PN}/archive/v${PV}.tar.gz ->
> ${P}.tar.gz"
> 
> - only put those arches to KEYWORDS that you have tested on
> 
> - media-gfx/imagemagock is probaly a typo
> 
> - are you sure you need all of ${DEPEND} to build this app?

First, thank you for your suggestions.
I've solved them by pushing to https://github.com/lezsakdomi/xsr/tree/lezsakdomi/patch-1; new ebuild attached anyway in the previus comment.

You said, that I should only put those arches to KEYWORDS, what I have tested for. It's done, but please review, because this package is intended to be platform-independent (it's just a perl script).
Please note, that more complicated installation/building needed in the future, so this is why I created the cursor IUSE flag.
metadata.xml is available at https://github.com/lezsakdomi/xsr/blob/lezsakdomi/patch-1/metadata.xml

Creating a pull request is planned
Comment 6 Tomáš Mózes 2017-10-09 04:52:11 UTC
(In reply to Domonkos Lezsák from comment #5)
> You said, that I should only put those arches to KEYWORDS, what I have
> tested for. It's done, but please review, because this package is intended
> to be platform-independent (it's just a perl script).

Yes, it should work, but I don't think it's a good idea to pretend it should work on that platform until it's tested there. It's not a problem to keywords platforms later on.

Try to join the IRC (https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers), the guys around can help you with the ebuild even more.
Comment 7 Domonkos Lezsák 2017-10-21 08:41:34 UTC
Pull request created: https://github.com/gentoo/gentoo/pull/6000

Sorry for the delay!
Comment 8 Tomáš Mózes 2017-10-21 09:24:05 UTC
(In reply to Domonkos Lezsák from comment #7)
> Pull request created: https://github.com/gentoo/gentoo/pull/6000
> 
> Sorry for the delay!

You don't have to be sorry,you don't block or harm anybody :)

You got a nice PR number! :)
Comment 9 Larry the Git Cow gentoo-dev 2017-10-28 10:07:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8df6dce32e204a482dd88ceb8e04df5adc6939fb

commit 8df6dce32e204a482dd88ceb8e04df5adc6939fb
Author:     Domonkos Lezsák <lezsakdomi1@gmail.com>
AuthorDate: 2017-10-21 08:22:14 +0000
Commit:     Patrice Clement <monsieurp@gentoo.org>
CommitDate: 2017-10-28 10:06:33 +0000

    x11-misc/xsr: new ebuild.
    
    X Steps Recorder is a clone of PSR for Windows.
    
    Closes: https://github.com/gentoo/gentoo/pull/6000
    Closes: https://bugs.gentoo.org/633660

 x11-misc/xsr/Manifest         |  1 +
 x11-misc/xsr/metadata.xml     | 32 ++++++++++++++++++++++++++++++++
 x11-misc/xsr/xsr-1.0.0.ebuild | 28 ++++++++++++++++++++++++++++
 3 files changed, 61 insertions(+)
Comment 10 Patrice Clement (RETIRED) gentoo-dev 2017-10-28 10:08:34 UTC
Thanks. Very useful software indeed.