Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 633614 - dev-python/python-musicbrainz-ngs -> PYTHON_TARGET ->python3_6
Summary: dev-python/python-musicbrainz-ngs -> PYTHON_TARGET ->python3_6
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: gerion
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-06 12:38 UTC by Stefan Briesenick
Modified: 2017-10-19 18:39 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-dev-python-python-musicbrainz-ngs-fix-doc-building-a.patch (0002-dev-python-python-musicbrainz-ngs-fix-doc-building-a.patch,1.14 KB, patch)
2017-10-19 16:28 UTC, gerion
no flags Details | Diff
0001-dev-python-python-musicbrainz-ngs-prevent-d-loading-.patch (0001-dev-python-python-musicbrainz-ngs-prevent-d-loading-.patch,994 bytes, patch)
2017-10-19 18:05 UTC, gerion
no flags Details | Diff
0002-dev-python-python-musicbrainz-ngs-enable-Python-3.6-.patch (0002-dev-python-python-musicbrainz-ngs-enable-Python-3.6-.patch,851 bytes, patch)
2017-10-19 18:06 UTC, gerion
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Briesenick 2017-10-06 12:38:44 UTC
please add python3_6 to dev-python/python-musicbrainz-ngs.

compiles and works fine with 3.6

thanks!
Comment 1 gerion 2017-10-19 16:28:16 UTC
Created attachment 499286 [details, diff]
0001-dev-python-python-musicbrainz-ngs-fix-doc-building-a.patch

The attached patch fixes the doc building and adds Python 3.6.

3 of the tests fail for me, but this also was the case when the ebuild was added and has nothing to do with the Python version. Upstream has added Python 3.6 officially to the supported versions (only in git master, but the newer commits do not change something Python 3.6 related).
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-10-19 16:40:30 UTC
Given that those are two unrelated changes, could you split it into two patches, please?
Comment 3 gerion 2017-10-19 18:05:39 UTC
Created attachment 499328 [details, diff]
0001-dev-python-python-musicbrainz-ngs-prevent-d-loading-.patch
Comment 4 gerion 2017-10-19 18:06:10 UTC
Created attachment 499330 [details, diff]
0002-dev-python-python-musicbrainz-ngs-enable-Python-3.6-.patch
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-10-19 18:26:58 UTC
Thanks a lot. I'll test it and merge it if it works.
Comment 6 Larry the Git Cow gentoo-dev 2017-10-19 18:39:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f28f2b6288eac032a112dbb945317f53f7c20005

commit f28f2b6288eac032a112dbb945317f53f7c20005
Author:     Gerion Entrup <gerion.entrup@flump.de>
AuthorDate: 2017-10-19 18:03:52 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2017-10-19 18:39:14 +0000

    dev-python/python-musicbrainz-ngs: enable Python 3.6 support
    
    Closes: https://bugs.gentoo.org/633614

 dev-python/python-musicbrainz-ngs/python-musicbrainz-ngs-0.6.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)