Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 633506 - <=app-portage/kuroo-0.90.5 - depends on deprecated kdelibs4/qt4
Summary: <=app-portage/kuroo-0.90.5 - depends on deprecated kdelibs4/qt4
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Portage Tools Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: kdelibs4-removal
  Show dependency tree
 
Reported: 2017-10-04 20:35 UTC by Andreas Sturmlechner
Modified: 2018-04-01 17:34 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
profile update to pkg and slot move to kuroo:0 (1Q-2018,42 bytes, text/plain)
2018-01-10 23:51 UTC, A Schenck
Details
profile update to pkg and slot move to kuroo:0 (1Q-2018,81 bytes, text/plain)
2018-01-10 23:55 UTC, A Schenck
Details
live ebuild for the KF5/Qt5 version (kuroo-9999.ebuild,1.22 KB, text/plain)
2018-01-10 23:56 UTC, A Schenck
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2017-10-04 20:35:44 UTC
app-portage/kuroo4 depends on deprecated kdelibs4/qt4 and unfortunately still requires qt3support. It needs to be ported to kf5/qt5 to survive the upcoming Qt4 cleanup.
Comment 1 A Schenck 2017-10-05 22:32:56 UTC
Porting to KF5/Qt5 has been a task I've wanted to do for a while but my C++ has gotten rusty over the years.  I have the scripts from https://cgit.kde.org/kde-dev-scripts.git/tree/kf5 but I need some better explanation of how to do the port correctly.  Can you or kde@g.o point me towards a good reference for this?
Comment 2 Andreas Sturmlechner gentoo-dev 2017-10-06 21:43:19 UTC
So first of all you would have to port away from qt3support and kde3support. For that, have a look at KDE4PORTING.html inside the kdelibs tarball. It will also refer to several other resources you should look at.

Only once you are able to build the source with kdelibs[-qt3support] can you think about working with the kf5 kde-dev-scripts.
Comment 3 A Schenck 2017-10-09 03:34:50 UTC
(In reply to Andreas Sturmlechner from comment #2)
> So first of all you would have to port away from qt3support and kde3support.
> For that, have a look at KDE4PORTING.html inside the kdelibs tarball. It
> will also refer to several other resources you should look at.
> 
> Only once you are able to build the source with kdelibs[-qt3support] can you
> think about working with the kf5 kde-dev-scripts.

I've managed to get the current HEAD (kuroo4-9999.ebuild in gentoo-guis overlay) building with kdelibs[-qt3support].  I can't find similar *porting.html files in the plasma-(desktop|framework|integration|workspace) or qtbase-opensource-src-5.77.1 tarballs.  I'll do a search but if you could point to a good resource so I don't get lost in random internet things that would be very helpful.  I think the first problem will be to get CMakeLists pointing at Qt5 and KF5 and everything will break but that gives a starting point to fix from.
Comment 4 Andreas Sturmlechner gentoo-dev 2017-10-09 05:40:36 UTC
That would be here: https://community.kde.org/Frameworks/Porting_Notes
Comment 5 A Schenck 2017-10-10 04:22:32 UTC
(In reply to Andreas Sturmlechner from comment #4)
> That would be here: https://community.kde.org/Frameworks/Porting_Notes

I found that and http://doc.qt.io/qt-5/portingguide.html but only the KDE one talks about CMake at all and not a whole lot.  Also found https://cmake.org/cmake/help/v3.0/manual/cmake-qt.7.html#automoc but it's pretty obtuse to me.  I'll try to make some progress with that and the couple cmake scripts in kde-dev-scripts/kf5 (which seem to just delete and break things but surely I'm just not understanding).  If you have other suggestions I'd be happy to hear them (like a list somewhere of all the possible COMPONENTS for the find_package( KF5 COMPONENTS ... ) line since everything is broken up instead of just one find_package( KDE4 ) like before).
Comment 6 Andreas Sturmlechner gentoo-dev 2017-10-10 09:23:00 UTC
Not all the porting scripts work fine in all situations; for help, #kde-devel is always there with a helping hand.
Comment 7 Andreas Sturmlechner gentoo-dev 2017-11-23 22:14:28 UTC
any progress here?
Comment 8 A Schenck 2017-11-28 06:54:33 UTC
(In reply to Andreas Sturmlechner from comment #7)
> any progress here?

Made a decent progress at first but have slowed down due to starting a new job and having to move and not having Internet service yet.  Not forgotten, just taking a while.
Comment 9 Andreas Sturmlechner gentoo-dev 2017-11-29 14:17:11 UTC
Thanks for the update! There's still some time left before we can think about last-riting kdelibs.
Comment 10 A Schenck 2017-12-21 19:26:05 UTC
(In reply to Andreas Sturmlechner from comment #9)
> Thanks for the update! There's still some time left before we can think
> about last-riting kdelibs.

I have it compiling and linking but crashing on start.  Making progress.
Comment 11 A Schenck 2018-01-10 23:50:00 UTC
Much more progress!  Haven't verified everything yet, but the core functionality is working.  There seems to be a disagreement between KDEsu and KStatusNotifierItem now so the tray icon isn't showing up.  I'd like to get that working again before a proper release, but I feel good enough for a -9999 release.  I'd like to pmgmove and slotmove back to app-portage/kuroo:0 since the current name was changed before slots existed and I thought it might be useful to have the KDE3 and 4 versions co-exist, then the slot was added later as an afterthought.  It doesn't actually make sense to have multiple versions installed at the same time and the '4' suffix is obsolete.  I've attached an update file for profiles/updates/ to do the pkg and slot move.  I've also attached the -9999 ebuild.  The distfile for kuroo4-0.90.5 is also copied with the kuroo-0.90.5 name so the pkgmoved ebuild will still work.
Comment 12 A Schenck 2018-01-10 23:51:25 UTC
Created attachment 514194 [details]
profile update to pkg and slot move to kuroo:0
Comment 13 A Schenck 2018-01-10 23:54:21 UTC
Comment on attachment 514194 [details]
profile update to pkg and slot move to kuroo:0

>move app-portage/kuroo4 app-portage/kuroo
>slotmove =app-portage/kuroo-0.90.5 4 0
Comment 14 A Schenck 2018-01-10 23:55:40 UTC
Created attachment 514196 [details]
profile update to pkg and slot move to kuroo:0

Uploaded the wrong version of the profile update which was missing the slotmove at first.
Comment 15 A Schenck 2018-01-10 23:56:46 UTC
Created attachment 514198 [details]
live ebuild for the KF5/Qt5 version
Comment 16 Andreas Sturmlechner gentoo-dev 2018-01-11 00:27:08 UTC
Nice work! The dependencies for the live ebuild seem bogus though, at least dev-qt/* and kde-frameworks/* dependencies will surely be needed in DEPEND. Not sure about kde-apps/kompare, but you'll know best.

You can drop USE=debug and the extra-cmake-modules dependency, both are added by kde5.eclass. Finally, we don't have '# $Header: $' anymore. ;)
Comment 17 Larry the Git Cow gentoo-dev 2018-01-16 23:17:50 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0ca759e5965aaeafb2747bcb3f911cb0c1d2627b

commit 0ca759e5965aaeafb2747bcb3f911cb0c1d2627b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-01-16 23:14:56 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-01-16 23:17:30 +0000

    app-portage/kuroo: Add Qt5-based live ebuild
    
    Bug: https://bugs.gentoo.org/633506
    Thanks-to: Andrew Schenck <galiven@users.sourceforge.net>
    Package-Manager: Portage-2.3.19, Repoman-2.3.6

 app-portage/kuroo/kuroo-9999.ebuild | 56 +++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)}
Comment 18 Andreas Sturmlechner gentoo-dev 2018-01-17 00:03:34 UTC
I've noticed kuroo reports itself as version 17.12, do you really want to align the kuroo version with KDE Applications releases? That does not really make sense. Not even all actual KDE Applications use the bundle version, but keep their internal versioning.
Comment 19 A Schenck 2018-02-12 19:43:53 UTC
(In reply to Andreas Sturmlechner from comment #18)
> I've noticed kuroo reports itself as version 17.12, do you really want to
> align the kuroo version with KDE Applications releases? That does not really
> make sense. Not even all actual KDE Applications use the bundle version, but
> keep their internal versioning.

Sorry I disappeared for a month.  The paying job has been burning me out and I haven't been keeping up with kuroo.  Thanks for cleaning up the 9999 ebuild before committing to the main tree.  That was a lazy first pass running Machael Palimaka's ebuild helper scripts and just pasting everything into (R)DEPEND.  You're right that kdesu and kompare are just RDEPENDS, though I'd like to reduce the build dependencies a bit too.  As far as the version I was just moving to a <year>.<month>.<release number> model since the 0.90.x version numbers didn't really mean anything.  The next set of updates should hopefully be 18.2.
Comment 20 Andreas Sturmlechner gentoo-dev 2018-02-12 22:20:53 UTC
Thanks for checking back - sure getting rid of kdelibs4support would be the next step, but does not block a first KF5 release. We have about 30 days before masking kdelibs4 becomes feasible.
Comment 21 Andreas Sturmlechner gentoo-dev 2018-03-29 19:11:17 UTC
ping - do you need to get anything done before cutting a new release?
Comment 22 Larry the Git Cow gentoo-dev 2018-04-01 17:34:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3f0e54e4fd6772a07a1736b71f05ce33c86605f4

commit 3f0e54e4fd6772a07a1736b71f05ce33c86605f4
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-04-01 17:33:52 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-04-01 17:34:18 +0000

    app-portage/kuroo: Drop old Qt4-based
    
    Closes: https://bugs.gentoo.org/633506
    Package-Manager: Portage-2.3.27, Repoman-2.3.9

 app-portage/kuroo/Manifest            |  1 -
 app-portage/kuroo/kuroo-0.90.5.ebuild | 26 --------------------------
 2 files changed, 27 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4a5f909c5fcb47b87670767582a453703d5a554a

commit 4a5f909c5fcb47b87670767582a453703d5a554a
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-03-31 20:55:28 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-04-01 17:34:17 +0000

    app-portage/kuroo: Add 0.90.5_p20180106 Qt5-based snapshot
    
    Bug: https://bugs.gentoo.org/633506
    Tested-by: Andrius Štikonas <andrius@stikonas.eu>
    Package-Manager: Portage-2.3.27, Repoman-2.3.9

 app-portage/kuroo/Manifest                      |  1 +
 app-portage/kuroo/kuroo-0.90.5_p20180106.ebuild | 57 +++++++++++++++++++++++++
 2 files changed, 58 insertions(+)}