Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 633444 - <sys-auth/yubikey-personalization-gui-3.1.25 depends on deprecated Qt4 (was: please add support for building with qt5)
Summary: <sys-auth/yubikey-personalization-gui-3.1.25 depends on deprecated Qt4 (was: ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Wolfram Schlich (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks: qt4-removal
  Show dependency tree
 
Reported: 2017-10-04 08:38 UTC by Hendrik v. Raven
Modified: 2018-01-28 23:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild for qt5 (yubikey-personalization-gui-3.1.24-r1.ebuild,1.14 KB, text/plain)
2017-10-04 08:38 UTC, Hendrik v. Raven
Details
yubikey-personalization-gui-3.1.24-r1.ebuild.diff (yubikey-personalization-gui-3.1.24-r1.ebuild.diff,1.22 KB, patch)
2017-12-21 09:29 UTC, Andreas Sturmlechner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hendrik v. Raven 2017-10-04 08:38:03 UTC
Created attachment 497582 [details]
updated ebuild for qt5

At least the latest version (3.1.24) can be built against qt5 without any issues. As qt4 is dead since some time it would be nice if the ebuild could be changed to use qt5.
I've attached an updated version I created myself. I also bumped it to EAPI 6 and made the test build optional.
Comment 1 Andreas Sturmlechner gentoo-dev 2017-12-21 09:29:19 UTC
Created attachment 511354 [details, diff]
yubikey-personalization-gui-3.1.24-r1.ebuild.diff

ping
Comment 2 Jouni Kosonen 2018-01-28 17:28:02 UTC
http://yubico.github.io doesn't seem to work anymore, so
< SRC_URI="http://yubico.github.io/yubikey-personalization-gui/releases/${P}.tar.gz"
---
> SRC_URI="https://github.com/Yubico/yubikey-personalization-gui/archive/${P}.tar.gz"

Version 3.1.25 is out and builds with Qt5 too, I think I'll make a PR with that.
Comment 3 Larry the Git Cow gentoo-dev 2018-01-28 23:19:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=59b7ca6071743f139d43a8304a0a4961b6ebc1bc

commit 59b7ca6071743f139d43a8304a0a4961b6ebc1bc
Author:     Jouni Kosonen <jouni.kosonen@tukesoft.com>
AuthorDate: 2018-01-28 17:40:34 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-01-28 23:19:03 +0000

    sys-auth/yubikey-personalization-gui: version bump to 3.1.25
    
    Also, port to Qt5 and EAPI 6.
    
    Bug: https://bugs.gentoo.org/633444
    Closes: https://github.com/gentoo/gentoo/pull/6988

 sys-auth/yubikey-personalization-gui/Manifest      |  1 +
 .../yubikey-personalization-gui-3.1.25.ebuild      | 51 ++++++++++++++++++++++
 2 files changed, 52 insertions(+)}
Comment 4 Larry the Git Cow gentoo-dev 2018-01-28 23:34:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e48431ace367599d6ac127fbafbcc20e3b3a4f73

commit e48431ace367599d6ac127fbafbcc20e3b3a4f73
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-01-28 23:33:34 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-01-28 23:34:13 +0000

    sys-auth/yubikey-personalization-gui: Drop old Qt4-based
    
    Closes: https://bugs.gentoo.org/633444
    Package-Manager: Portage-2.3.20, Repoman-2.3.6

 sys-auth/yubikey-personalization-gui/Manifest      |  2 --
 .../yubikey-personalization-gui-3.1.23.ebuild      | 40 ----------------------
 .../yubikey-personalization-gui-3.1.24.ebuild      | 40 ----------------------
 3 files changed, 82 deletions(-)