Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 631796 - app-misc/recoll - clean up Qt handling
Summary: app-misc/recoll - clean up Qt handling
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: P Purkayastha
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qtbindir qt4-removal
  Show dependency tree
 
Reported: 2017-09-23 02:03 UTC by Michael Palimaka (kensington)
Modified: 2017-09-24 08:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
recoll-1.23.3.ebuild (recoll-1.23.3.ebuild,3.45 KB, text/plain)
2017-09-24 07:59 UTC, P Purkayastha
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Palimaka (kensington) gentoo-dev 2017-09-23 02:03:35 UTC
Qt 4 is dead, so please consider removing that USE flag.

Also, using QT_SELECT is not recommended as that's an implementation detail of qtchooser and cannot be relied on. It's better to call the required qt binaries directly, either by passing some build system argument or patching the source (there's some helper functions in qmake-utils.eclass to get the right directory).

Let me know if you'd like a patch.
Comment 1 P Purkayastha 2017-09-24 07:59:19 UTC
Created attachment 496210 [details]
recoll-1.23.3.ebuild

Hi,

 I have updated the ebuild to

1. include recoll-1.23.3 that has been released.
2. remove qt4 from the ebuild.

 Do let me know if the changes to the ebuild suffice.
Comment 2 Michael Palimaka (kensington) gentoo-dev 2017-09-24 08:53:31 UTC
Looks good, thanks!
Comment 3 Larry the Git Cow gentoo-dev 2017-09-24 08:53:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e8025347c1c42763173c720bbb94d01204e6aa5d

commit e8025347c1c42763173c720bbb94d01204e6aa5d
Author:     Michael Palimaka <kensington@gentoo.org>
AuthorDate: 2017-09-24 08:53:20 +0000
Commit:     Michael Palimaka <kensington@gentoo.org>
CommitDate: 2017-09-24 08:53:36 +0000

    app-misc/recoll: version bump 1.23.3
    
    Closes: https://bugs.gentoo.org/631796
    Package-Manager: Portage-2.3.8, Repoman-2.3.3

 app-misc/recoll/Manifest             |   1 +
 app-misc/recoll/recoll-1.23.3.ebuild | 123 +++++++++++++++++++++++++++++++++++
 2 files changed, 124 insertions(+)
Comment 4 Michael Palimaka (kensington) gentoo-dev 2017-09-24 08:54:29 UTC
Sorry, I forgot to update the author information before pushing the commit. My bad.