Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 631522 - cmake-utils.eclass unconditionally adds CMAKE_USER_MAKE_RULES_OVERRIDE which is not used by some packages (kde-frameworks/extra-cmake-modules, app-i18n/fcitx-table-extra)
Summary: cmake-utils.eclass unconditionally adds CMAKE_USER_MAKE_RULES_OVERRIDE which ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 659156 659160 659398 659500 659638 660584 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-09-20 13:03 UTC by Arfrever Frehtes Taifersar Arahesis
Modified: 2018-09-16 11:23 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Arfrever Frehtes Taifersar Arahesis 2017-09-20 13:03:39 UTC 
=== kde-frameworks/breeze-icons-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_QCH

=== kde-frameworks/extra-cmake-modules-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    CMAKE_USER_MAKE_RULES_OVERRIDE

=== kde-frameworks/frameworkintegration-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_QCH

=== kde-frameworks/kded-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_QCH

=== kde-frameworks/kdesignerplugin-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_QCH

=== kde-frameworks/kdewebkit-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_QCH

=== kde-frameworks/kdoctools-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_QCH

=== kde-frameworks/kimageformats-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_QCH

=== kde-frameworks/kinit-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_QCH

=== kde-frameworks/oxygen-icons-5.38.0 ===

CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_QCH
Comment 1 Andreas Sturmlechner gentoo-dev 2017-09-24 19:14:13 UTC 
Thanks, BUILD_QCH fixed in kde overlay commit c6fbbedfe2e8591f22ad76bd930827c185562e2b

However getting rid of CMAKE_USER_MAKE_RULES_OVERRIDE would require changes in cmake-utils.eclass...
Comment 2 Andreas Sturmlechner gentoo-dev 2017-10-22 15:15:02 UTC 
Since BUILD_QCH issue was fixed, let's concentrate on the remaining bit.
Comment 3 Arfrever Frehtes Taifersar Arahesis 2017-10-23 17:10:19 UTC 
The same warning about CMAKE_USER_MAKE_RULES_OVERRIDE not used is also triggered by app-i18n/fcitx-table-extra.
Comment 4 Michael Palimaka (kensington) gentoo-dev 2017-10-28 00:52:36 UTC 
I don't think there's much we can do about CMAKE_USER_MAKE_RULES_OVERRIDE. It's a cmake built-in, so I don't think there should ever be a warning about it.
Comment 5 Arfrever Frehtes Taifersar Arahesis 2018-07-07 07:48:52 UTC 
*** Bug 660584 has been marked as a duplicate of this bug. ***
Comment 6 Toralf Förster gentoo-dev 2018-07-07 08:28:04 UTC 
(In reply to Michael Palimaka (kensington) from comment #4)
So shouldn't then the QA warning be supressed ? --> which means the underlying root cause is not solved yet?
Comment 7 Andreas Sturmlechner gentoo-dev 2018-07-07 08:44:40 UTC 
*** Bug 659156 has been marked as a duplicate of this bug. ***
Comment 8 Michael Palimaka (kensington) gentoo-dev 2018-07-11 11:06:52 UTC 
(In reply to Toralf Förster from comment #6)
> (In reply to Michael Palimaka (kensington) from comment #4)
> So shouldn't then the QA warning be supressed ? --> which means the
> underlying root cause is not solved yet?

I don't think we have a way to supress this warning unfortunately. Based on my understanding of upstream documentation, a warning about use of this variable should never be issued.
Comment 9 Andreas Sturmlechner gentoo-dev 2018-09-16 08:33:35 UTC 
*** Bug 659160 has been marked as a duplicate of this bug. ***
Comment 10 Andreas Sturmlechner gentoo-dev 2018-09-16 08:33:45 UTC 
*** Bug 659638 has been marked as a duplicate of this bug. ***
Comment 11 Andreas Sturmlechner gentoo-dev 2018-09-16 08:33:53 UTC 
*** Bug 659500 has been marked as a duplicate of this bug. ***
Comment 12 Andreas Sturmlechner gentoo-dev 2018-09-16 08:34:05 UTC 
*** Bug 659398 has been marked as a duplicate of this bug. ***
Comment 13 Larry the Git Cow gentoo-dev 2018-09-16 11:23:17 UTC 
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f198fdc373429429e347c7c8b6273254a66d4076

commit f198fdc373429429e347c7c8b6273254a66d4076
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2018-09-16 08:52:36 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2018-09-16 11:22:58 +0000

    cmake-utils.eclass: Move CMAKE_USER_MAKE_RULES_OVERRIDE to gentoo config
    
    Closes: https://bugs.gentoo.org/631522

 eclass/cmake-utils.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)